FrameSort

FrameSort

88.4k Downloads

Tank frames overlap when enabling the "Display Main Tank and Assist" setting

Verubato opened this issue ยท 13 comments

commented

Enabling the "Display Main Tank and Assist" blizzard interface option shows 2 pet-sized frames next to each tank with their selected target. These frames aren't having spacing/sorting applied and end up underneath/overlapping the tank raid frame.

commented

Another interesting thing I noticed is that when you swap raid profile in combat it will break all frames.

commented

Latest update on wrath classic:

1x Frame:RegisterEvent(): Frame:RegisterEvent(): Attempt to register unknown event "ARENA_PREP_OPPONENT_SPECIALIZATIONS"
commented

Thanks Mr Kang, fixed it release 5.2.3.

commented

Have made some fixes to the frame overlapping issues in release 5.4.0 but don't think it's quite 100% fixed yet.

I haven't been able to test any of this in Wotlk as the PTR is down, so cross fingers I haven't caused any major regressions there. May have broken spacing in some situations.

Will test Wotlk once the PTR is back up.

Update 5.5.x doesnt seem to detect frames according to health check

commented

Just tested this in Retail and it's still completely messed up when enabling the "Main Tank and Assist" setting, so back to the drawing board for me.

@XyzKangUI I just released a new version 5.6.0 and then saw your message, mind checking if 5.6.0 detects frames or not? Wotlk PTR is still down >_<

commented

Ok fixed it in 5.6.1. The Wotlk PTR added CompactPartyFrame but the live servers still don't have it so I had a logic bug.

Not sure how FrameSort could be calling flowsortfunc unless using the traditional sorting method, I'll try and reproduce it.

commented

Just tested this in Retail and it's still completely messed up when enabling the "Main Tank and Assist" setting, so back to the drawing board for me.

@XyzKangUI I just released a new version 5.6.0 and then saw your message, mind checking if 5.6.0 detects frames or not? Wotlk PTR is still down >_<

Health check still claims that it cannot detect frames. Sorting/Spacing seems broken, but the hide player feature is working. If you have active gametime you could play wrath classic on a level 1. I don't expect PTR to be up anytime soon.

Also could you look into why frames are calling flowsortfunc during combat and tainting the frames. Its a rare bug.

commented

Ok fixed it in 5.6.1. The Wotlk PTR added CompactPartyFrame but the live servers still don't have it so I had a logic bug.

Not sure how FrameSort could be calling flowsortfunc unless using the traditional sorting method, I'll try and reproduce it.

Sometimes in raids the frames change in combat (e.g. RL swapping classes from group1 to group2 during fight) which would trigger a sort and break the frames. I've no proper log of it, taints lol..

This was around the time of version 5.3.x I guess and always using the taintless method.

commented

Have made some fixes to the frame overlapping issues in release 5.4.0 but don't think it's quite 100% fixed yet.

I haven't been able to test any of this in Wotlk as the PTR is down, so cross fingers I haven't caused any major regressions there. May have broken spacing in some situations.

Will test Wotlk once the PTR is back up.

commented

Going to close this issue and open a separate one as there are like 5 issues in this one ticket.

commented

I have a feeling the taint issue may have been related to the hide player feature. In the latest release I've changed the approach that should be more secure/reliable and not cause taints.

commented

I have a feeling the taint issue may have been related to the hide player feature. In the latest release I've changed the approach that should be more secure/reliable and not cause taints.

Calling Hide on secure frames, in this case raid frames, could cause taints indeed. I personally used to hide it using SetAlpha hooked into the range indicator. I see that you use the registerattributedriver now, im curious if that will hold up.

commented

Taints ! !