FrameSort

FrameSort

88.4k Downloads

Feature request: Hide player frame

XyzKangUI opened this issue ยท 12 comments

commented

Hi there, me again.

I think that it would be nice to have as a feature to hide the frame of the player unit.

I achieved that by doing the following:

            if UnitIsUnit(sourceUnit, "player") then
                source.Frame:SetPoint("TOP", UIParent, "BOTTOMLEFT", 10000, 10000)
            else
                source.Frame:SetPoint(unpack(point))
            end

Although since the implementation of spacing it gets messy.

commented

Hello hello,

Sounds like a good feature to add!

I'll work on adding this in.

commented

Hey @XyzKangUI, I've just pushed a first attempt at this.

If you happen to be around and able to give it a quick test that'd be amazing.

commented

Ah yeah I had this today as well in a BG.
I think it's a spacing feature issue when people join and leave the group.
Will add it to my TODO list to fix!

commented

@Verubato I don't get online notifications, but I felt you pinging me mentally. Will test it out right away.

commented

The new feature seems to work great, great job. I've only tested it out quickly in one battleground. Although, I noticed there is 1 sorting issue, which might have pre-existed due to pet frames (which I've disabled) or.. ? It is the gap there

image

Another sample:

image

When I hide "Group 2" while showing "Group 1 & 3" this happends:

image

Here I hide group 3 while showing 1 & 2:

image

commented

There is a rare bug in 2v2 arena where it the partner. After swapping from "Hidden" to any of the other 3 it will show "player" but not the partner.

It seems to be related when you enter arena while in combat.

commented

Had a quick look at this today and seems to be related to the spacing module.

The frames become overlapped and other weirdness when switching to/from "Hidden". When disabling spacing it seems to work fine.

Not sure if it's the same bug as before due to recent fixes/changes, but something I still need to fix of course.

commented

Release 5.0.3 has some fixes in this area that might help, haven't tested it yet though.

commented

Ok I think this should definitely be fixed in 5.0.4 now.

@XyzKangUI if you get a chance it'd be good if you can try it out.

commented

image
Text position could be a bit better, going to try out if any fragmentation happends.

Edit: So far, so good.

commented

Oh weird, the text overlap is happening in classic and wotlk but not retail or the wotlk ptr. Thanks for showing me otherwise I wouldn't have known.

commented

Closing as fixed.