Gathering Tracker

Gathering Tracker

81.5k Downloads

[Bug] Does not hide during Follower Dungeons

Starlynk1 opened this issue ยท 12 comments

commented

I checked the settings and there is no option to hide during follower dungeons. Not sure how they are any different on the check side of things, but this may be a general issue in all dungeons and it showing. Haven't tested that yet.

commented

There is no option to hide during dungeons or raids currently, though the group options sorta cover this in most cases if you have it disabled.

I will look into adding an option to have it hidden in instanced content (dungeons, raids, islands, PVP, etc).

commented

I've added a new option to have the display hide when in instances, this will be available in v2.0.13.

commented

ok, this should now be resolved with v2.3.1. I went a different direction from what you suggested, but both work just as well, though what I went with will terminate sooner. I went this route because it seems that GROUP_ROSTER_UPDATE gets spammed while in delves, so the sooner I can halt processing the better.

commented

Not sure if the recent update addresses this, but the hide during instances is not working correctly. If the tracker is already showing and you enter an instance, it will continue to display. You can turn it on and back on using the minimap button and while in an instance it will not show up again.

Seems to not be checking if its in an instance during a zone change.

commented

I think this was related to the error you posted. In my testing, this is now working with v2.2.1.

commented

Ran a delve last night and it still didn't hide. I can turn off the hud through minimap and re-enable and it won't show up until leaving the delve. So this seems to be an issue where the zone change event isn't being checked for being in an instance.

commented

it checks for instances, delves might be set up differently though. I'll have to try and find a way to test this, as I don't have TWW to do a delve.

commented

oh I meant to ask, were you in a party or solo when you ran the delve?

commented

I am normally doing these solo and can't remember what happens when in a group. Strange thing about delves is that not sure the zone change event triggers or not based on how it loads. It's not a normal portal into an instance, it's activate the delve and the fog that was blocking you disappears to let you enter. No transition noticed besides that. Possibly why once you are in a delve, you can hide the tracker and unhide it and it doesn't show up again due to being in the delve.

I will see what I can find as well, may need to use a different event for delves.

commented

Found the problem, there was a mode check with with a retun before the hide check. Here is the lua file for that change. I did add zone_changed event handler, but that most likely won't be needed as its handle in the inventoryupdate function.

Moving the mode check to after the hide check fixed it as far as I can tell with testing.
GatheringTracker.lua.zip

commented

Ah I see what you changed. I did end up getting TWW, so I should be able to get into a delve to test this in the next day or so.

commented

I would say that the zone_changed event handler isn't needed or the other zonechanged items I added. Pretty sure just moving the mode check below the inventory update would work.

When I ran debug, it wasn't even reaching the ininstance section until it was moved below.