Gathering Tracker

Gathering Tracker

81.5k Downloads

Chat spam (You aren't in a party) in a Delve

b-morgan opened this issue ยท 17 comments

commented

I'm not sure if Delve's are like Follower Dungeons but I'm getting the "You aren't in a party" chat spam.

commented

No sub? Can you use the PTR? In any case, I'm happy to help.

I've added that code, but I may not test it until tomorrow.

commented

C_PartyInfo.IsDelveInProgress() appears to be available as well.

commented

Not sure that would work though, as I'm guessing (from how it gets used in blizzard code) that it will return false once a delve is complete (even if you are still inside the delve).

commented

yeah delves are similar to follower dungeons, you are in a party with the NPC, but its not a fully functional party. I'll figure out how to prevent the party stuff from firing in delves.

commented

Can you add this to GT:IsInGroup() and test if it works? I don't have a sub and can't access delves to test.

if select(3, GetInstanceInfo()) == 208 then return false end

commented

I'm gonna close this for now, please reopen if this continues.

commented

You are correct... In the middle of the Delve:

[06:36:46] Dump: value=C_LFGInfo.IsInLFGFollowerDungeon()
[06:36:46] [1]=false
[06:36:46] Dump: value=C_PartyInfo.IsDelveInProgress()
[06:36:46] [1]=true
[06:36:46] Dump: value=select(3, GetInstanceInfo())
[06:36:46] [1]=208,
[06:36:46] [2]="Delves",
[06:36:46] [3]=5,
[06:36:46] [4]=0,
[06:36:46] [5]=false,
[06:36:46] [6]=2681,
[06:36:46] [7]=1

After defeating the final boss but before looting:

[06:46:30] <DBM> Delves(3) - Kriegval's Rest completed after 29 minutes and 22.55 seconds! Your last clear took 29 minutes and 19.55 seconds and your fastest clear took 29 minutes and 19.55 seconds. You have 3 total clears.
[06:46:31] Kuvkel says: My gratitude. I'll make sure these items make it back to the right sectors.
[06:46:57] Dump: value=C_LFGInfo.IsInLFGFollowerDungeon()
[06:46:57] [1]=false
[06:46:57] Dump: value=C_PartyInfo.IsDelveInProgress()
[06:46:57] [1]=false
[06:46:57] Dump: value=select(3, GetInstanceInfo())
[06:46:57] [1]=208,
[06:46:57] [2]="Delves",
[06:46:57] [3]=5,
[06:46:57] [4]=0,
[06:46:57] [5]=false,
[06:46:57] [6]=2681,
[06:46:57] [7]=1

As luck would have it, I didn't loot any of my selected filter (Blacksmith / Miner and there was no ore this run). What timezone are you in? I'm in the Mountian timezone, Colorado Springs, Colorado.

commented

I'm still getting "You aren't in a party" chat spam in a delve (but it is not as frequent as before).

[07:21:03] Brann Bronzebeard begins making a campfire.
[07:21:03] Brann Bronzebeard says: Let's have a quick sit-down tae recover.
[07:21:07] You aren't in a party.
[07:21:07] You receive loot: [Pierced Jambeaux]
[07:21:08] You loot 7 Gold, 98 Silver, 97 Copper
[07:21:37] Brann Bronzebeard begins mining.
[07:21:38] Brann Bronzebeard says: This one's rumbling with power. Let's see what it holds!
[07:21:38] Brann Bronzebeard yells: Freshly mined!
[07:21:39] Brann Bronzebeard helped you gather something extra:
[07:21:39] You receive item: [Bismuth |A:Professions-ChatIcon-Quality-Tier1:17:15::1|a]
commented

Well at least that partly worked. I'll take a look and see if I can figure out where else might be causing that. I'm also in Mountain, up in the Denver area actually.

commented

Hmm, the fact you are still getting that message is strange. Though I suspect it is likely related to the odd behavior of the group in Delves. Brann constantly leaves and joins your group while you are in a delve, its really strange. So "GROUP_ROSTER_UPDATE" gets spammed a ton. I'm guessing that somehow that spam is causing something to not work correctly. I'm getting an error when I try to install the PTR right now, but I'll keep trying. Until then, I'm not sure I'll be able to figure this out without being able to get into a delve to test.

commented

Let me know when you run out of options.

Have you signed up for CurseForge authors rewards? I'm the author / maintainer of Skillet and Skillet-Classic and I get enough money to pay for my subscription.

commented

Yeah, I have CurseForge rewards, but this addon isn't popular enough to cover that.

commented

Skillet-Classic gets more downloads than Skillet these days. Have you considered porting to Cataclysm Classic and or Classic Era?

Just for fun I changed ## Interface: 11504, 40400, 110005 and moved it to Cataclysm Classic. It loads and some things work.

Do you have a Paypal (or Zelle) account? I'll send you $15 for a month's subscription.

commented

I've considered adding Classic, but never felt like putting in the time for it. I appreciate the offer, but you don't need to send me money, I don't have a sub mostly because I just don't play the game and can generally work on my addon without one. It looks like I have enough points saved up on curse to pay for a sub anyways.

commented

OK. I'm willing to help debug (on any flavor).

commented

v2.6.7 has been released.

commented

hmm, I just ran a delve and didn't get "You aren't in a party" at all. Also, it looks like blizzard fixed Brann spam joining and leaving the party.

I'll get a release out with the fix I've added and that keybind you wanted and see if you still get it with the new version.