Addressing incorrect/errant nodes
Dgc2002 opened this issue · 3 comments
Examples:
An "Iron Deposit" with the icon of a herb in Elwynn Forest:
Plaguebloom in Elwynn Forest
Looking through GatherLite.lua in my SavedVariables I see the following incorrect herbs:
Click to expand
Arthas' of Melon Juice
Arthas' TChest
Arthas' Teaower Crystal
Arthas' Teit
Arthas' Teower Crystal
Arthas' Tm Vein
Bigode-de-hadgar
Black Lotu
Black Lotuein
Black Lotuposit
Black Lotuum Vein
Blindweed Thorium Vein
Blindweeeposit
Blindweeit
Blindwposit
Botão-da-paz
Botãoças Sortidas
Briarthoosit
Briarthorn Chest
Briarthornum Vein
Briartht
Bruise Vein
Bruisein
Bruiseweidian
Bruism Vein
CoVein
Cravespinho
DreamfChest
Dreamfoi`Crystal
Dreamfoil Chest
Dreamfoil Formation
DreamfoilDeposit
Dreamfoiled Chest
Dreamfoilium Vein
Dreamfoosit
Dreamfos
Earthro Vein
Earthrooosit
Earthroor Deposit
Ervassol
Estrangulalga
Fadeleaf
Folha-prata
Ghost Mum Vein
Ghost Musein
Ghost Mush Vein
Ghost Mush`Chest
Ghost Mushrf Heroes
Ghost Mushrm Vein
Ghost Mushrosit
Ghost Musht
Ghost Musit
Golden Chest
Golden Crystal
Golden irt Pile
Golden San Vein
Golden San
Golden Saneposit
Golden Sans`Vein
Golden Sansam
Golden Sanst
Golden Sanum Vein
Golden Sr Crystal
Goldthor Deposit
Goldthor Vein
GoldthVein
Grave Mosseposit
Gromsbl Vein
Gromsblom Vein
Gromsbloode
GromsblPower Crystal
Gromsblyltan
Khadgar'lo's Riddle
Khadgar's e
Khadgar's m Vein
Khadgar's4
Kingsblo`Crystal
Kingsbloeposit
Kingsblt Pile
Kingst
Liferoot
Liferootit
Mager`Vein
Magereposit
Magi-real
Mountain Heroes
Mountain `Vein
Mountain Deposit
Mountain it
Mountain m Vein
Mountain n
Mountain red Chest
Mountain S
Mountain S`Crate
Mountain S`Vein
Mountain Silm
Mountain SilMithril Deposit
Mountain Silvers`Vein
Mountain Silversag Crystal
Mountain Silversaosit
Mountain Silversit
Mountain Sim Vein
Mountain Sin
Mountain Siosit
Mountain Sorium Vein
Mountain Sst
Mountain
Mountain/sit
Mountain/yal
Mountain5m Vein
Mountainosit
Pea Chest
Peaceblooelp
Peacebloom Vein
Peacebloomum Vein
Plagueb Vein
Plaguebeposit
PlaguebloDirt Pile
Plaguebloo Crate
Plaguebloo Vein
Plaguebloo
Plaguebloo`Vein
PlagueblooChest
Plagueblooed Chest
Plagueblooest
Plaguebloom Vein
Plaguebloomd
Plaguebloomeposit
Plaguebloomium Vein
Plaguebloomm Vein
Plaguebloomn
Plaguebloomosit
Plaguebloomsbite
Plaguebloomum Vein
PlaguebloomVein
Plagueblooosit
Plaguebloosit
Plaguebloost
Plaguebloot
Plagueblootered Chest
Plaguebloposit
Plagueblost
Plagueblot
PlagueblVein
Plaguebm Vein
PlaguebVein
Purple Lotu
Raiz-da-vida
Raiz-telúrica
Silverlet
SilvVein
StranglekChest
Stranglit
Sungrassit
Wein
Wild Steelbloom
Wild Steelit
Wild Steelposit
Is there currently a way to deal with these? AFAIK they're basically permanent if I intend to leave P2P on. I haven't looked much at the code but I'd assume any node that a client is missing will be added if a peer has it. So for example my entire guild is now stuck with these nodes.
One solution could be to allow users to blacklist certain nodes. I see that nodes don't have a GUID but a reasonably unique identifier can be created from the node's coordinates and name.
Yes I should have done it from the beginning and I haven’t had the time to do it yet since there’s a lot of problems this may cause. I’ve gotta focus on making all the nodes bilingual first so a node in German will be displayed in English if a user isn’t using the German language. Which has been a real pain atm.