GearMenu

GearMenu

221k Downloads

TBC update

padkipz opened this issue · 5 comments

commented

Are there any plans for a TBC update? Appreciate we're still in early stages of beta, but current error is:

Message: Interface\AddOns\GearMenu\gui/GM_GearBar.lua:59: attempt to call method 'SetBackdrop' (a nil value)
Time: Mon Apr 12 12:47:07 2021
Count: 1
Stack: Interface\AddOns\GearMenu\gui/GM_GearBar.lua:59: attempt to call method 'SetBackdrop' (a nil value)
[string "@interface\AddOns\GearMenu\gui/GM_GearBar.lua"]:59: in function BuildGearBar' [string "@Interface\AddOns\GearMenu\code/GM_Core.lua"]:180: in function Initialize'
[string "@interface\AddOns\GearMenu\code/GM_Core.lua"]:101: in function `OnEvent'
[string ":OnEvent"]:1: in function <[string ":OnEvent"]:1>

Locals: gearBarFrame = GM_GearBar {
0 =
}
gearBarSlotSize = 40
(*temporary) = nil
(*temporary) = GM_GearBar {
0 =
}
(*temporary) =

{
bgFile = "Interface\DialogFrame\UI-DialogBox-Background"
}
(*temporary) = "attempt to call method 'SetBackdrop' (a nil value)"
mod =
{
gearBar =
{
}
combatQueue =
{
}
itemManager =
{
}
addonConfiguration =
{
}
gearManager =
{
}
gearSlotMenu =
{
}
cmd =
{
}
generalMenu =
{
}
target =
{
}
L =
{
}
common =
{
}
uiHelper =
{
}
logger =
{
}
aboutContent =
{
}
RegisterEvents = defined @interface\AddOns\GearMenu\code/GM_Core.lua:61
ShowWelcomeMessage = defined @interface\AddOns\GearMenu\code/GM_Core.lua:203
macro =
{
}
tooltip =
{
}
changeMenu =
{
}
OnEvent = defined @interface\AddOns\GearMenu\code/GM_Core.lua:98
configuration =
{
}
quickChange =
{
}
OnLoad = defined @interface\AddOns\GearMenu\code/GM_Core.lua:52
Initialize = defined @interface\AddOns\GearMenu\code/GM_Core.lua:171
filter =
{
}
quickChangeMenu =
{
}
ticker =
{
}
tag = "Core"
}
me =
{
GearSlotOnEnter = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:574
StartDragFrame = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:457
SetKeyBindingFont = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:218
ShowCooldowns = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:673
HideCooldowns = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:664
SetupDragFrame = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:447
UpdateGearBarTextures = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:318
CreateGearSlot = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:90
CreateCombatQueueSlot = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:164
UpdateSpellRange = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:242
GearSlotOnDragStart = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:630
GearSlotOnLeave = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:592
ShowKeyBindings = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:646
UpdateClickHandler = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:529
GearSlotOnReceiveDrag = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:602
HideKeyBindings = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:655
StopDragFrame = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:468
GearSlotOnClick = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:545
UpdateCombatQueue = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:421
SetupEvents = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:492
UpdateTexture = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:402
UpdateGearBar = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:272
UpdateGearSlotCooldown = defined @interface\AddOns\GearMenu\gui/GM_GearBar.lua:375
UpdateKeyBindings = defined @interface\AddOns\GearMenu\

Thanks for all your work on this during classic!

commented

Hi guys,

Sorry about the silence worked a lot on the 2.0.0 release for gearmenu.

I also put some thought in how I want to continue development for gearmenu with burning crusade classic coming out. I decided to have this in a separate repository because I think the addon will diverge more and more from the classic version with time passing and I don't want to have if classic else blocks all over the place.

You can find the bcc repository here if you're interested - https://github.com/RagedUnicorn/wow-bcc-gearmenu

For all the people that are not interested in the code this should be fully transparent. The project will be the same on curseforge. There will be a new version showing up with the supprted version 2.5.1(tbc). An example for that you can see here https://www.curseforge.com/wow/addons/pulse/files

I also found some additional issues besides the obvious BackdropTemplate change and fixed those. I currently have a fully working version commited to the new wow-bcc-gearmenu repository (no release yet) and doing last tests on the ptr server. Meaning you should expect to have a version ready for the prepatch.

Cheers,
RagedUnicorn

commented

Closing this. The version is available and seems to be working.

Cheers,
RagedUnicorn

commented

Hi @padkipz

You're welcome. I didn't play much classic lately but will definitely be back with TBC and thus I can say that yes GearMenu will support TBC (I want it myself :)).

Sadly I don't have access to the beta myself but the issue above I already saw and should be an easy fix. Overall I don't expect a lot of work for it to work on tbc. I might start working on the update in a couple days. If there are people that read this, have access to the beta and are willing to support me please let me know. Then I might be able to add first versions to this ticket to try out.

Reference for me: https://www.wowinterface.com/forums/showthread.php?p=336634#post336634

Cheers,
RagedUnicorn

commented

Thanks for the quick response!

I have access to the beta myself and am more than willing to help out if I can.

commented

seems to be super easy.

changed files:

GM_GearBar.lua

 91:      local gearSlot = CreateFrame(
 92:        "Button",
 93:        RGGM_CONSTANTS.ELEMENT_GEAR_BAR_SLOT .. position,
 94:        gearBarFrame,
 95:        "SecureActionButtonTemplate" and "BackdropTemplateMixin" and "BackdropTemplate"
  )

GM_UiHelper.lua

97: local highlightFrame = CreateFrame("FRAME", nil, slot, "BackdropTemplateMixin" and "BackdropTemplate")

GM_ChangeMenu.lua

51: changeMenuFrame = CreateFrame("Frame", RGGM_CONSTANTS.ELEMENT_GEAR_BAR_CHANGE_FRAME, gearBarFrame, "BackdropTemplateMixin" and "BackdropTemplate")
102: local changeSlot = CreateFrame("Button", RGGM_CONSTANTS.ELEMENT_GEAR_BAR_SLOT .. position, frame, "BackdropTemplateMixin" and "BackdropTemplate")

i don't know how curseforge works here and u prolly need to declare someting to new to have a tbc version of the addon...