GladiusEx

GladiusEx

Addons
4M Downloads

Do talent detection

vendethiel opened this issue ยท 11 comments

commented

https://mods.curse.com/addons/wow/libgroupinspect

We might need to manually enter data points (spell id => position in the tree, I mean).

Not sure how to detect PVP talents.

commented

Even though it isn't documented as such on e.g. wow.amepedia, it seems GetPvpTalentInfo can use inspect data

commented

will probably have to fork LibGroupInSpecT, since the maintainer seems a bit inactive and there's no repo on GH.

commented

From:
https://github.com/tomrus88/BlizzardInterfaceCode/blob/c9d5cf53f3165beb2850dfde793d531e4b9dbaec/Interface/AddOns/Blizzard_InspectUI/InspectPVPFrame.lua#L75-L76

It seems that the GetActiveSpecGroup(true) hack I used (as GetActiveTalentGroup) for wotlk addons is still needed..

commented

my hacked-on version of LibGroupInSpecT does primitive pvp detection, but the maintainer doesn't seem to check wowace often. Not sure what to do yet, might end up forking the lib...

The basics work tho, talent detection works correctly. I also added LibFunctional to LibCT, just to make it easier to manipulate the data (here, remove the previously-detected talents).

commented

I just realized we have it as a dependency already, it's just seemingly unused.

commented

Oh, alright.
Guess I can try to bend LibCooldownTracker to force-detect a spell. I can probably make this more generic:

https://github.com/vendethiel/LibCooldownTracker-10/blob/f703b7d40530f114f918f9d1b08bfc1909b73814/library.lua#L461

I'm just not sure how I should "un-detect" when someone specs out of a spell. Sounds tough.

How do you do these code embeds?

commented

I used the "copy permalink" option in the three dots button and just pasted that link here.

commented

Okay, well, I'm not sure how that works.

commented

Looks like it. Thanks for checking