Party > Auras > Debuffs > Show only dispellable not working
abstract-entity opened this issue · 7 comments
Ahh, that looks like a typo/copypaste-o. Thanks, I'll try to take a look in the afternoon or tomorrow.
When can we expect next version @vendethiel ? :)
THX, but for me this problem still occurs :( I want to mention that my bug occurs in Arena > Auras > Debuffs > Show only dispellable. (not Party)
Edit: I hacked it locally :D and managed to work for my Resto Shammy:
It is very ugly solution.... I believe it is not optimised because i removed the first if
.
And dont look at this dispelType == Curse :D it shouldnt be there
it is me again :)
I think i found reasons why it didin't work:
First: isBuff
doesnt exist, it need to be repalced with buffs
variable - which comes from params
Second: uppercase "MAGIC" does not work, it has to be "Magic"
At least for me it helped, and I can see dispellable buffs for my Shaman. (works only in Arena, in test mode it doesnt):
local function CanDispel(unit, buffs, dispelType, spellID)
if (buffs and not UnitCanAttack("player", unit)) or (not buffs and not UnitCanAssist("player", unit))then
return false
end
-- TODO update LibDispellable
-- TODO handle the *other* evoker dispels
local hasMonkDispel = IsPlayerSpell(115450)
local hasEvokerDispel = IsPlayerSpell(360823)
local hasShamanDispel = IsPlayerSpell(378773)
local hasDispel = hasMonkDispel or hasEvokerDispel or hasShamanDispel
if buffs and hasDispel and dispelType == "Magic" then
return true
end
return LD:CanDispel(unit, buffs, dispelType, spellID)
end