TBC Classic errors:
yoshimo opened this issue ยท 10 comments
BC Classic is some sort of hybrid between classic and 9.1 api, so right now it is a nasty
I made the following changes to process
existsClassic = (WOW_PROJECT_ID == WOW_PROJECT_BURNING_CRUSADE_CLASSIC),
in Grail.lua
i removed everything inside _SendQuestChoiceList to avoid an error
Message: ..\AddOns\Grail\Grail.lua line 11374:
'}' expected (to close '{' at line 11243) near '['
might be my own fault in my local patched version though.
Now we have
Message: ..\AddOns\Grail\Grail.lua line 8548:
attempt to concatenate local 'soughtParameter' (a nil value)
which might have to do with Bloodelfs being new in that expansion
https://github.com/yoshimo/Grail/tree/bcc
Not completely done yet but it should be able to record things
So I tried this, and it didn't seem to work. Do you have a working fix you can upload and link?
So is wholly at fault then? Coz I swapped out my existing Grail for a copy from your link.
Still getting the following errors in game:
Date: 2021-05-30 06:44:35
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\Wholly\Wholly.lua line 3852:
attempt to call method 'SetBackdrop' (a nil value)
Debug:
[string "=[C]"]: SetBackdrop()
[string "@wholly\Wholly.lua"]:3852: _SetupSearchFrame()
[string "@wholly\Wholly.lua"]:686: ?()
[string "@wholly\Wholly.lua"]:2526: _OnEvent()
[string "@wholly\Wholly.lua"]:4427:
Wholly\Wholly.lua:4427
Locals:
Um, hang on a sec..
Regarding Wholly's lua, I added:
else
if not frame.SetBackdrop then
Mixin(frame, BackdropTemplateMixin)
end
Just before
frame:SetBackdrop({
This got the frame to display at least, but there's no quest text, and now it's throwing up the following issues which are beyond me XD
Date: 2021-05-30 07:10:29
ID: 2
Error occured in: Global
Count: 1
Message: ..\AddOns\Wholly\Wholly.lua line 2605:
attempt to index field 'color' (a nil value)
Debug:
[string "=[C]"]: ?
[string "@wholly\Wholly.lua"]:2605: _PrettyQuestCountString()
[string "@wholly\Wholly.lua"]:1839: _FilterQuests()
[string "@wholly\Wholly.lua"]:1871: _FilterPanelQuests()
[string "@wholly\Wholly.lua"]:3494: ScrollFrame_Update()
[string "@wholly\Wholly.lua"]:3381: ScrollFrame_Update_WithCombatCheck()
[string "@wholly\Wholly.lua"]:1883: _ForcePanelMapArea()
[string "@wholly\Wholly.lua"]:2769: _ProcessInitialUpdate()
[string "@wholly\Wholly.lua"]:2539: OnShow()
[string "@wholly\Wholly.lua"]:4023:
Wholly\Wholly.lua:4022
[string "=[C]"]: Show()
[string "@wholly\Wholly.lua"]:4362: ToggleUI()
[string "@wholly\Wholly.lua"]:4185: SlashCommand()
[string "@wholly\Wholly.lua"]:1993: ?()
[string "@..\FrameXML\ChatFrame.lua"]:4825: ChatEdit_ParseText()
[string "@..\FrameXML\ChatFrame.lua"]:4488: ChatEdit_SendText()
[string "@..\FrameXML\ChatFrame.lua"]:2916:
..\FrameXML\ChatFrame.lua:2909
[string "=[C]"]: UseAction()
[string "@..\FrameXML\SecureTemplates.lua"]:338: handler()
[string "@..\FrameXML\SecureTemplates.lua"]:616: SecureActionButton_OnClick()
[string ":OnClick"]:4:
[string ":OnClick"]:1
Locals:
=================================================================
and
Date: 2021-05-30 07:10:22
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\Wholly\Wholly.lua line 3697:
hooksecurefunc(): QuestMapLogTitleButton_OnEnter is not a function
Debug:
[string "=[C]"]: ?
[string "=[C]"]: hooksecurefunc()
[string "@wholly\Wholly.lua"]:3697: _SetupBlizzardQuestLogSupport()
[string "@wholly\Wholly.lua"]:723: ?()
[string "@wholly\Wholly.lua"]:2526: _OnEvent()
[string "@wholly\Wholly.lua"]:4431:
Wholly\Wholly.lua:4431
Locals:
=============================================================
and
Date: 2021-05-30 07:15:48
ID: 3
Error occured in: Global
Count: 4
Message: ..\SharedXML\HybridScrollFrame.lua line 67:
bad argument #1 to 'min' (number expected, got nil)
Debug:
[string "=[C]"]: ?
[string "=[C]"]: min()
[string "@..\SharedXML\HybridScrollFrame.lua"]:67:
..\SharedXML\HybridScrollFrame.lua:57
Locals:
[edited] removed all the addon references to clean it up
Still getting an issue where Wholly complains that it needs Grail version 110 or later to work
I believe this is no longer happening with the latest GitHub code based on comments in #278
I think the existsClassic definition might be best to be expanded so instead of that one line two things should happen:
existsClassicBasic = (WOW_PROJECT_ID == WOW_PROJECT_CLASSIC),
existsClassicBurningCrusade = (WOW_PROJECT_ID == WOW_PROJECT_BURNING_CRUSADE_CLASSIC),
and then just before the code that looks like:
if self.existsClassic then
self.environment = "_classic_"
end
the following can be added:
self.existsClassic = self.existsClassicBasic or self.existsClassicBurningCrusade,
I believe the issue with the _SendQuestChoiceList error is fixed with the code I pushed today.