Shields status not working on Mop Classic Beta
holypalaswe opened this issue ยท 3 comments
Grid2 v2.8.81
MoP Classic Beta 5.5.0.60700
Works fine with shields status set to load: never.
11x Grid2/modules/StatusShields.lua:60: attempt to call upvalue 'UnitGetTotalAbsorbs' (a nil value)
[Grid2/modules/StatusShields.lua]:60: in function 'IsActive'
[Grid2/GridIndicator.lua]:157: in function 'GetCurrentStatus'
[Grid2/GridIndicator.lua]:101: in function 'Update'
[Grid2/GridFrame.lua]:195: in function 'UpdateIndicators'
[Grid2/GridFrame.lua]:89: in function <Grid2/GridFrame.lua:81>
[C]: in function 'SetAttribute'
[Blizzard_FrameXML/SecureGroupHeaders.lua]:210: in function <...faceBlizzard_FrameXML/SecureGroupHeaders.lua:130>
[Blizzard_FrameXML/SecureGroupHeaders.lua]:495: in function <...faceBlizzard_FrameXML/SecureGroupHeaders.lua:394>
[C]: in function 'Show'
[Grid2/GridLayout.lua]:733: in function 'ForceFramesCreation'
[Grid2/GridLayout.lua]:720: in function 'FixHeaderAttributes'
[Grid2/GridLayout.lua]:602: in function 'AddHeader'
...[C]: ?
[BugSack/Libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua]:19: in function <...ack/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>
[BugSack/Libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua]:54: in function 'SendMessage'
[Grid2/GridRoster.lua]:406: in function 'GroupChanged'
[Grid2/GridRoster.lua]:338: in function '?'
[BugSack/Libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua]:109: in function <...ack/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:109>
[C]: ?
[BugSack/Libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua]:19: in function <...ack/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>
[BugSack/Libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua]:54: in function 'Fire'
[Grid2/Libs/AceEvent-3.0-4/AceEvent-3.0.lua]:120: in function <...faceGrid2/Libs/AceEvent-3.0/AceEvent-3.0.lua:119>
Locals:
_ = <table> {
indicators = <table> {
}
priorities = <table> {
}
dbx = <table> {
}
name = "shields"
enabled = true
}
unit = "player"
(*temporary) = nil
(*temporary) = "player"
(*temporary) = "attempt to call upvalue 'UnitGetTotalAbsorbs' (a nil value)"
UnitGetTotalAbsorbs = nil
4x AceEvent30Frame:RegisterEvent(): AceEvent30Frame:RegisterEvent(): Attempt to register unknown event "UNIT_ABSORB_AMOUNT_CHANGED"
[C]: in function 'RegisterEvent'
[Dominos/libs/AceEvent-3.0-4/AceEvent-3.0.lua]:33: in function 'OnUsed'
[AdvancedInterfaceOptions/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua]:132: in function 'RegisterEvent'
[Grid2/modules/StatusShields.lua]:16: in function 'OnEnable'
[Grid2/GridStatus.lua]:98: in function 'RegisterIndicator'
[Grid2/GridIndicator.lua]:114: in function 'RegisterStatus'
[Grid2/GridSetup.lua]:64: in function 'SetupStatusMap'
[Grid2/GridSetup.lua]:80: in function 'Setup'
[Grid2/GridCore.lua]:185: in function 'LoadConfig'
[Grid2/GridCore.lua]:200: in function 'ProfileChanged'
[Grid2Options/modules/general/GridExportImport.lua]:183: in function '?'
[AdvancedInterfaceOptions/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua]:109: in function <...ons/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:109>
[C]: ?
[AdvancedInterfaceOptions/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua]:19: in function <...ons/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>
[AdvancedInterfaceOptions/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua]:54: in function 'Fire'
[Dominos/libs/AceDB-3.0-30/AceDB-3.0.lua]:462: in function 'SetProfile'
[Grid2Options/modules/general/GridExportImport.lua]:186: in function <...ns/Grid2Options/modules/general/GridExportImport.lua:141>
[Grid2Options/modules/general/GridExportImport.lua]:221: in function <...ns/Grid2Options/modules/general/GridExportImport.lua:219>
Locals:
(*temporary) = AceEvent30Frame {
}
(*temporary) = "UNIT_ABSORB_AMOUNT_CHANGED"
If fixed the crash in Grid2 Cataclysm version (now the cataclysm custom shield system is used in MoP so only some specific players shields spells are tracked.)
I think this maybe should be considered a Blizzard Bug: HealsAbsorb API does not exist in MoP classic (UnitGetTotalAbsorbs function does not exist) but this API was original implemented in MoP patch 5.2.0, and blizzard is using patch 5.5.0, so this API should be enabled in MoP classic version too.
If someone wants to apply a BUG report to blizzard, here are the original 5.2 path API changes:
https://wowpedia.fandom.com/wiki/Patch_5.2.0/API_changes
"Absorption effects are now displayed over the default UI's health bars; it is possible for addons to retrieve the total amount of absorption stacked on a unit."
And this is not true for MoP 5.5.0 classic beta.
Probably the same is happening with heal abosbs shieldds, and UnitGetTotalHealAbsorbs is missing, this function was added in patch 5.4. But in this case there is no crash because all heal abosrbs shields statuses are disabled for classic versions in Grid2.
You can try this beta version:
https://www.wowace.com/projects/grid2/files/6532816