translation issue [BUG]

Question

translation issue [BUG]

Gyffes opened this issue 3 years ago · 8 comments

Gyffes commented 3 years ago

🔵 Describe the bug:
In the Macro Variables area
the spells are displayed white. And do not work.

Only when I overwrite the spells with my game language they have a function again.

🔵 The error:
No Error

🔵 Screenshots:
see above

🔵 Expected behavior:
automatic translation of the spell

🔵 GSE.lua file:

GSE.lua.txt

🔵 Desktop (please complete the following information):

Windows 10 64bit]
retail (9.1.0)

🔵 GSE Version:

Version: 3.0.48
Downloaded From: [e.g. https://www.curseforge.com]

THANKS
Stay healthy.

TimothyLuke · Answer 1 · 2021-09-22T21:26:21.000Z

This unfortunately isn’t a bug. As mentioned in #998 not all variables are straight text like you have entered. Most are functions that comprise of Lua programming code that look like

function()
If SomeApiValue == true then
return valuea
else
return valueb
end
end

Attempting to translate this is currently not possible and would cause horrendous damage. As a result Variables are not translated. From the example “valuea” could be a spellID or it could be a true or false or it could be a cast line.

Macros have a limitation imposed by WoW in that they only work in the native client language.

Gyffes · Answer 2 · 2021-09-23T05:48:12.000Z

hi and thanks for the quick reply. that means you should work with the spellID instead of the spellName. To make it easier to work in different languages? Stay healthy.

TimothyLuke · Answer 3 · 2021-09-23T06:03:53.000Z

Which is what GSE does in everywhere except in Variables as the content cannot always be determined to be a series of macro commands. It just can’t be don’t inside a variable. TimothyLuke

…

On 23 Sep 2021, at 3:18 pm, Gyffes ***@***.***> wrote: hi and thanks for the quick reply. that means you should work with the spellID instead of the spellName. To make it easier to work in different languages? Stay healthy. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

Gyffes · Answer 4 · 2021-09-23T06:09:51.000Z

ok sorry then i expressed myself wrong. Is it better to work with the id in the variable area? Thank you very much.

TimothyLuke · Answer 5 · 2021-09-23T06:33:28.000Z

Not really. Once you’ve translated to your language once it’s not going to be an issue again after that. TimothyLuke

…

On 23 Sep 2021, at 3:40 pm, Gyffes ***@***.***> wrote: ok sorry then i expressed myself wrong. Is it better to work with the id in the variable area? Thank you very much. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

Gyffes · Answer 6 · 2021-09-23T06:54:01.000Z

That's correct. But as soon as I share the macro and another game language is used. Must he adjust it again in the variable area. I would not work around this by entering the spellID. Sorry for my stupid and bad english.

;)

TimothyLuke · Answer 7 · 2021-09-23T07:00:38.000Z

But by using the spell of it may or may not work. I can’t guarantee it will work and they may have to adjust anyway. What you can do is put the English lines in with two -‘s in front. This makes a comment which is tripped from the macro but can be used to explain to another reader what they need to do. Eg — when using this macro on an English client uncomment the English and comment the French by moving the —‘s on the following lines /cast spell1infrench — /cast spell1inenglish TimothyLuke

…

On 23 Sep 2021, at 4:24 pm, Gyffes ***@***.***> wrote: That's correct. But as soon as I share the macro and another game language is used. Must he adjust it again in the variable area. I would not work around this by entering the spellID. Sorry for my stupid and bad english. ;) — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

Gyffes · Answer 8 · 2021-09-23T07:13:25.000Z

Ah ok. I understand. Thank you very much. I wish you a nice day. Thanks for your great addon. stay healthy.

Share to