[BUG]
amon7777 opened this issue · 3 comments
🔵 Describe the bug:
Each GSE template stores the underlying ID not the spell name...but when it is inside a variable, this seems not ..I use the german version of the game...all is right above the different language but not the content of the variables ( often keypress, key release..)
the content of variables are stored in the origin language, not the ID code of the spells
As a variable can contain programming code as well as simple commands this isn’t a bug but a design limitation. Unfortunately to have the functionality that programmable variables give thee has to be a trade off.
but , cant you scan the variables for Spells , and when these appear, all
in around other text, you could drop the IDs instead of plain text. to edit
the variables in other languages seems neccesary, but when all spells are
transmitted in IDs this would help much
Am So., 5. März 2023 um 10:37 Uhr schrieb Timothy Minahan <
***@***.***>:
… Closed #1307
<#1307>
as completed.
—
Reply to this email directly, view it on GitHub
<#1307 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5E3DM2RBFEYCRLKQ6OO7WDW2RND5ANCNFSM6AAAAAAVQBXSUE>
.
You are receiving this because you authored the thread.Message ID:
<TimothyLuke/GSE-Advanced-Macro-Compiler/issue/1307/issue_event/8667624862
@github.com>
Not reliably.
Consider this kind of variable
function()
If known == ‘Ashen Hallow’ then
return true
else
return false
End
End
WoW contains a list of 200000 spells and no way of identifying which spells
players could learn only the spells that a player has learnt.
Do I search for all 200000 spells in the spell book against every line? To
do this will take about 7 -10 minutes to process and that will occur every
time you exit combat, zone or login.
What about where Russian adds in ‘ characters into some names which break
the “‘s and translating this kind of a variable breaks the mod entirely.
It is one of those things that I have looked at extensively but it’s not
something that can be black and white accomplished without serious
drawbacks.
For simple macros and the average WLm user what you are proposing would be
fine. Unfortunately GSE is also developed for people who have
significantly more complex requirements and it would break their stuff to
do.
On Sun, 5 Mar 2023 at 8:30 pm, amon7777 ***@***.***> wrote:
but , cant you scan the variables for Spells , and when these appear, all
in around other text, you could drop the IDs instead of plain text. to edit
the variables in other languages seems neccesary, but when all spells are
transmitted in IDs this would help much
Am So., 5. März 2023 um 10:37 Uhr schrieb Timothy Minahan <
***@***.***>:
> Closed #1307
> <#1307>
> as completed.
>
> —
> Reply to this email directly, view it on GitHub
> <
#1307 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/A5E3DM2RBFEYCRLKQ6OO7WDW2RND5ANCNFSM6AAAAAAVQBXSUE
>
> .
> You are receiving this because you authored the thread.Message ID:
>
<TimothyLuke/GSE-Advanced-Macro-Compiler/issue/1307/issue_event/8667624862
> @github.com>
>
—
Reply to this email directly, view it on GitHub
<#1307 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEMCFLV3RYHWMNL5KLQGQTW2RP5RANCNFSM6AAAAAAVQBXSUE>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***
.com>
--
*Timothy Minahan**M* 0406 413 680 | *E ***@***.***