[BUG] Disappearing ! prefix

Question

[BUG] Disappearing ! prefix

jamtur01 opened this issue 2 years ago · 5 comments

jamtur01 commented 2 years ago

🔵 Describe the bug:

GSE is not saving actions prefixed with !

So:

/castsequence !Auto Shot

Becomes

/castsequence Auto Shot

When I click the save button.

Is there some kind of parser that might be stripping out the !? I'll take a look but Lua isn't one of my regular languages.

🔵 To reproduce: (Steps to reproduce the behavior)

Enter macro line with the ! prefix, click save, ! disappears.

🔵 Screenshots:

Screen.Recording.2023-05-11.at.6.58.36.PM.mov

🔵 Expected behavior:

I expect the ! to be saved.

🔵 GSE.lua file:

GSE.lua.txt

🔵 Desktop (please complete the following information):

OS: MacOS Ventura on an M1 Max
Game Version [e.g. classic/bcc/retail (9.1.0)]

🔵 GSE Version:

Version: 3.1.33 downloaded from Curseforge.

TimothyLuke · Answer 1 · 2023-05-12T00:09:22.000Z

Hi James,This works for me on Dragonflight and Wrath Classic. Do you have more information on how I can replicate this?TimothyLukeOn 12 May 2023, at 9:10 am, James Turnbull ***@***.***> wrote: 🔵 Describe the bug: GSE is not saving actions prefixed with ! So: /castsequence !Auto Shot Becomes /castsequence Auto Shot When I click the save button. Is there some kind of parser that might be stripping out the !? I'll take a look but Lua isn't one of my regular languages. 🔵 To reproduce: (Steps to reproduce the behavior) Enter macro line with the ! prefix, click save, ! disappears. 🔵 Screenshots: https://github.com/TimothyLuke/GSE-Advanced-Macro-Compiler/assets/4365/5f965b62-ccdd-4f5d-b321-f8e171ef6637 🔵 Expected behavior: I expect the ! to be saved. 🔵 GSE.lua file: 🔵 Desktop (please complete the following information): OS: MacOS Ventura on an M1 Max Game Version [e.g. classic/bcc/retail (9.1.0)] 🔵 GSE Version: Version: 3.1.33 downloaded from Curseforge. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

jamtur01 · Answer 2 · 2023-05-12T00:10:50.000Z

I'm not sure - can I provide any logs/anything else that'd help. Also let me sign into WolTK and see if it occurs there.

jamtur01 · Answer 3 · 2023-05-12T00:18:43.000Z

Okay. I have an oddity.

This works:

/castsequence !Auto Shot, null

But this does not (i.e. the ! gets removed)

/castsequence [combat] !Auto Shot, null

Does that help at all?

TimothyLuke · Answer 4 · 2023-05-12T04:27:57.000Z

That is extremely useful and gives me something to work with.TimothyLukeOn 12 May 2023, at 9:48 am, James Turnbull ***@***.***> wrote: Okay. I have an oddity. This works: /castsequence !Auto Shot, null But this does not /castsequence [combat] !Auto Shot, null Does that help at all? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>

TimothyLuke · Answer 5 · 2023-05-14T23:35:32.000Z

Found it and fixed it.

You can verify this post the update from the following commands.

/run print(GSE.TranslateString("/castsequence !Auto Shot, null", "STRING", false, false))
/run print(GSE.TranslateString("/castsequence [combat] !Auto Shot, null", "STRING", false, false))
/run print(GSE.TranslateString("/castsequence [combat] !Auto Shot, null", "STRING", true, false))

Share to