[ENH] Rebind Original Vehicle and Mount Keybindings when entering a vehicle or using a mount
TimothyLuke opened this issue · 2 comments
🟢 How does GSE currently work
TWW’s GSE changes require that you keybind a GSE sequence. This has the consequence that when you get into a vehicle you may have unbound the vehicle controls. Store the original keybind and put it back in case it is needed.
there is an event for vehicles need to figure out what is needed for Skyriding.
https://warcraft.wiki.gg/wiki/UNIT_ENTERING_VEHICLE
coupled with some of the functions used in https://github.com/BigWigsMods/WoWUI/blob/live/AddOns/Blizzard_ActionBarController/Mainline/ActionBarController.lua#L135
Looks like watching https://warcraft.wiki.gg/wiki/UPDATE_BONUS_ACTIONBAR with this code might be the trick
the skyriding widget itself is (in DF at least) a bit janky but there's PLAYER_IS_GLIDING_CHANGED
for actual flight and PLAYER_CAN_GLIDE_CHANGED
for being on a skyriding mount
basically if HasBonusActionBar() and GetActionBarPage() == 1 and GetBonusBarIndex() == 11 then
The risk with skyriding is that if combat starts I can rebind the sequence
IsFlying() and IsAdvancedFlyableArea()
would also suffice
have the button itself SetOverrideBindingClick()