[ENH] Add Actionbar Overrides to LibActionButton based mods (ElvUI, ConsolePort and Bartender)

Question

[ENH] Add Actionbar Overrides to LibActionButton based mods (ElvUI, ConsolePort and Bartender)

TimothyLuke opened this issue 2 months ago · 17 comments

TimothyLuke commented 2 months ago

🟢 How does GSE currently work
GSE was able to override the WoW default Actionbars to emulate the ability to have a macro on the taskbar. A number of mods use LibActionButton to replace the actionbars. The aim is to be able to bring the override functionality to ElvUI, ConsolePort and Bartender.

General LibActionButton Parts
ConsolePort
ElvUI
Bartender

TimothyLuke · Answer 1 · 2024-09-14T07:43:58.000Z

I have added a note to that effect onto the Wiki and asked for more information from both ElvUI and LibActionButton

TimothyLuke · Answer 2 · 2024-09-13T23:51:46.000Z

For ElvUI:
Using a sequence called KEPH_ST and the 2nd action button which in ElvUI is ElvUI_Bar1Button2

/run ElvUI_Bar1Button2.SetState(ElvUI_Bar1Button2, "1", "custom", {func = function (self) self:SetAttribute("type", "click") ; self:SetAttribute("clickbutton", _G["KEPH-ST"]); end })

TimothyLuke · Answer 3 · 2024-09-14T00:38:06.000Z

Actionbar Override working with ElvUI.
https://github.com/user-attachments/assets/fe885f67-b99a-4e77-9fdc-44960789b407

TimothyLuke · Answer 4 · 2024-09-14T01:53:05.000Z

ConsolePort Example
https://github.com/user-attachments/assets/ce8f9e46-2958-4158-b939-c7d6ed68e9bb

TimothyLuke · Answer 5 · 2024-09-14T02:18:17.000Z

I just thought I would let you know that sometimes when swapping from mout to combat (or from mining to combat) the button override appears to "stop" Nothing will happen even when manually clicking on the button. Using Elvui override

I need a lot more info unfortunately on how to reproduce this. I wonder if its a bar timing/lag thing? The tests i am doing don't seem to make that happen.

Elfyau · Answer 6 · 2024-09-14T02:15:27.000Z

I just thought I would let you know that sometimes when swapping from mout to combat (or from mining to combat) the button override appears to "stop" Nothing will happen even when manually clicking on the button. Using Elvui override

TimothyLuke · Answer 7 · 2024-09-14T02:21:01.000Z

i did notice that if you logged in on a mount - it bound the GSE sequence to the skyriding bar instead of the normal bar.

Elfyau · Answer 8 · 2024-09-14T02:42:50.000Z

All I can say is even with static flying when dismounting in combat the override just doesn't appear to work. You can see it being pressed or even click on it but it does nothing. The only way I know of is to try and get into combat when mounted and then dismount and try spamming the button

Elfyau · Answer 9 · 2024-09-14T02:45:37.000Z

This happened with 13-a-1 and 13-a-2 also happens with 13-a-4 and doesn't seem to matter wether it is Static flying or Dynamic

Elfyau · Answer 10 · 2024-09-14T03:12:35.000Z

Sorry if the information is a bit basic - Let me know what you need and I will send it over - Basic gist is if you are mounted when combat starts the override doesn't seem to work

Elfyau · Answer 11 · 2024-09-14T03:46:57.000Z

No just the basic Elvui and something called project Azilroka

TimothyLuke · Answer 12 · 2024-09-14T03:37:42.000Z

I still cant make this happen. Do you have anything that modifies Elv further like Shadow and Light or Windtools?

TimothyLuke · Answer 13 · 2024-09-14T04:14:53.000Z

Found the issue - its a limitation with using Custom types with LibActionButton. Its not something I can code around - it simply is.

Issue is that once you enter combat LibActionButton cant convert the button to 'click' as SetAttribute is no longer available from insecure places. It taints the actionbar rendering it useless. I can however prevent the taint and then when you leave combat the actionbar will reset to normal.

1x [ADDON_ACTION_BLOCKED] AddOn '*** TaintForced ***' tried to call the protected function 'ElvUI_Bar1Button2:SetAttribute()'.
[string "@!BugGrabber/BugGrabber.lua"]:485: in function <!BugGrabber/BugGrabber.lua:485>
[string "=[C]"]: in function `SetAttribute'
[string "@GSE/API/Events.lua"]:117: in function <GSE/API/Events.lua:116>
[string "=(tail call)"]: ?
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:667: in function <...ddOns/Blizzard_FrameXML/Mainline/SecureTemplates.lua:649>
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:681: in function <...ddOns/Blizzard_FrameXML/Mainline/SecureTemplates.lua:674>
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:723: in function <...ddOns/Blizzard_FrameXML/Mainline/SecureTemplates.lua:707>
[string "=[C]"]: ?
[string "@Blizzard_FrameXML/SecureHandlers.lua"]:266: in function <Blizzard_FrameXML/SecureHandlers.lua:263>
[string "=[C]"]: ?
[string "@Blizzard_FrameXML/SecureHandlers.lua"]:296: in function <Blizzard_FrameXML/SecureHandlers.lua:279>
[string "=(tail call)"]: ?

Locals:
_ = Frame {
}
event = "ADDON_ACTION_BLOCKED"
events = <table> {
}

Elfyau · Answer 14 · 2024-09-14T04:38:47.000Z

it is all good I know you cannot change what Blizz does - just thought I would let you know as it has gotten me killed a couple of time lol

TimothyLuke · Answer 15 · 2024-09-15T06:05:11.000Z

Tracking this issue separately on the other thread.

Macroholic951 · Answer 16 · 2024-09-15T00:36:50.000Z

Found the issue - its a limitation with using Custom types with LibActionButton. Its not something I can code around - it simply is.

Issue is that once you enter combat LibActionButton cant convert the button to 'click' as SetAttribute is no longer available from insecure places. It taints the actionbar rendering it useless. I can however prevent the taint and then when you leave combat the actionbar will reset to normal.

1x [ADDON_ACTION_BLOCKED] AddOn '*** TaintForced ***' tried to call the protected function 'ElvUI_Bar1Button2:SetAttribute()'.
[string "@!BugGrabber/BugGrabber.lua"]:485: in function <!BugGrabber/BugGrabber.lua:485>
[string "=[C]"]: in function `SetAttribute'
[string "@GSE/API/Events.lua"]:117: in function <GSE/API/Events.lua:116>
[string "=(tail call)"]: ?
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:667: in function <...ddOns/Blizzard_FrameXML/Mainline/SecureTemplates.lua:649>
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:681: in function <...ddOns/Blizzard_FrameXML/Mainline/SecureTemplates.lua:674>
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:723: in function <...ddOns/Blizzard_FrameXML/Mainline/SecureTemplates.lua:707>
[string "=[C]"]: ?
[string "@Blizzard_FrameXML/SecureHandlers.lua"]:266: in function <Blizzard_FrameXML/SecureHandlers.lua:263>
[string "=[C]"]: ?
[string "@Blizzard_FrameXML/SecureHandlers.lua"]:296: in function <Blizzard_FrameXML/SecureHandlers.lua:279>
[string "=(tail call)"]: ?

Locals:
_ = Frame {
}
event = "ADDON_ACTION_BLOCKED"
events = <table> {
}

Is this the same reason why on last boss of Dawnbreaker when you use a dragonriding mount it doesn't bring back the macro when you land?

Possible work around would be using a regular mount.

Not sure if this will also affect dominos or just elvui/bartender/consoleport.

TimothyLuke · Answer 17 · 2024-09-15T01:15:21.000Z

Won’t affect Domino’s yet as I havn’t worked on that yet. I was afraid that would be the case with Dawnbreaker but hadn’t gotten to test there yet. I don’t use either of these mods so writing and developing on Beta.

I have a test case that I am working through - just trying to find the magic code set to fix this.

Share to