GSE: Sequences, Variables, Macros

GSE: Sequences, Variables, Macros

7M Downloads

[ENH] Allow re-ordering version tabs

nerf10 opened this issue · 7 comments

commented

🟢 How does GSE currently work
A clear and concise description of what currently happens. Eg. Every time you go to do x you need to perform the following [...]

A sequence can have multiple version tabs, however they cannot be moved/re-ordered

🟢 Describe the solution you'd like
A clear and concise description of what you want to happen instead of what currently occurs.

I would like to request the functionality to be able to re-order the version tabs OR insert a new version after/before a selected version tab

🟢 Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Currently, i create a new version (is created at the end/right side) and then copy each command and paste on the version tab to the right. This leaves me with a copy of all original versions plus a new version tab on the left/first. I use this version for my modifications of the original.
Back in the day, i used to show raw edit and copy then paste in new version however now, it doesn't work. Due to multiline actions, i would need to replace lines with square brackets and even then there's funky squares, so i'm not keen on using this method.

🟢 Additional context
Add any other context or screenshots about the feature request here.

I like keeping the original version(s) but i also like to modify the sequence to my common mods or minor tweaks. My OCD needs my tab/version to be on tab #1, which requires shifting the original tabs to the right.

Is this something that falls within your vision of the MOD?

commented

It is. Reasonable request to be sure.

I am not sure yet how to achieve this. The Tab container is from AceGUI’s custom widgets. They currently don’t have an allowance to reorder the tabs via dragging. It doesn’t mean it hasn’t been done it just means I may need to figure out the how.

It might be possible to right click a tab and select to move it left or right. If they had to move one at a time rather than a drag would that be acceptable?

commented

Hi TimothyLuke,
That would be AMAZING :)

currently, copy/paste blocks into a new macro to shift them to the right introduces the opportunity for me to make mistakes. Your proposal to right-click and move right/left leaves the entire version intact and eliminates human error.

(thank you so much for all the effort you put into this addon, i would not play wow without it)

commented

What you can do in the interim is click the 1 then click New. This will copy 1 to 3. Change the config with default as 2 and then delete 1. Then 2 will be 1 and your original version will be 2.

commented

well, you just taught me something new. i was aware that NEW copied my version 1 to a new version on the right, however i did not know that it actually copies the Default Version specified in the Configuration tab!
thank you for that. now i can change the default to manipulate which version i want to copy, as you suggested :)

commented

It copies the one you are looking at at the time. You just can’t delete the one that is the default

commented

perhaps i'm misunderstanding or maybe the behavior has changed or maybe i need to delete GSE.lua to confirm?
either way, don't waste your time with this, i can make it do what i need.

If i recall correctly, in the past, it used to copy the version that I was looking at (as you mention) but that behavior changed for me a while ago (don't recall if it was with 3.2 or before).

  1. i created a new simple sequence with 3 versions (tabs 1, 2, 3)
  2. each version has a single macro command (a number 1-3 matching the version tab name)
  3. version 1 is the default in the configuration tab

no matter which version i'm looking at (has focus) when i click NEW, it always creates the new version at the end (right) as expected but the sequence is a copy of the version that is set at the Default in the Configuration tab (in this case, version 1).

i confirmed this by repeating the process several times.

then, I changed the default version and rested. when i change the Default in the Configuration tab to another version 2 or 3, that version is then copied by the NEW button.

Hope that i'm not annoying you.

commented

Was not expecting that. Interesting.