GSE: Sequences, Variables, Macros

GSE: Sequences, Variables, Macros

6M Downloads

After Import Macro is not able to fire until a reloadui has occured,

Palonblade opened this issue · 25 comments

commented

I updated and everything seemed to be working fine. I wanted to add a macro so out of habit I modified my Legacy GSE 1 hunter macro to add another macro figuring I could import it. When in game I loaded GSE and went to options, plugins where there is a import button for Legacy GSE 1. When hovering over the button I can see the new macro I added but when I clicked on the button absolutely nothing happened. No lua errors, no import messages. I could see all my old hunter macros and the new one when hovering but again nothing happens when I click the button. As a test I deleted one of my hunter macros and tried to import again. This one would not come back either. The samples button seems to work but not the Legacy GSE 1 button.

commented
commented

It is not in Global when I chose show all so I can't edit it, I also don't see any chat messages indicating things were imported, they do show when importing the samples.

BTW this is a great addon and I can't thank you enough for your commitment and time.

commented
commented

Also there is a 2.0.3 update on Curse which may solve some of your challenges.

commented

Just updated and tried again, same results, nothing happens when I click the Legacy GSE 1 button. It also doesn't import manually any more (copy/paste into other import screen). LUA error below. I also disabled all addons except for my macros, GSE and GSE Legacy Adapter. Also the sort doesn't seems to work correctly when I choose to load all.

local Sequences = GSMasterSequences


----- Hunter

-- Marksmanship - 254

Sequences['HunterMMLWAoE'] = {
author='Dana',
specID= 254,
helpTxt = 'Talents: 1113313',
StepFunction = GSStaticPriority,
PreMacro=[[
/cast [target=focus, exists, nodead],[target=pet, exists, nodead] Misdirection
/cast [combat] Trueshot
]],
'/cast [nochanneling, talent:6/1] A Murder of Crows; [nochanneling, talent:6/2] Barrage; [nochanneling, talent:6/3] Volley',
'/cast [nochanneling, talent:7/1] Sidewinders; [nochanneling, talent:7/2] Piercing Shot',
'/cast [nochanneling] Marked Shot',
'/cast [nochanneling] Windburst',
'/cast [nochanneling] Aimed Shot',
'/cast [nochanneling] Marked Shot',
'/cast [nochanneling] Multi Shot',
PostMacro=[[
]],
}

Message: Interface\AddOns\GSE\API\CharacterFunctions.lua:26: Usage: GetSpecializationInfoByID(specID[, sex])
Time: 01/12/17 03:59:28
Count: 1
Stack: [C]: in function GetSpecializationInfoByID' Interface\AddOns\GSE\API\CharacterFunctions.lua:26: in function GetClassIDforSpec'
Interface\AddOns\GSE\API\Storage.lua:77: in function OOCAddSequenceToCollection' Interface\AddOns\GSE\API\Events.lua:225: in function ?'
...terface\AddOns\GSE\Lib\AceTimer-3.0\AceTimer-3.0.lua:53: in function <...terface\AddOns\GSE\Lib\AceTimer-3.0\AceTimer-3.0.lua:48>

Locals: (*temporary) = nil

commented
commented

The Plugin button still does nothing and the sort doesn't work correctly when I choose to load all. The manual import worked.

commented

Its actually sorts Class/Macroname Ive added a label in #185 to make this more obvious.

The plugin button will put those macros back into Global Macros. I am working on the underlying problem #187 and #188

commented

When I hit the button nothing happens, the macros do no show when I choose show all, close and reopen.

commented

I have found a fix for this in 2.0.5

commented

When I hit the button nothing happens, the macros do no show when I choose show all, close and reopen still after latest update

commented

no the radio button was removed - it will auto figure out what type it is. see #216

You can also import multiple macros at the same time.

commented

I was referring to the Options, Plugins, Legacy GSE 1 button. I don't see it anymore since removing the GS-Core.lua files and the GSE.lua files and letting them recreate. My GS-E: Dana's Bundled Macros is loaded but no button.

commented

Is the GSE2 Legacy Adaptor enabled in your mod list?

commented

Yes. I just see the GS-HighPerformance and Samples button.

gse1
gse2

commented

Then Im not sure. GS-myMacros hasn't had any support since September.

commented

Any suggestions? When I hover over the button I can see the macro I want to import. It's from my personal collection that I have setup to load as an addon. Again though, when I click the button nothing happens.

commented
commented

Here's the macro and the toc file (I had to add a ' infront of the ## to get the toc to post better in this reply):

local Sequences = GSMasterSequences

Sequences['BMTest'] = {
specID=253,
author="Dana",
helpTxt = "Talents: 3112112",
StepFunction = GSStaticPriority,
icon='INV_MISC_QUESTIONMARK',
lang="enUS",
PreMacro=[[
/cast [target=focus, exists, nodead],[target=pet, exists, nodead] Misdirection
/cast [@pet,dead]Revive Pet
/cast [combat] Bestial Wrath
/cast [combat] Intimidation
/cast [combat] Aspect of the Wild
/cast [combat] Titan’s Thunder
/cast [nopet,nodead] Call Pet 1; [@pet,dead] Heart of the Phoenix
/cast [combat,pet:Spirit Beast,@player] Spirit Mend
/cast [combat,pet,@player] Roar of Sacrifice
/cast [mod] Multi-Shot
]],
"/cast Dire Beast",
"/cast Kill Command",
"/cast [talent:6/1] A Murder of Crows; [talent:6/2] Barrage",
PostMacro=[[
/cast [nogroup] Mend Pet
]],
}

'## Interface: 70000
'## Title: |cffff0000GS-E:|r Dana's Bundled Macros
'## Notes: A good starting point.
'## Author: Dana
' ## Version: v0.7 - Legion Beta
'## RequiredDeps: GS-Core
'## LoadOnDemand: 1

Macros\HunterD1.lua

I also tried this and still nothing happens when I click the import button:

Sequences['BMTest'] = {
specID=253,
author="Dana",
helpTxt = "Talents: 3112112",
StepFunction = GSStaticPriority,
icon='INV_MISC_QUESTIONMARK',
lang="enUS",
PreMacro=[[
]],
'/cast Kill Command',
PostMacro=[[
]],
}

I also tried removing the GS files from saved variables. When I did this I no longer even see the button for Legacy Macros, just the samples button. I also didn't see the High Performance button until I unloaded and loaded them.

commented
commented

Has the Legacy import button been removed? If so will I have to manually import all my macros for all classes and specs? When I initially upgraded they came in but are gone now since I removed the gs files in savedvariables.

commented
commented

GS-myMacros and/or Legacy GSE 1 macros button are shown in your video for 2.0. The missing button is missing from the GSE 2.0 addon.

commented

Before I posted about this I had removed all my class macros from my Legacy files except for my hunter to make it easier to troubleshoot. I just uninstalled all the GSE stuff, removed all GS saved variable files and reduced my legacy hunter macro to what's below which should not have any errors. I reinstalled and loaded samples when prompted so a fresh install. I still only see the Samples button when going to Options...Plugin. I also don't see the high end button but I assume that's expected since I uninstalled them. The only 3 addons I have loaded are GSE, GSE Legacy Adapter and my macros. I've also tried to unload and reload my macros addon multiple times.

local Sequences = GSMasterSequences

Sequences['BMTest'] = {
specID=253,
author="Dana",
helpTxt = "Talents: 3112112",
StepFunction = GSStaticPriority,
icon='INV_MISC_QUESTIONMARK',
lang="enUS",
PreMacro=[[
]],
"/cast Dire Beast",
PostMacro=[[
]],
}

commented