[ENH]The addon adds unnecessary spaces when it creates its macros.
Closed this issue · 4 comments
🟢 How does GSE currently work
For example, it turns this macro of 245 characters into one of 257 characters (which is over the limit).
🟢 Describe the solution you'd like
I would like it to stop adding unnecessary spaces that eat up precious characters. It doesn't need a space between the conditions and the next bit (especially not TWO when there's a reset parameter in a cast sequence) and it doesn't need a space between spells in a cast sequence.
🟢 Describe alternatives you've considered
The alternative is to have GSE reference a Blizzard macro I guess? It's how I had it set up until now since that's what we had to do at the start of the expansion and I had kept it that way. I think that's the only real alternative to the example presented here, which is the first time it has actually been a problem for me despite knowing the addon does this the entire time I've used it.
🟢 Additional context
If you want the above macro in a copy-able format:
/use [nochanneling,mod][channeling:Drain Life,mod][channeling:Drain Soul,mod]Malefic rapture
/castsequence [nochanneling,known:387016]reset=4 Shadow Bolt,Malefic Rapture
/castsequence [nochanneling]reset=4 Shadow Bolt,Shadow Bolt,Malefic Rapture
This is a consequence of the ability to translate between languages fixing this removes that capability so won’t be changed.
The workaround is to put this action into a normal macro and call that from GSE.
btw - reset=4 is ignored when used with GSE so that will save you another 14 chars out of your action. (Any attempted spell cast anywhere in the sequence will prevent the reset.)
Yeah I know but there are occasions where there's downtime without leaving combat where I'm actually not pressing the macro and I want the sequence to reset. I assume it still properly resets in those situations.