Step Function generation is selecting LoopPriority instead of Priority when not an internal loop macro.
Trevornash0 opened this issue · 12 comments
Below is my sequence of spells in priority of highest DPS to lowest DPS. GSE handles everything perfectly untill it hits my last spell. Once it gets to Furious Slash it will cast it multiple times, even though there are higher priority spells not on cooldown, the number of times it casts varies, but it is effecting my DPS tremendously and i need help. I only want Furious Slash to cast when the prior spells cannot be cast due to cooldown or no fury.
Sequences[‘FuryST’] = {
— This Sequence was exported from GSE 2.0.14.
Author=”Chickadang@Kargath”,
SpecID=72,
Talents = “1234567”,
Default=1,
MacroVersions = {
[1] = {
StepFunction = “Priority”,
KeyPress={
},
PreMacro={
},
“/cast Charge”,
“/cast Execute”,
“/cast Bloodthirst”,
“/cast Odyn’s Fury”,
“/cast Raging Blow”,
“/cast Rampage”,
“/cast Furious Slash”,
PostMacro={
},
KeyRelease={
},
},
},
}
I just updated the addon to the newest version through curse and i still have the same issue with Furious Slash. In fact now the prior spells are not casting in the correct order since i updated, they almost seem random.
https://drive.google.com/file/d/0Byezqx0OOdtrNkEtekNFZkZ1dlU/view?usp=sharing
^ Here is a screenshot of recount after using the macro on a target dummy, if your not familiar with warrior rotation i will explain why this recount looks wrong. Generally speaking Raging Blow will be twice as many hits as Bloodthirst, and Bloodthirst and Furious Slash should be about a equal number of hits. So a general example would be:
Raging Blow – 200 hits
Bloodthirst – 100 hits
Furious Slash – 100 hits
The fact that Furious Slash is hitting more often than either Raging Blow or Bloodthirst is very odd. Some more info is that i use a Razer Naga mouse, and it is set to press the macro ever 0.050 sec (which is the default key press) so i don’t think there are any issues there. But i have tried different settings with no improvement, 0.050 seems to always be the best setting.
I have the same issue with skipping over abilities and sometimes getting caught using the same ability over and over again
I am also having this problem. I ran /gs debug and it reports that spells are ready that are still on CD. It reports that EVERYTHING is ready and sometimes doesn't even cast the only thing that actually IS ready! The debug doesn't seem to be able to be copy/pasted here!
Sequences['Ele_1'] = {
-- This Sequence was exported from GSE 2.1.01.
Author="Jules",
SpecID=262,
Talents = "1,1,1,2,3,3,3",
Default=1,
MacroVersions = {
[1] = {
Trinket1=false,
Trinket2=false,
Head=false,
Neck=false,
Belt=false,
Ring1=false,
Ring2=false,
StepFunction = "Priority",
KeyPress={
"/targetenemy [noharm][dead]",
},
PreMacro={
},
"/cast [nochanneling] Elemental Blast",
"/cast [nochanneling] Lava Burst",
"/cast [nochanneling] Stormkeeper",
"/cast [nochanneling] Lightning Bolt",
PostMacro={
},
KeyRelease={
},
},
},
}
Sequences['Ele_1'] = {
-- This Sequence was exported from GSE 2.1.01.
Author="Jules",
SpecID=262,
Talents = "1,1,1,2,3,3,3",
Default=1,
MacroVersions = {
[1] = {
Trinket1=false,
Trinket2=false,
Head=false,
Neck=false,
Belt=false,
Ring1=false,
Ring2=false,
StepFunction = "Priority",
KeyPress={
"/targetenemy [noharm][dead]",
},
PreMacro={
},
"/cast [nochanneling] Elemental Blast",
"/cast [nochanneling] Lava Burst",
"/cast [nochanneling] Stormkeeper",
"/cast [nochanneling] Lightning Bolt",
PostMacro={
},
KeyRelease={
},
},
},
}
I have been looking into this and have found a problem with The Loop version of Priority but cant find a problem with the normal version.
@Juulz can you please run the following command:
print (GSE.IsLoopSequence(GSELibrary[7]['Ele_1'].MacroVersions[1]))
@Trevornash0 can you please run the alternative command:
print (GSE.IsLoopSequence(GSELibrary[1]['FuryST'].MacroVersions[1]))
This will print either a true or a false value. Could you please comment which one its returning?
In the interim I have a code change which I will include as part of the 2.1.02 release
/run print (GSE.IsLoopSequence(GSELibrary[7]['Ele_1'].MacroVersions[1])) = true
After the update, debug still reporting spells on CD as available.
Thanks @Juulz
What that shows is that the underlying problem is that it is selecting the wrong version of Priority's step function. That check should have been returning false as your macro did not have a PreMacro or a PostMacro and a LoopLimit. 2.1.02 will be improved in that the loop priority version of the step function was updated to cycle correctly if it was chosen incorrectly however I will have a proper in 2.1.03.