Taint issues I noticed wint GSE while checking on taint for another addon

Question

Taint issues I noticed wint GSE while checking on taint for another addon

Thrumbar opened this issue 7 years ago · 2 comments

Thrumbar commented 7 years ago

Been getting a lot of taint as follows and ask if you could check into changing line 602 of the Storage.lua to localize it as it does not change any way the addon functions that I can tell but stops the taint.

602 retvalue = ""
to
602 local retvalue = ""

8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.467 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 8/29 17:50:52.473 Global variable retvalue tainted by GSE - Interface\AddOns\GSE\API\Storage.lua:602 PrepareStepFunction()
Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation()
Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence()
Interface\AddOns\GSE\API\Events.lua:310 ?()
Interface\AddOns\Ailo\Libs\AceTimer-3.0\AceTimer-3.0.lua:53
Global variable retvalue tainted by Ailo - Interface\AddOns\GSE\API\Storage.lua:613 PrepareStepFunction()
Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation()
Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence()
Interface\AddOns\GSE\API\Events.lua:310 ?()
Interface\AddOns\Ailo\Libs\AceTimer-3.0\AceTimer-3.0.lua:53
Global variable retvalue tainted by GSE - Interface\AddOns\GSE\API\Storage.lua:602 PrepareStepFunction()
Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation()
Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence()
Interface\AddOns\GSE\API\Events.lua:310 ?()
Interface\AddOns\Ailo\Libs\AceTimer-3.0\AceTimer-3.0.lua:53
Global variable retvalue tainted by Ailo - Interface\AddOns\GSE\API\Storage.lua:605 PrepareStepFunction()
Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation()
Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence()
Interface\AddOns\GSE\API\Events.lua:310 ?()
Interface\AddOns\Ailo\Libs\AceTimer-3.0\AceTimer-3.0.lua:53
Global variable retvalue tainted by GSE - Interface\AddOns\GSE\API\Storage.lua:602 PrepareStepFunction()
Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation()
Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence()
Interface\AddOns\GSE\API\Events.lua:310 ?()
Interface\AddOns\Ailo\Libs\AceTimer-3.0\AceTimer-3.0.lua:53
Global variable retvalue tainted by Ailo - Interface\AddOns\GSE\API\Storage.lua:605 PrepareStepFunction()
Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation()
Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence()
Interface\AddOns\GSE\API\Events.lua:310 ?()
Interface\AddOns\Ailo\Libs\AceTimer-3.0\AceTimer-3.0.lua:53
Global variable retvalue tainted by GSE - Interface\AddOns\GSE\API\Storage.lua:602 PrepareStepFunction()
Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation()
Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence()
Interface\AddOns\GSE\API\Events.lua:310 ?()
Interface\AddOns\Ailo\Libs\AceTimer-3.0\AceTimer-3.0.lua:53
Global variable retvalue tainted by Ailo - Interface\AddOns\GSE\API\Storage.lua:613 PrepareStepFunction()
Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation()
Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence()
Interface\AddOns\GSE\API\Events.lua:310 ?()
Interface\AddOns\Ailo\Libs\AceTimer-3.0\AceTimer-3.0.lua:53
Global variable retvalue tainted by GSE - Interface\AddOns\GSE\API\Storage.lua:602 PrepareStepFunction()
Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation()
Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence()
Interface\AddOns\GSE\API\Events.lua:310 ?()
Interface\AddOns\Ailo\Libs\AceTimer-3.0\AceTimer-3.0.lua:53
Global variable retvalue tainted by Ailo - Interface\AddOns\GSE\API\Storage.lua:613 PrepareStepFunction()
Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation()
Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence()
Interface\AddOns\GSE\API\Events.lua:310 ?()
Interface\AddOns\Ailo\Libs\AceTimer-3.0\AceTimer-3.0.lua:53
Global variable retvalue tainted by GSE - Interface\AddOns\GSE\API\Storage.lua:602 PrepareStepFunction()
Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation()
Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence()
Interface\AddOns\GSE\API\Events.lua:310 ?()
Interface\AddOns\Ailo\Libs\AceTimer-3.0\AceTimer-3.0.lua:53

Thrumbar commented 7 years ago

Anytime

TimothyLuke · Answer 1 · 2017-08-30T00:26:40.000Z

Thank you for that. Its actually solved a long troubling problem i have been tracing.

…

On Wed, Aug 30, 2017 at 8:26 AM, Thrumbar ***@***.***> wrote: Been getting a lot of taint as follows and ask if you could check into changing line 602 of the Storage.lua to localize it as it does not change any way the addon functions that I can tell but stops the taint. 602 retvalue = "" to 602 local retvalue = "" 8/29 17:50:52.467 Global variable retvalue tainted by GSE - Interface\AddOns\GSE\API\Storage.lua:602 PrepareStepFunction() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Events.lua:310 ?() 8/29 17:50:52.467 Interface\AddOns\Ailo\Libs\ AceTimer-3.0\AceTimer-3.0.lua:53 8/29 17:50:52.467 Global variable retvalue tainted by Ailo - Interface\AddOns\GSE\API\Storage.lua:613 PrepareStepFunction() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Events.lua:310 ?() 8/29 17:50:52.467 Interface\AddOns\Ailo\Libs\ AceTimer-3.0\AceTimer-3.0.lua:53 8/29 17:50:52.467 Global variable retvalue tainted by GSE - Interface\AddOns\GSE\API\Storage.lua:602 PrepareStepFunction() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Events.lua:310 ?() 8/29 17:50:52.467 Interface\AddOns\Ailo\Libs\ AceTimer-3.0\AceTimer-3.0.lua:53 8/29 17:50:52.467 Global variable retvalue tainted by Ailo - Interface\AddOns\GSE\API\Storage.lua:605 PrepareStepFunction() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Events.lua:310 ?() 8/29 17:50:52.467 Interface\AddOns\Ailo\Libs\ AceTimer-3.0\AceTimer-3.0.lua:53 8/29 17:50:52.467 Global variable retvalue tainted by GSE - Interface\AddOns\GSE\API\Storage.lua:602 PrepareStepFunction() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Events.lua:310 ?() 8/29 17:50:52.467 Interface\AddOns\Ailo\Libs\ AceTimer-3.0\AceTimer-3.0.lua:53 8/29 17:50:52.467 Global variable retvalue tainted by Ailo - Interface\AddOns\GSE\API\Storage.lua:605 PrepareStepFunction() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Events.lua:310 ?() 8/29 17:50:52.467 Interface\AddOns\Ailo\Libs\ AceTimer-3.0\AceTimer-3.0.lua:53 8/29 17:50:52.467 Global variable retvalue tainted by GSE - Interface\AddOns\GSE\API\Storage.lua:602 PrepareStepFunction() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation() 8/29 17:50:52.467 Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence() 8/29 17:50:52.473 Interface\AddOns\GSE\API\Events.lua:310 ?() 8/29 17:50:52.473 Interface\AddOns\Ailo\Libs\ AceTimer-3.0\AceTimer-3.0.lua:53 8/29 17:50:52.473 Global variable retvalue tainted by Ailo - Interface\AddOns\GSE\API\Storage.lua:613 PrepareStepFunction() 8/29 17:50:52.473 Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation() 8/29 17:50:52.473 Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence() 8/29 17:50:52.473 Interface\AddOns\GSE\API\Events.lua:310 ?() 8/29 17:50:52.473 Interface\AddOns\Ailo\Libs\ AceTimer-3.0\AceTimer-3.0.lua:53 8/29 17:50:52.473 Global variable retvalue tainted by GSE - Interface\AddOns\GSE\API\Storage.lua:602 PrepareStepFunction() 8/29 17:50:52.473 Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation() 8/29 17:50:52.473 Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence() 8/29 17:50:52.473 Interface\AddOns\GSE\API\Events.lua:310 ?() 8/29 17:50:52.473 Interface\AddOns\Ailo\Libs\ AceTimer-3.0\AceTimer-3.0.lua:53 8/29 17:50:52.473 Global variable retvalue tainted by Ailo - Interface\AddOns\GSE\API\Storage.lua:613 PrepareStepFunction() 8/29 17:50:52.473 Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation() 8/29 17:50:52.473 Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence() 8/29 17:50:52.473 Interface\AddOns\GSE\API\Events.lua:310 ?() 8/29 17:50:52.473 Interface\AddOns\Ailo\Libs\ AceTimer-3.0\AceTimer-3.0.lua:53 8/29 17:50:52.473 Global variable retvalue tainted by GSE - Interface\AddOns\GSE\API\Storage.lua:602 PrepareStepFunction() 8/29 17:50:52.473 Interface\AddOns\GSE\API\Storage.lua:1139 PrepareOnClickImplementation() 8/29 17:50:52.473 Interface\AddOns\GSE\API\Storage.lua:591 OOCUpdateSequence() 8/29 17:50:52.473 Interface\AddOns\GSE\API\Events.lua:310 ?() 8/29 17:50:52.473 Interface\AddOns\Ailo\Libs\ AceTimer-3.0\AceTimer-3.0.lua:53 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#347>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAjBFVwDjaIIElPD2RJIHRfsKB2xM0UVks5sdJc5gaJpZM4PGp8Q> .

-- *Timothy Minahan**M* 0406 413 680 | *E *[email protected]

Share to