GSE:2.3.00-BfA-beta1 deletes macros

Question

GSE:2.3.00-BfA-beta1 deletes macros

Opened this issue 6 years ago · 8 comments

Deleted user commented 6 years ago

A moment ago I updated from GSE_2.2.08 to GSE:2.3.00-BfA-beta1 (twitch client set to release).

When entering the game, GSE greeted me with a message in chat which said something along these lines:

"GSE has deleted all orphaned macros and changed them to upper case etc. you probably have to put the macros back on your bars again."

Problem: Out of 12 fully functionally macros, only 5 was left on that particular character. The rest was permanently deleted when I logged out and the game made changes to the files in the WTF folder.

-I deliberately chose not to put a check mark in "Delete Orphaned Macros on Logout" to avoid situations like this.

Suggestion: Confirmation box that leaves the decision 100% up to the user, perhaps with a message that these macros needs to be changed to upper case to function properly (I was already aware of this) and a cancel button wink. :)

I often duplicate macro's (export - change the title - import) and rewrite them for different purposes, and I believe the "clean up" couldn't tell them apart.

Example:
Fury builder macro
Fury Spender macro <-- this got deleted

I always manually create a backup of the "GSE folders - lua - lua.bak" files before I update with the twitch client, so nothing was lost, but I am very hesitant about updating if more "cleaning" is being done in future releases. GSE_2.2.08 is still working great for me after the patch.

Aaaanyway

Thank you very much for a great addon. Seriously, I really appreciate the work you've put into this addon. Have a good day :)

TimothyLuke · Answer 1 · 2018-07-18T14:29:17.000Z

Why didn’t you install 2.3.01 instead of 2.3.00- Beta1? Beta1 had quite a lot of bugs still. There was up to a beta 12. The old macro stubs were deleted. These are different to the macros stored in GSE. Any thing not compatible with BfA will still be in your GSE.lua file but won’t be accessible in game. This is a once an expansion update and a lot of the previous Stuff is no longer compatible. TimothyLuke

…

On 18 Jul 2018, at 10:15 pm, macromega ***@***.***> wrote: A moment ago I updated from GSE_2.2.08 to GSE:2.3.00-BfA-beta1. When entering the game, GSE greeted me with a message in chat which said something along these lines: "GSE has deleted all orphaned macros and changed them to upper case etc. you probably have to put the macros back on your bars again." Problem: Out of 12 fully functionally macros, only 5 was left on that particular character. The rest was permanently deleted when I logged out and the game made changes to the files in the WTF folder. -I deliberately chose not to put a check mark in "Delete Orphaned Macros on Logout" to avoid situations like this. Suggestion: Confirmation box that leaves the decision 100% up to the user, perhaps with a message that these macros needs to be changed to upper case to function properly (I was already aware of this) and a cancel button wink. :) I often duplicate macro's (export - change the title - import) and rewrite them for different purposes, and I believe the "clean up" couldn't tell them apart. Example: Fury builder macro Fury Spender macro <-- this got deleted I always manually create a backup of the "GSE folders - lua - lua.bak" files before I update with the twitch client, so nothing was lost, but I am very hesitant about updating if more "cleaning" is being done in future releases. GSE_2.2.08 is still working great for me after the patch. Aaaanyway Thank you very much for a great addon. Seriously, I really appreciate the work you've put into this addon. Have a good day :) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

ALERTua · Answer 2 · 2018-07-18T20:44:15.000Z

i lost all my macro for all my characters due to this. and there is no backup for me. i've spent a year and a half perfecting them.

Deleted user · Answer 3 · 2018-07-18T18:36:54.000Z

Because GSE:2.3.00-BfA-beta1 was the version you got when downloading it from the Twitch Client even though it was set to release. On the front page it said 2.3.01, but when you clicked on it to read the description it actually said "GSE:2.3.00-BfA-beta1".

Sorry but PEBSAC.

The reasoning for deletion is irrelevant since it was done without consent. Hence my suggestion.

I see the version has changed to GSE_2.3.01 in the descriptions page now.

Thank you :)

Deleted user · Answer 4 · 2018-07-19T11:09:47.000Z

@ALERTua I'm sorry you lost your work. @TimothyLuke apparently doesn't care and has closed the issue.

I hope Blizzard doesn't delete his addon someday when he forgets to update the TOC :P

Guys make backup every time before you update the addon or all your work could be gone. It's not the first time this has happened and likely not the last.

World of Warcraft\Interface\AddOns
Click CTRL+F and type in "gs" and copy the folders GSE & GSE_GUI & GSE_LDB

World of Warcraft\WTF\Account\ACCOUNTname
Click CTRL+F and type in "gs" and copy the files GSE.lua & GSE.lua.bak
-GSE.lua is where the macros was (lol) stored.

NB: All macros deleted was created on the BFA Beta so the "incompatible" argument is kinda moot here.

rolleyes

TimothyLuke · Answer 5 · 2018-07-19T11:19:15.000Z

There is nothing I can do to rectify the problem. You installed an early beta (beta 1 of 12) with test code from 6 months ago not designed for release or complete with known bugs that was fixed in later versions. This version had been removed from public access 5 months ago so I don’t even know where you were able to get it from. All I can assume was that it was a Curse stuff up. Do I care? yes. Can I do anything about it? No. Is it likely to happen again? No. I can’t magically make your macros reappear. As there is nothing I can do about it the only remaining thing is to close the issue. TimothyLuke

…

On 19 Jul 2018, at 8:39 pm, macromega ***@***.***> wrote: @ALERTua I'm sorry you lost your work. @TimothyLuke apparently doesn't care and has closed the issue. I hope Blizzard doesn't delete his addon someday when he forgets to update the TOC :P Guys make backup every time before you update the addon or all your work could be gone. It's not the first time this has happened and likely not the last. World of Warcraft\Interface\AddOns Click CTRL+F and type in "gs" and copy the folders GSE & GSE_GUI & GSE_LDB World of Warcraft\WTF\Account\ACCOUNTname Click CTRL+F and type in "gs" and copy the files GSE.lua & GSE.lua.bak -GSE.lua is where the macros was (lol) stored. NB: All macros deleted was created on the BFA Beta so the "incompatible" argument is kinda moot here. rolleyes — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Deleted user · Answer 6 · 2018-07-19T12:37:54.000Z

YOU uploaded GSE:2.3.00-BfA-beta1 and set it to release as 2.3.01. Not Twitch. Not me.
The version (when clicking version in the client) STILL said GSE:2.3.00-BfA-beta1 while it said 2.3.01. on the frontpage.

Now it's magically changed to GSE_2.3.01.

GSE_2.3.01. still deletes 7 out of 12 macros. ALL created on the Beta! COMPATIBLE!

Suggestion: Confirmation box that leaves the decision 100% up to the user
Suggestion: Confirmation box that leaves the decision 100% up to the user
Suggestion: Confirmation box that leaves the decision 100% up to the user
Suggestion: Confirmation box that leaves the decision 100% up to the user

Please address/FIX/stop the actual issue, the reason why I created the issue in the first place! Instead of defending PEBSAC and irrelevant explanation/justification why your addon is deleting peoples work without asking.

I've got over 100 macros over 12 Characters/36 specs both Alliance & Horde, so that's 24 characters. I'll be damned if I have to redo/remake all that work just because of some "smart" useless gimmick broken feature.

Eod.

PS. I never asked for you to magically restore my macros.

ALERTua · Answer 7 · 2018-07-20T16:31:37.000Z

@macromega I guess I found an old version of my saved GSE settings on my other computer. Does your code rework allow migrating without macro deletion? could you make a pull request to this project or upload your code changeset somewhere? I could test it and, hopefully, save my work. thank you

Deleted user · Answer 8 · 2018-07-20T14:52:35.000Z

Never mind, I fixed your code bloat and also removed a lot of obsolete/unnecessary code (do you even read the API changes?) + corrected a lot of spelling errors, so less bugs there.

Next step is moving away from this proprietary "Weak Aura Wannabe" mess.

Oh and btw. all the "incompatible" macros still works!

Case closed.

Share to