/use Toggle boxes not saving

Question

/use Toggle boxes not saving

lcestou opened this issue 5 years ago · 17 comments

lcestou commented 5 years ago

Hello Timothy,

I haven't had the chance to test this but it seems to be popping up on different topics at the forums people having this issue.

Supposedly the /use ticks on the right are not behaving like they should to stay on or off when saving the macro in the editor.

These are the topics I found and there was another but can't find at the moment:
https://wowlazymacros.com/t/updated-03-21-19-dv8-hacov-dh-mythic-raiding-m/5185/94
https://wowlazymacros.com/t/the-use-toggle-boxes-not-saving-when-changed/7486

fwyflyer commented 5 years ago

GSE.zip

TimothyLuke · Answer 1 · 2019-07-29T21:22:56.000Z

The problem is I can’t replicate their outcome. I can’t cause the behaviour they are seeing to occur. It’s either something broken on their instance of that macro, or not understanding the difference between the gold and silver ticks (ie setting them to silver and not realising that their defaults are to use trinkets) or simply not waiting for the save function to have completed before reopening the editor. For this last scenario GSE puts the save function into a queue that checks if you are in combat. It can’t update the macro if you are. If you make changes, get put in combat, hit save, then reopen the editor and edit the macro you will have the old macro and abort the save action. TimothyLuke

…

On 30 Jul 2019, at 4:01 am, Luis Cestou ***@***.***> wrote: Here is another person with the same issue I believe: https://wowlazymacros.com/t/gnome-sequencer-for-idiots-ask-and-you-will-be-answered/1359/435 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

fwyflyer · Answer 2 · 2019-07-29T22:51:34.000Z

I think a little more specificity might help...

We cannot save trinket use status WITHIN a particular macro. Mine are set as gold. I change them to black. They visually show black. I make sure I am not in combat. I save the macro I tried to edit to black for trinket use. I exit and reload GSE. I click on the same macro I tried to edit to black for trinket use and the trinket use options within that macro are back to gold. That is the problem we are having.

Moreover, I CAN alter the general GSE options to set general trinket use parameters and those do save. But even if I set the General options for trinket use to black, the gold options which appear in the individual and seemingly unalterable specific macros overrule same.

lcestou · Answer 3 · 2019-07-29T18:31:21.000Z

Here is another person with the same issue I believe:
https://wowlazymacros.com/t/gnome-sequencer-for-idiots-ask-and-you-will-be-answered/1359/435

fwyflyer · Answer 4 · 2019-07-30T03:00:26.000Z

So, I tried again. I made the changes in the tab. I hit save. It said the macro sequence was saved. I hit close. I waited 60 seconds and logged off wow completely. I went back in and still no change to the trinket tab within the macro. Is there some other step I am missing to save changes? Moreover, other changes to the macro itself do save. But changes to the trinket use in the macro do not.

TimothyLuke · Answer 5 · 2019-07-30T03:04:08.000Z

You're not getting it: After Hitting save and closing the window you *NEED TO WAIT FOR THE GSE WINDOW TO REAPPEAR ON ITS OWN*. If not then you aborted the process and stopped it finishing. If you have a convoluted bunch of macros in your queue it could take time. If you have inadvertedly stopped the queue it wont complete - Hence the LDB Monitor i referenced earlier.

…

On Tue, 30 Jul 2019 at 12:30, fwyflyer ***@***.***> wrote: So, I tried again. I made the changes in the tab. I hit save. It said the macro sequence was saved. I hit close. I waited 60 seconds and logged off wow completely. I went back in and still no change to the trinket tab within the macro. Is there some other step I am missing to save changes? Moreover, other changes to the macro itself do save. But changes to the trinket use in the macro do not. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#557>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEMCFOAEQMSM7BOLPF2VALQB6VEVANCNFSM4IHTKVLA> .

-- *Timothy Minahan**M* 0406 413 680 | *E *[email protected]

fwyflyer · Answer 6 · 2019-07-30T04:50:42.000Z

Oh, it did reappear on it's own before I logged off and exited. It took about two seconds for it to reappear after I hit close.

fwyflyer · Answer 7 · 2019-07-30T04:54:20.000Z

It is not a saving or queing issue as I can edit the macros themselves and save the changes all day long. I just cannot get the trinket on use gold squares to remain black when the changes are saved. In other words, the problem is specific to the trinkets and not to the saving.

TimothyLuke · Answer 8 · 2019-07-30T05:26:08.000Z

I just don’t get that behaviour. It works for me every time. TimothyLuke

…

On 30 Jul 2019, at 2:24 pm, fwyflyer ***@***.***> wrote: It is not a saving or queing issue as I can edit the macros themselves and save the changes all day long. I just cannot get the trinket on use gold squares to remain black when the changes are saved. In other words, the problem is specific to the trinkets and not to the saving. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

fwyflyer · Answer 9 · 2019-07-30T05:34:09.000Z

Totally understand. Either way, thank you for the incredible work you have done on this project.

TimothyLuke · Answer 10 · 2019-07-30T06:01:39.000Z

There always has to be a reason. Could you please close wow completely, zip up your GSE.lua file (found in c:\path\to\Wow\_retail\WTF\Account\YourA courNameHere\SavedVariables\GSE.lua) The only other thing I can think of is a corruption. TimothyLuke

…

On 30 Jul 2019, at 3:04 pm, fwyflyer ***@***.***> wrote: Totally understand. Either way, thank you for the incredible work you have done on this project. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

TimothyLuke · Answer 11 · 2019-07-30T06:47:19.000Z

Cheers - May be a couple of days before I can pull this apart - I’m conducting a funeral tomorrow. Just the reality of being a pastor. TimothyLuke

…

On 30 Jul 2019, at 3:43 pm, fwyflyer ***@***.***> wrote: GSE.zip — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

TimothyLuke · Answer 12 · 2019-07-29T23:41:33.000Z

Random Question: When you exit and load, I am assuming you are talking about the editor, are you waiting for the macro browser window to re-open or re-opening GSE via /gs?

…

On Tue, 30 Jul 2019 at 08:21, fwyflyer ***@***.***> wrote: I think a little more specificity might help... We cannot save trinket use status WITHIN a particular macro. Mine are set as gold. I change them to black. They visually show black. I make sure I am not in combat. I save the macro I tried to edit to black for trinket use. I exit and reload GSE. I click on the same macro I tried to edit to black for trinket use and the trinket use options within that macro are back to gold. That is the problem we are having. Moreover, I CAN alter the general GSE options to set general trinket use parameters and those do save. But even if I set the General options for trinket use to black, the gold options which appear in the individual and seemingly unalterable specific macros overrule same. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#557>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEMCFP6X5DXGZ75MNXXVUDQB5X7NANCNFSM4IHTKVLA> .

-- *Timothy Minahan**M* 0406 413 680 | *E *[email protected]

fwyflyer · Answer 13 · 2019-07-30T01:47:56.000Z

After changing the use trinkets to black in the specific tab of the macro I am trying to edit and after I hit save, GSE says the sequence {macro name} is saved. At that point I hit close. Nothing happens. I hit close again and the GSE window disappears. Then I /reload and /gs, click the macro I want to edit and see that the on use trinket(s) in that tab are once again gold.

TimothyLuke · Answer 14 · 2019-07-30T02:05:06.000Z

There's the problem. You are aborting the save and update process. When you hit save - this puts the changes into the queue. When you hit close, it tells the queue to start to process. When the queue has finished, and your changes have been finalised and acted upon, the GS browser window will reshow. When you hit /reload and /gs you have acted between when the changes were put in the queue and finalised. You need to wait for the queue to complete and the window to show for it to be complete. The LDB plugin will show you the current state and progress of the queue. For specifics see https://wowlazymacros.com/t/gse2-and-7-3/3783/2 or #321

…

On Tue, 30 Jul 2019 at 11:17, fwyflyer ***@***.***> wrote: After changing the use trinkets to black in the specific tab of the macro I am trying to edit and after I hit save, GSE says the sequence {macro name} is saved. At that point I hit close. Nothing happens. I hit close again and the GSE window disappears. Then I /reload and /gs, click the macro I want to edit and see that the on use trinket(s) in that tab are once again gold. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#557>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEMCFKG2M7PP44C6YEKLDTQB6MU3ANCNFSM4IHTKVLA> .

-- *Timothy Minahan**M* 0406 413 680 | *E *[email protected]

TimothyLuke · Answer 15 · 2019-07-30T02:06:57.000Z

also whenever you hit /reload you ABORT ANY CHANGES MADE TO GSE FROM WHEN YOU LOGGED IN. WoW doesnt save your changes to disk until you close and Exit WoW.

…

On Tue, 30 Jul 2019 at 11:34, Timothy Minahan ***@***.***> wrote: There's the problem. You are aborting the save and update process. When you hit save - this puts the changes into the queue. When you hit close, it tells the queue to start to process. When the queue has finished, and your changes have been finalised and acted upon, the GS browser window will reshow. When you hit /reload and /gs you have acted between when the changes were put in the queue and finalised. You need to wait for the queue to complete and the window to show for it to be complete. The LDB plugin will show you the current state and progress of the queue. For specifics see https://wowlazymacros.com/t/gse2-and-7-3/3783/2 or #321 On Tue, 30 Jul 2019 at 11:17, fwyflyer ***@***.***> wrote: > After changing the use trinkets to black in the specific tab of the macro > I am trying to edit and after I hit save, GSE says the sequence {macro > name} is saved. At that point I hit close. Nothing happens. I hit close > again and the GSE window disappears. Then I /reload and /gs, click the > macro I want to edit and see that the on use trinket(s) in that tab are > once again gold. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#557>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAEMCFKG2M7PP44C6YEKLDTQB6MU3ANCNFSM4IHTKVLA> > . > -- *Timothy Minahan**M* 0406 413 680 | *E ***@***.***

-- *Timothy Minahan**M* 0406 413 680 | *E *[email protected]

twisniowski · Answer 16 · 2019-07-30T20:05:39.000Z

GSE.zip
there you go.
I have also supplied a yt video of how to reproduce this:
https://www.youtube.com/watch?v=PfnZqAgc-xw

Share to