Classic WoW Spell Ranks Issue
lcestou opened this issue · 4 comments
Hello Timothy,
Here posting about some issue about when ranks are used in Classic WoW, they are not firing off for some reason.
Example:
/castsequence reset=target/10 Spell(Rank 2), Spell(Rank 2)
/cast Spell(Rank 1)
No rush :)
There are two considerations here - levelling and end game.
The issue is WoW’s api was changed to not think about spell ranks between classic and now. GetSpellID() takes Fireball and Fireball(Rank2) And If rank 2 is your highest returns the same ID.
Endgame wise it’s pretty simple. Check if a rank has been set when saving the macro and make sure that that version of the spell is stored. When reading, include the rank.
Levelling though gets a bit more interesting. It will take months for someone to level. Currently, if they don’t have a spell it will just skip. But should Rank4 Fireball downscale to Rank1 if the player doesn’t have Rank4. Logically I think it should but can this be done via the API. Also when a player learns new spells it should check if a higher rank is now available. Should it then up rank automatically or should it prompt to uprank? Should the user be able to review each change? This is a ton of time lost that the user could have spent playing because you brought Fireball Rank3
The easy answer is to do a /use Spell(Rank) as GSE won't try to convert that to an Id for down ranking but that doesn’t work in castsequences
Need more thought/input on what to do here.
TimothyLuke
… On 11 Aug 2019, at 4:31 am, Luis Cestou ***@***.***> wrote:
Hello Timothy,
Here posting about some issue about when ranks are used in Classic WoW, they are not firing off for some reason.
Example:
/castsequence reset=target/10 Spell(Rank 2), Spell(Rank 2)
/cast Spell(Rank 1)
No rush :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
The other idea is to have GSE check if its classic and just store the text but that also means that macros are client language dependent