Classic Bug: GSE2 GUI makes tradeskill window items Center justified

Question

Classic Bug: GSE2 GUI makes tradeskill window items Center justified

Jakobud opened this issue 4 years ago · 20 comments

Jakobud commented 4 years ago

In WoW Classic when using the latest GSE2, after I open the GSE2 GUI, if I use a tradeskill window, the highlighted and mouseover tradeskill names become center justified. This only happens after I open the GSE2 GUI. Something in the GUI is affecting the tradeskill window titles accidentally.

TimothyLuke · Answer 1 · 2020-10-01T04:48:45.000Z

Mate I need to know exactly which “latest” GSE build you are using. GSE depends on Ace3 for its GUI and it will be something in there that I would need them to fix. Also are there any other mods that depend on Ace3? TimothyLuke

…

On 1 Oct 2020, at 1:17 pm, Jake Wilson ***@***.***> wrote: In WoW Classic when using the latest GSE2, after I open the GSE2 GUI, if I use a tradeskill window, the highlighted and mouseover tradeskill names become center justified. This only happens after I open the GSE2 GUI. Something in the GUI is affecting the tradeskill window titles accidentally. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

Jakobud · Answer 2 · 2020-10-01T07:26:40.000Z

It looks like version 2.5.11.

Yeah I see it uses Ace3. I use lots of addons that use Ace3 libraries. I did disable all addons except GSE2 and the bug was still occurring. I haven't seen this bug before installing in GSE2.

Regarding Ace3 fixing things, Ace3 libraries haven't really been actively updated in several years, right?

Anyways, really cool addon. I just recently discovered this and it works great. I don't understand how you are able to sequence together multiple macros. Pretty awesome stuff.

TimothyLuke · Answer 3 · 2020-10-01T07:30:45.000Z

Ace3 is always being updated - atm it’s in flux for Shadowlands changes. If you can give it a week or so for their updates to hit prepatch then have a look at this? TimothyLuke

…

On 1 Oct 2020, at 4:56 pm, Jake Wilson ***@***.***> wrote: It looks like version 2.5.11. Yeah I see it uses Ace3. I use lots of addons that use Ace3 libraries. I did disable all addons except GSE2 and the bug was still occurring. I haven't seen this bug before installing in GSE2. Regarding Ace3 fixing things, Ace3 libraries haven't really been actively updated in several years, right? Anyways, really cool addon. I just recently discovered this and it works great. I don't understand how you are able to sequence together multiple macros. Pretty awesome stuff. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

Jakobud · Answer 4 · 2020-10-01T14:24:35.000Z

Interesting. Where are they actively updated? Are there github repos or something? The wowace.com site seems like it's just been abandoned.

TimothyLuke · Answer 5 · 2020-10-01T18:23:16.000Z

They are active on IRC and the SVN keeps getting commits TimothyLuke

…

On 1 Oct 2020, at 11:54 pm, Jake Wilson ***@***.***> wrote: Interesting. Where are they actively updated? Are there github repos or something? The wowace.com site seems like it's just been abandoned. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

Jakobud · Answer 6 · 2020-10-02T06:06:33.000Z

IRC and SVN?? wow :)

TimothyLuke · Answer 7 · 2020-10-02T06:14:03.000Z

To their credit they started this in 2004 and svn was cvs done well, while Linus was still dreaming of a thing like git.

…

On 2 Oct 2020, at 3:36 pm, Jake Wilson ***@***.***> wrote: SVN..... oof! — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

Jakobud · Answer 8 · 2020-10-02T06:47:05.000Z

Yeah I hear ya. I just figured they would transition to something more modern. Github. Pull Requests. etc.

TimothyLuke · Answer 9 · 2020-10-05T07:43:20.000Z

This sounds like it might be related to #199

TimothyLuke · Answer 10 · 2020-10-07T06:28:13.000Z

Im looking at this - it does look like if anything its underlying Library code that is making the change.

Can you do a test for me:

open the game with just GSE installed.
Open tradeskills - are they misaligned?
if not - close tradeskills and open GSE then reopen tradeskills - are they misaligned?

#199 changed the Font Justification and then set it back how it was at the end. I am curious if its a library setting this as a default or if the opening of the viewer causes this.

TimothyLuke · Answer 11 · 2020-10-07T19:34:56.000Z

Next question - Do you have the GSE mini map icon enabled? I’m assuming not but just trying to narrow my focus a bit further. TimothyLuke

…

On 8 Oct 2020, at 4:56 am, Jake Wilson ***@***.***> wrote: Okay I just tested this: All addons disabled except: GSE2: Gnome Sequencer Enhanced GSE2: GUI GSE2: LDB First, opening any tradeskill window like Engineering: Titles are normal. NOT misaligned. Next open up GSE2 gui (typing /gs) while the tradeskill window is still open: Titles are now misaligned. CENTER justified. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

Jakobud · Answer 12 · 2020-10-07T19:47:08.000Z

I have the minimap icon hidden as I'm access GSE via a LibDataBroker display (Bazooka). But that does bring up something else that may help you. If I right click the LDB icon it brings up the Sequence Debugger. This does not affect the title justification of tradeskills. Also opening the options window from there does not affect the title justification either.

But anyways, toggling the display of the minimap icon does not seem to have an affect on the title justification.

TimothyLuke · Answer 13 · 2020-10-07T20:07:53.000Z

Thanks - narrows it down to the viewer menu screen. Annoying part is that I don’t change the default horizontal justification anywhere and can’t replicate it locally. Will keep digging! TimothyLuke

…

On 8 Oct 2020, at 6:17 am, Jake Wilson ***@***.***> wrote: I have the minimap icon hidden as I'm access GSE via a LibDataBroker display (Bazooka). But that does bring up something else that may help you. If I right click the LDB icon it brings up the Sequence Debugger. This does not affect the title justification of tradeskills. Also opening the options window from there does not affect the title justification either. But anyways, toggling the display of the minimap icon does not seem to have an affect on the title justification. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

Jakobud · Answer 14 · 2020-10-07T21:14:26.000Z

Yeah I didn't see anything in the code that was doing it. It's strange. I think it's some sort of template inheritance thing or something? Or FontString inheritance maybe.

Jakobud · Answer 15 · 2020-10-07T18:26:24.000Z

Okay I just tested this:

All addons disabled except:

GSE2: Gnome Sequencer Enhanced
GSE2: GUI
GSE2: LDB

First, opening any tradeskill window like Engineering: Titles are normal. NOT misaligned.

Next open up GSE2 gui (typing /gs) while the tradeskill window is still open: Titles are now misaligned. CENTER justified.

TimothyLuke · Answer 16 · 2020-10-07T21:21:00.000Z

There is an alpha for Classic where I have tried to capture the existing horizontal justification like I do with the vertical one. Does that do anything? TimothyLuke

…

On 8 Oct 2020, at 7:44 am, Jake Wilson ***@***.***> wrote: Yeah I didn't see anything in the code that was doing it. It's strange. I think it's some sort of template inheritance thing or something? Or FontString inheritance maybe. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

TimothyLuke · Answer 17 · 2020-10-08T07:02:25.000Z

I got this to happen however I have commended every line and cant figure out where it is happening. In other news though I did manage to fix #262 the frame resizing bug.

TimothyLuke · Answer 18 · 2020-10-29T02:34:47.000Z

Running the latest build this seems to have been fixed.

Jakobud · Answer 19 · 2020-10-29T20:32:43.000Z

Odd. Did you figure out what caused it?

TimothyLuke · Answer 20 · 2020-10-29T20:35:18.000Z

Not specifically. It was in one of the underlying libraries that GSE depends on. Most likely LibQTip or Ace3

Share to