Add new base abilities to override list

Question

Add new base abilities to override list

TimothyLuke opened this issue 4 years ago · 11 comments

TimothyLuke commented 4 years ago

GSE stores the base ability in macros as when You cast the base ability, the temporary or proc/talent updated version of the macro is cast by the game client automatically. Eg if you have Crusade and /cast Avenging Wrath, Crusade is cast by WoW instead. Unfortunately the reverse is not true. If you /cast Crusade and don’t have the talent, it won’t cast Avenging Wrath.

There are some new talents and abilities, need to compile any changes.

Warrior:
Cleave -> Sweeping Strikes
Warbreaker -> Colossal Smash

lcestou · Answer 1 · 2020-10-08T04:07:50.000Z

Shadowlands Talents Name Base Spell Changes
https://docs.google.com/spreadsheets/d/1rJibHQBxvvNkNu1QfgBdurUvQl_egKczerd4Rx7eEGU/edit?usp=sharing

lcestou · Answer 2 · 2020-10-12T18:31:33.000Z

I added 3 more lines in the spreadsheet at the bottom that I encountered recently that were not explicitly commented in the talent but did change/updated the macro names.

TimothyLuke · Answer 3 · 2020-10-12T21:28:27.000Z

Im on a phone and cant see the spreadsheet 8-) (I'm literally doing the release via a today phone as I wont be home.)

…

On Tue, 13 Oct 2020 at 06:56, Luis Cestou ***@***.***> wrote: Sorry Timo, sure thing. Lines in spreadsheet: 34 35 36 — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#698 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEMCFPISPQ4X5ENPP4KY4DSKNRALANCNFSM4SHK3UUQ> .

-- *Timothy Minahan**M* 0406 413 680 | *E *[email protected]

lcestou · Answer 4 · 2020-10-12T22:02:16.000Z

Oh lol, I did also installed today google sheets in the phone to add those haha.

Anyway I'm off from work, these are the lines I was talking about:

lcestou · Answer 5 · 2020-10-12T22:24:40.000Z

I forgot to add this one also:

Void Eruption | Void Bolt | Shadow Priest

TimothyLuke · Answer 6 · 2020-10-12T22:56:52.000Z

Shadow and void I have will add the other two before the release TimothyLuke

…

On 13 Oct 2020, at 8:32 am, Luis Cestou ***@***.***> wrote: Oh lol, I did also installed today google sheets in the phone to add those haha. Anyway I'm off from work, these are the lines I was talking about: New Moon | Half Moon | Balance New Moon | Full Moon | Balance Shadowform | Voidform | Shadow — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

TimothyLuke · Answer 7 · 2020-10-12T20:15:02.000Z

Could you tell me which lines they were as they may already be covered in the code. TimothyLuke

…

On 13 Oct 2020, at 5:01 am, Luis Cestou ***@***.***> wrote: I added 3 more lines in the spreadsheet at the bottom that I encountered recently that were not explicitly commented in the talent but did change/updated the macro names. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

lcestou · Answer 8 · 2020-10-12T20:26:31.000Z

Sorry Timo, sure thing.

Lines in spreadsheet:
34
35
36

TimothyLuke · Answer 9 · 2020-10-13T09:20:03.000Z

NEw Moon, Full Moon and Half Moon don't replace each other - they are unique abilities that enable and disable each other but its not a Base -> upgrade thing. You need to manage this in the macro.

lcestou · Answer 10 · 2020-10-13T12:52:07.000Z

The behavior I got with New Moon and Half Moon / Full Moon is the same as others. I had to put "/use" so it wouldn't change if for some reason you do not use all the charges and stays half way and the macro happens to update the name.

The macro spell got renamed at some point to Half Moon or Full Moon once and it would not fired up that spell anymore until I changed it back to New Moon. New Moon it works for both but not backwards if that makes sense.

TimothyLuke · Answer 11 · 2020-10-13T18:29:37.000Z

The problem is they are a smart spell but they are not a base/override spell. They each have their own spell Id and are available at all times. They do have conditions that need to be met and using a /use on these is only a placebo. You think it’s doing something but it actually isn’t doing anything except breaking it for non English macros. TimothyLuke

…

On 13 Oct 2020, at 11:22 pm, Luis Cestou ***@***.***> wrote: The behavior I got with New Moon and Half Moon / Full Moon is the same as others. I had to put "/use" so it wouldn't change if for some reason you do not use all the charges and stays half way and the macro happens to update the name. The macro spell got renamed at some point to Half Moon or Full Moon once and it would not fired up that spell anymore until I changed it back to New Moon. New Moon it works for both but not backwards if that makes sense. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

Share to