Step priority

Question

Step priority

Bobby21677 opened this issue 4 years ago · 16 comments

Bobby21677 commented 4 years ago

It appears that when using step priority, the macro will start on the 1234 part of the step function instead of 1 12 123...etc

This explains why I see issues many times at the beginning of the fight after macro reset.

Here is a link to a video that I made of testing this: https://youtu.be/5cLbsb7ZUaY

Bobby21677 · Answer 1 · 2020-12-09T21:45:40.000Z

Am I seeing this correctly or is there something that I need to do differently within GSE

TimothyLuke · Answer 2 · 2020-12-10T00:05:05.000Z

Can you please confirm that either the Combat reset is gold or if grey then the GSE Options to reset after combat are selected? You were going to check that and get back to me.

…

On Thu, 10 Dec 2020 at 08:15, Bobby21677 ***@***.***> wrote: Am I seeing this correctly or is there something that I need to do differently within GSE — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#764 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEMCFPG5TI7RA4RK2V7S2LST7VZHANCNFSM4UOR5IGQ> .

-- *Timothy Minahan**M* 0406 413 680 | *E *[email protected]

Bobby21677 · Answer 3 · 2020-12-10T00:41:49.000Z

Sorry Timothy, the box is checked grey. Also, it is resetting to the first spell when leaving combat in the video.

TimothyLuke · Answer 4 · 2020-12-10T00:48:45.000Z

I cant see your video. Im on a phone atm and you didn't link it. As its Grey what do your GSE Options say?

…

On Thu, 10 Dec 2020 at 11:12, Bobby21677 ***@***.***> wrote: Sorry Timothy, the box is checked grey. Also, it is resetting to the first spell when leaving combat in the video. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#764 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEMCFJGQPQYN26QJMML27TSUAKNVANCNFSM4UOR5IGQ> .

-- *Timothy Minahan**M* 0406 413 680 | *E *[email protected]

Bobby21677 · Answer 5 · 2020-12-10T01:02:32.000Z

There’s a link in the first post that isn’t working for some reason...I’m new to GitHub.

https://youtu.be/5cLbsb7ZUaY

Bobby21677 · Answer 6 · 2020-12-10T01:20:29.000Z

That one worked for me. And in the options, it shows reset on combat.

TimothyLuke · Answer 7 · 2020-12-15T12:06:21.000Z

Is this behaving now in 2.6.35?

Bobby21677 · Answer 8 · 2020-12-15T13:45:10.000Z

Yes, it is behaving the same way in 2.6.35. The macro resets to the first spell, but nothing seems to reset the first step in the step function. In fact, I can't find anything that resets the priority steps other than reloading the addon. Also, if I press the macro while not in combat (some of the spell are defensive) the macro won't reset. I noticed that there are keybinds that can be set to manually reset the macro...would it be possible to add an amount of time, where if the macro isn't pressed, it resets? Like reset=5. I would be happy to create a video again or share screen and test with you. I'm concerned that you weren't able to recreate this...makes me feel like I'm missing something.

TimothyLuke · Answer 9 · 2020-12-15T20:21:27.000Z

Unfortunately GSE has no way to tell time within the combat sandbox. It cant tell that it hasn’t been used for x time. When I get to login next will just keep digging. TimothyLuke

…

On 16 Dec 2020, at 12:15 am, Bobby21677 ***@***.***> wrote: Yes, it is behaving the same way in 2.6.35. The macro resets to the first spell, but nothing seems to reset the first step in the step function. In fact, I can't find anything that resets the priority steps other than reloading the addon. Also, if I press the macro while not in combat (some of the spell are defensive) the macro won't reset. I noticed that there are keybinds that can be set to manually reset the macro...would it be possible to add an amount of time, where if the macro isn't pressed, it resets? Like reset=5. I would be happy to create a video again or share screen and test with you. I'm concerned that you weren't able to recreate this...makes me feel like I'm missing something. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

TimothyLuke · Answer 10 · 2020-12-16T02:49:09.000Z

I've created a test version for you - https://www.curseforge.com/wow/addons/gse-gnome-sequencer-enhanced-advanced-macros/files/3139888 Could you have a look at it? Its marked as version 2.6.35-3

Bobby21677 · Answer 11 · 2020-12-16T12:53:57.000Z

Priority is still not resetting to the first step with this version.

TimothyLuke · Answer 12 · 2020-12-16T23:30:08.000Z

ok next test: https://www.curseforge.com/wow/addons/gse-gnome-sequencer-enhanced-advanced-macros/files/3140821

TimothyLuke · Answer 13 · 2020-12-16T23:30:40.000Z

if it works i will release it at 2.6.36 but for now this is 2.6.35-4

Bobby21677 · Answer 14 · 2020-12-17T00:09:11.000Z

It looks like this is working correctly! Thank you sir!

TimothyLuke · Answer 15 · 2020-12-05T18:41:07.000Z

On your macro ensure the Combat Reset button is ticked and/or that the Reset after combat option is activated in GSE’s options. TimothyLuke

…

On 6 Dec 2020, at 12:14 am, Bobby21677 ***@***.***> wrote: It appears that when using step priority, the macro will start on the 1234 part of the step function instead of 1 12 123...etc This explains why I see issues many times at the beginning of the fight after macro reset. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

Bobby21677 · Answer 16 · 2020-12-05T18:57:02.000Z

I will double check, but I believe it is. In the video, it shows the macro resetting when I leave combat, it appears to be resetting anyway...unless I’m looking at it wrong.

Share to