Re-import using 'Rename New Macro' overwrites original macro
swancott opened this issue · 4 comments
If you re-import a macro and select the option 'Rename New Macro', It will overwrite the original.
1- Import a macro
2- Make some changes and save the macro
3- Re-Import macro and select 'Rename New Macro'
4- Change the macro's name in the 'New Sequence Name' box. Hit continue.
5- Check for the changes in the original macro and you will see everything has reset back
Let me know if you need any additional info
I sent this earlier but it hasn't saved.
Is it a case where its putting the wrong parts under the wrong label? EG original = imported and "new imported name" = original ?
Howdy,
So here is a breakdown of the steps of the issue
1 – Import a macro from site, call it ‘Macro A’
2 – Make some modifications to ‘Macro A’, add/remove/change anything and save.
3 – Now re-import the original string of ‘Macro A’
4 – GSE will see that there is already a macro named ‘Macro A’ and opens the compare window.
5 – Select the option to rename and in the rename box type ‘Marco B’
6 – You will now see both ‘Macro A’ and ‘Macro B’
7 – Now open ‘Macro A’ and you will see all the changes made in step 2 are gone.
8 – Both ‘Macro A’ and ‘Macro B’ are identical.
So expected behavior is for ‘Macro A’ to retain any changes made when macro is re-imported and using the rename feature.
Hope this explanation makes sense, if not I can show in different way.
Thanks!
Mike
From: Timothy Minahan<mailto:[email protected]>
Sent: Saturday, January 9, 2021 2:28 PM
To: TimothyLuke/GnomeSequencer-Enhanced<mailto:[email protected]>
Cc: Busterboy<mailto:[email protected]>; Author<mailto:[email protected]>
Subject: Re: [TimothyLuke/GnomeSequencer-Enhanced] Re-import using 'Rename New Macro' overwrites original macro (#774)
I sent this earlier but it hasn't saved.
Is it a case where its putting the wrong parts under the wrong label? EG original = imported and "new imported name" = original ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTimothyLuke%2FGnomeSequencer-Enhanced%2Fissues%2F774%23issuecomment-757355192&data=04%7C01%7C%7Cdf658d548ba7416a4a6a08d8b4d4c06f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637458173140897670%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=VkwsHwHZMLOrd2V9pxYl7V8y3fnt5BKn%2Fv5KUe9c%2FtM%3D&reserved=0>, or unsubscribe<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADJRM7O6NW7IPJSVLUFQASDSZCU6BANCNFSM4VR4T7SQ&data=04%7C01%7C%7Cdf658d548ba7416a4a6a08d8b4d4c06f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637458173140907660%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=RGGxxZn0f4gYv3P3YqnQC%2BOtkdi7RikGkXeK3MDZrEQ%3D&reserved=0>.
I know the question sounds obvious just for me I don’t get that happening. I get them importing as expected so trying to find the “why”.
TimothyLuke
… On 12 Jan 2021, at 12:28 am, Busterboy ***@***.***> wrote:
Howdy,
So here is a breakdown of the steps of the issue
1 – Import a macro from site, call it ‘Macro A’
2 – Make some modifications to ‘Macro A’, add/remove/change anything and save.
3 – Now re-import the original string of ‘Macro A’
4 – GSE will see that there is already a macro named ‘Macro A’ and opens the compare window.
5 – Select the option to rename and in the rename box type ‘Marco B’
6 – You will now see both ‘Macro A’ and ‘Macro B’
7 – Now open ‘Macro A’ and you will see all the changes made in step 2 are gone.
8 – Both ‘Macro A’ and ‘Macro B’ are identical.
So expected behavior is for ‘Macro A’ to retain any changes made when macro is re-imported and using the rename feature.
Hope this explanation makes sense, if not I can show in different way.
Thanks!
Mike
From: Timothy ***@***.***>
Sent: Saturday, January 9, 2021 2:28 PM
To: ***@***.***>
Cc: ***@***.***>; ***@***.***>
Subject: Re: [TimothyLuke/GnomeSequencer-Enhanced] Re-import using 'Rename New Macro' overwrites original macro (#774)
I sent this earlier but it hasn't saved.
Is it a case where its putting the wrong parts under the wrong label? EG original = imported and "new imported name" = original ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTimothyLuke%2FGnomeSequencer-Enhanced%2Fissues%2F774%23issuecomment-757355192&data=04%7C01%7C%7Cdf658d548ba7416a4a6a08d8b4d4c06f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637458173140897670%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=VkwsHwHZMLOrd2V9pxYl7V8y3fnt5BKn%2Fv5KUe9c%2FtM%3D&reserved=0>, or unsubscribe<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADJRM7O6NW7IPJSVLUFQASDSZCU6BANCNFSM4VR4T7SQ&data=04%7C01%7C%7Cdf658d548ba7416a4a6a08d8b4d4c06f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637458173140907660%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=RGGxxZn0f4gYv3P3YqnQC%2BOtkdi7RikGkXeK3MDZrEQ%3D&reserved=0>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.