Demon Blades , Fracture, and Spec swapping.

Question

Demon Blades , Fracture, and Spec swapping.

Wisconsen opened this issue 4 years ago · 7 comments

Wisconsen commented 4 years ago

Not sure why this is happening. But when specced into Demon Blades (havoc talent replaces Demon's Bite) and Fracture (Veng Talent, replaces Soul Cleave, which in itself replaced Demon's Bite from havoc). If you swap from havoc to vengence will not update properly in GSE.

I suspect this is because Demon Blades is a passive not a recognized cartable spell. So GSE is just reading it as plaintext instead of a spellID call. Though i do have limited understanding of how those things work under the hood.

Only fix is to manually change the macro when you swap to vengeance.

Just tested it without spec swapping, and it is not changing Demon Blades back to Demon's Bite properly when just talent swapping as havoc. Leaving the plain text for demon blades after unselecting the talent.

TimothyLuke · Answer 1 · 2021-02-05T00:17:53.000Z

Do you want to try this post 2.6.45?

TimothyLuke · Answer 2 · 2021-02-04T21:03:17.000Z

GSE is not paying attention properly. It’s supposed to recreate the hidden buttons that form your macro when you change specs, leave combat, level up etc. Even though I have the code that if you change specs to update the macros on line 268 it’s actually not paying attention for the spec change at https://github.com/TimothyLuke/GnomeSequencer-Enhanced/blob/d4e8b0208328e38cfae83ff075fb0369b7c241da/GSE/API/Events.lua#L290 TimothyLuke

…

On 5 Feb 2021, at 4:16 am, Wisconsen ***@***.***> wrote: Not sure why this is happening. But when specced into Demon Blades (havoc talent replaces Demon's Bite) and Fracture (Veng Talent, replaces Soul Cleave, which in itself replaced Demon's Bite from havoc). If you swap from havoc to vengence will not update properly in GSE. I suspect this is because Demon Blades is a passive not a recognized cartable spell. So GSE is just reading it as plaintext instead of a spellID call. Though i do have limited understanding of how those things work under the hood. Only fix is to manually change the macro when you swap to vengeance. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

Wisconsen · Answer 3 · 2021-02-05T00:46:42.000Z

Still is not functioning correctly, requiring manually changing the gse macro swapping specs or changing off of the demon blades talent

TimothyLuke · Answer 4 · 2021-02-05T00:55:09.000Z

Ok I will need to level a DH to look into this further TimothyLuke

…

On 5 Feb 2021, at 11:16 am, Wisconsen ***@***.***> wrote: Still is not functioning correctly, requiring manually changing the gse macro swapping specs or changing off of the demon blades talent — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

TimothyLuke · Answer 5 · 2021-07-01T06:20:28.000Z

@Wisconsen Can you have a look at this again in the light of GSE3 and 9.1?

Wisconsen · Answer 6 · 2021-07-01T09:34:48.000Z

I have not had any problems with this in 9.1 so far.

TimothyLuke · Answer 7 · 2021-07-01T09:49:29.000Z

Going to close this out. If it reappears we can reopen this and investigate further.

…

On Thu, 1 Jul 2021 at 19:04, Wisconsen ***@***.***> wrote: I have not had any problems with this in 9.1 so far. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#790 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEMCFOBWHXWQQGFUTHKBYDTVQZEDANCNFSM4XDIKMMA> .

-- *Timothy Minahan**M* 0406 413 680 | *E ***@***.***

Share to