An error appears after renaming a new macro then clicking on tab "1"

Question

An error appears after renaming a new macro then clicking on tab "1"

xan2622 opened this issue 4 years ago · 9 comments

xan2622 commented 4 years ago

Describe the bug
After renaming a new macro then clicking on tab "1", this error appeared:
Interface\AddOns\GSE_GUI\Editor.lua:873: attempt to compare number with nil

To Reproduce
Steps to reproduce the behavior:

Open the Sequence Editor
Click on the "New" button
Rename the default Sequence Name from "NEW_SEQUENCE" to "MyNewMacro" (or any other name)
Click on the tab "1"
This error may appear:

Message: Interface\AddOns\GSE_GUI\Editor.lua:873: attempt to compare number with nil
Time: Tue Jun  1 20:38:16 2021
Count: 4
Stack: Interface\AddOns\GSE_GUI\Editor.lua:873: attempt to compare number with nil
[string "=[C]"]: ?
[string "@Interface\AddOns\GSE_GUI\Editor.lua"]:873: in function <Interface\AddOns\GSE_GUI\Editor.lua:869>
[string "=[C]"]: in function `?'
[string "@Interface\FrameXML\UIParent.lua"]:2393: in function <Interface\FrameXML\UIParent.lua:1277>

Locals:

Expected behavior
GSE should display the tab "1" without generating this error.

Screenshots

Desktop
OS: Windows 10 64bits pro
Hardware: nvidia GTX 1070 8GB - driver: 466.47

Game Version
World of Warcraft Shadowlands version 9.0.5.38556 (french language)

GSE Version
Version: 2.6.54

TimothyLuke · Answer 1 · 2021-06-01T23:56:56.000Z

Like #829 I cant make this occur. I perform the exact same steps and do not get this issue.

xan2622 · Answer 2 · 2021-06-02T05:07:24.000Z

Additional context
Here are all the addons that I also installed:

ACP 3.5.7 (not activated)
AlreadyKnown 1.32
AtlasLoot 8.13.00 (not activated)
Auctionator 9.0.9
AutoTurnIn 9.0.2
BigWigs 221.1
BigWigs_BurningCroisade 9.0.4
BigWigs_Cataclysm 9.0.3
BigWigs_Legion 9.0.4
BigWigs_MistsOfPandaria 9.0.4
BigWigs_WarlordsOfDraenor 9.0.3
BigWigs_WrathOfTheLinchKing 9.0.5
Details Retail 9.0.5.8404.144
DynamicCam 1.4.10
elvui 12.24
GatherMate2_Data 36.1
GatherMate2 1.46.7
Grail 114
GTFO 4.62.1
HandyNotes 1.6.2
HandyNotes_DungeonLocations 1.53
HandyNotes_Oribos 11
LittleWigs 9.0.33
MaxDps 9.05.1
MaxDpsHunter 9.0.2.1
MaxDps_Mage 9.0.2
MBB 4.0.7 (not activated)
RareScanner 9.0.5.1
Scrap 9.0.5-9.0.5
TooltipItemIcon 1.783
WeakAuras 3.3.0
Wholly 082
WIM 3.9.0

TimothyLuke · Answer 3 · 2021-06-02T05:11:12.000Z

Mate I test with two things - GSE on its own and with ElvUI. Beyond that you are going to have to work through this on your own. Start with just GSE - if you don't have the problem then add an addon one at a time and see if you get the issue back. If so you know the culprit. Then you need to decide what you want to do about it. But you are the only one with this issue and no one else has reported anything like it.

…

On Wed, 2 Jun 2021 at 14:37, xan2622 ***@***.***> wrote: *Additional context* Here are all the addons that I also installed: *ACP 3.5.7 (not activated)* AlreadyKnown 1.32 *AtlasLoot 8.13.00 (not activated)* Auctionator 9.0.9 AutoTurnIn 9.0.2 BigWigs 221.1 BigWigs_BurningCroisade 9.0.4 BigWigs_Cataclysm 9.0.3 BigWigs_Legion 9.0.4 BigWigs_MistsOfPandaria 9.0.4 BigWigs_WarlordsOfDraenor 9.0.3 BigWigs_WrathOfTheLinchKing 9.0.5 Details Retail 9.0.5.8404.144 DynamicCam 1.4.10 elvui 12.24 GatherMate2_Data 36.1 GatherMate2 1.46.7 Grail 114 GTFO 4.62.1 HandyNotes 1.6.2 HandyNotes_DungeonLocations 1.53 HandyNotes_Oribos 11 LittleWigs 9.0.33 MaxDps 9.05.1 MaxDpsHunter 9.0.2.1 MaxDps_Mage 9.0.2 *MBB 4.0.7 (not activated)* RareScanner 9.0.5.1 Scrap 9.0.5-9.0.5 TooltipItemIcon 1.783 WeakAuras 3.3.0 Wholly 082 WIM 3.9.0 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#839 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEMCFK2IUANGZI7NSJMW6TTQW4BVANCNFSM455HIAZA> .

-- *Timothy Minahan**M* 0406 413 680 | *E ***@***.***

xan2622 · Answer 4 · 2021-06-04T20:26:25.000Z

I am answering in this Github issue because what I am going to type next is related to this (839) issue (I checked if the error appeared, after following those steps).

You said (here) that these errors could be caused by the sample macros.

I have noticed that SAM_LUTECHI's macros contain white lines: AFAIK, it means that something is broken in these lines (a typo or bad command).

So I deleted the GSE.lua and GSE.lua.bak files once more and joined the game with my MM Hunter. As soon as I joined the game, GSE asked me if I wanted to load the sample macros, I declined this offer (to have an empty Sequence Editor).

I reproduced the steps mentionned above. This time, I could rename the Sequence Name and click on the tab "1" without any error poping up.

TimothyLuke · Answer 5 · 2021-06-04T22:17:43.000Z

No that means the macro has lines that won’t work in your talent setup/spec and be ignored at execution. Lutechi’s macros were an all in one attempt that you could use with any talent combo at 50 to get to 70. It will work but it wouldn’t be efficient. TimothyLuke

…

On 5 Jun 2021, at 5:56 am, xan2622 ***@***.***> wrote: I am answering in this Github issue because what I am going to type next is related to this (839) issue (I checked if the error appeared, after following those steps). You said (here) that these errors could be caused by the sample macros. I have noticed that SAM_LUTECHI's macros contain white lines: AFAIK, it means that something is broken in these lines (a typo or bad command). So I deleted the GSE.lua and GSE.lua.bak files once more and joined the game with my MM Hunter. As soon as I joined the game, GSE asked me if I wanted to load the sample macros, I declined this offer (to have an empty Sequence Editor). I reproduced the steps mentionned above. This time, I could rename the Sequence Name and click on the tab "1" without any error poping up. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

xan2622 · Answer 6 · 2021-06-05T07:13:52.000Z

OK, thank you for this clarification.

I noticed that, after importing the three sample macros, GSE failed to translate some spells from English to French.
So I guess, because of that, it's normal and expected that these lines can't work.

Should I report this "failure" in another Github issue?

xan2622 · Answer 7 · 2021-06-05T17:47:53.000Z

Edit:

The error not only appears after renaming the Sequence Name and clicking on tab "1", it can also appear if :

you open the Sequence Editor
you click on the "New" button
you just click once in the Sequence Name text field (without even renaming it, just a click at the end of the macro name)
you click on either the "Variables", "1" or "WeakAuras" tabs but also if you click once in any of the text fields of the the Configuration tab (Help Link, Default Version, ... Dungeon, Party..)

Note that it doesn't only appear after clicking on the "New" button. It can also happen if you edit any macro.

TimothyLuke · Answer 8 · 2021-06-05T09:25:55.000Z

This isn’t a failure it’s a limit on what is possible translating amongst languages without adding in a 2gb translated engine to the mod size. #795 is an attempt to over come this but it’s early days still in coding that solution. TimothyLuke

…

On 5 Jun 2021, at 4:44 pm, xan2622 ***@***.***> wrote: OK, thank you for this clarification. I noticed that, after importing the three sample macros, GSE failed to translate some spells from English to French. So I guess, because of that, it's normal and expected that these lines can't work. Should I report this "failure" in another Github issue? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

xan2622 · Answer 9 · 2021-06-17T04:58:40.000Z

This error seems to be fixed in GSE 3.0.0 beta 5.

Share to