GSE: Sequences, Variables, Macros

GSE: Sequences, Variables, Macros

7M Downloads

[ENH] Allow to (temporarly) disable blocks

xan2622 opened this issue · 6 comments

commented

Is your feature request related to a problem? Please describe.
Some GSE macros can be long (or complex). Sometimes, blocks can contain several lines or even contain many blocks inside them (in the case of "Loops").

During the edition of macros, it could be interesting for the GSE user to be able to temporarly disable a block without completely deleting it.

Use case:
Let's say a macro is composed of many blocks (and some of them contain many actions), the GSE user might prefer not to cast some of these spells (or some blocks) right now. He/she might have plans to reuse them but for later, or to move these actions into another block.

It would also be particularly useful for long "Loop" blocks. Currently, if the player doesn't want to launch all these spells, he currently has delete the whole Loop block. But with this new "Eye button", the player would be able (before really deleting a long block) to temporarly disable it, test the macro, then delete the block if he/she really wants to.

With such a "Disable Block" feature, the player could somehow make a whole block a "comment", like in coding, where the developer can add a # at the beginning of a line of code or at the beginning of several lines to skip them temporarly.

Describe the solution you'd like
Could you consider adding a new icon to disable a block (next to the "delete block" icon)?
Just an idea about a possible button (its icon would change, depending on its state):
eye

When a block is "disabled" (Eye closed), then the macro would just skip it and hop to the next block.
Once disabled, no edition would be possible to that block.
Clicking one more time on the "eye" icon would make the block active again.

Also, to clearly see if a block is disabled, its background color could turn dark-red (for example).

Mock-up

qsdqsd

commented

You can already do this by prefixing the lines in a block with — (2 -‘s) If the entire block is comments then it will be essentially ignored and disabled.

commented

I see, but the extra visual and auto comment out/in would help a lot. Keeping tract of and making sure you have done it right is a bit of a chore especially if you block is complex. Visiting the forums shows that many don't really understand prior versions. This one is a order of magnitude harder for the none coder/player. It is impossible to eliminate user errors. This best would be giving them enough simple tools were the errors are restricted and manageable.

commented
commented

Actually, that's a really nice Idea. Compile issues would be handled by the #. Given the new format and not wanting to play with raw all the time it would make life a lot easier. In the earlier version I just used a clipboard utility to handle that(add and removal of lines for test). The new version does not handle that well.

commented

image

commented

For some reason, backgrounds of some blocks now feature the same dark-red colour.
GSE 3.0.16

EDIT : It seems that if you:

  • disable a block,
  • save the macro,
  • close the Sequence Editor
  • Edit the same macro one more time > go to "1 tab"
  • you could notice these dark-red backgrounds misplaced on other blocks