[ENH] Allow the player to press ESC key to close the Sequence Editor window

Question

[ENH] Allow the player to press ESC key to close the Sequence Editor window

xan2622 opened this issue 3 years ago · 3 comments

xan2622 commented 3 years ago

Is your feature request related to a problem? Please describe.
The Sequence Editor window can't get closed by pressing ESC key.

Describe the solution you'd like
Allow the player to press ESC key to close the Sequence Editor window.

Additional context
Note that the GSE Options window allows it.

GSE version
GSE 3.0.16

TimothyLuke · Answer 1 · 2021-07-05T22:09:45.000Z

This was actually taken out as the ESC key would mean people lost unsaved work back in #92 when close and save we’re separated into two different buttons TimothyLuke

…

On 6 Jul 2021, at 6:55 am, xan2622 ***@***.***> wrote: postscript: I know that it's a futile (very low priority) suggestion, but I think it would still help increase the "user-friendliness" of the addon (even a little bit). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

xan2622 · Answer 2 · 2021-07-05T21:25:36.000Z

postscript:
I know that it's a futile (very low priority) suggestion, but I think it would still help increase the "user-friendliness" of the addon (even a little bit).

xan2622 · Answer 3 · 2021-07-06T03:07:33.000Z

Just a thought:

Couldn't the window accept the ESC key event but only if SAVE button has been pressed before?

And if the macro is being edited, then do nothing if the user presses ESC.

Only accept to close the window if the macro is "safe", or if no modification has been made to it yet.

Share to