GSE: Sequences, Variables, Macros

GSE: Sequences, Variables, Macros

6M Downloads

[ENH] Checkbox texts (in options) are trunkated (depending on the Localisation used)

xan2622 opened this issue · 7 comments

commented

🟢 Is your feature request related to a problem? Please describe.
Some languages are very verbose (French, German, etc).

If you open GSE3 Options when the WoW client is set to one of these languages, you can see that the translated sentences are too long to fit in the checkbox text length. This also happens with the English language (rarely, but the end of some strings are also replaced by "...").

🟢 Describe the solution you'd like
1- Increase the length of all checkboxes texts.
This would add space at the end of english checkbox texts (usually English strings are shorter than in other languages) but it would also give translators more space for their translations. If you could give checkbox texts a limit of 60 characters maximum, that would be cool.

2- Word Wrap:
Increase the height of each checkbox text to wrap words if the sentence can't fit on one line.
It would give sentences more space (on the next line) if they don't fit on the first line.

3- Adapt checkboxes text length to translation:
Dunno if it's possible (coding wise it must certainly be more difficult) but the idea is:

  • if GSE3 detects that the language of the WoW client is "English", then use the length of the sentence found in ModL_enUS.lua.
  • if the addon detects that the WoW client is in French, then use the ModL_frFR.lua localisation file to know the length of the checkbox text.
commented
commented
commented

As the UI also has to scale down to fit a 500x500 window that is not practical.

Correct me if I am wrong, this 500x500 pixels limitation is to fit the GSE options into the Menu > Interface > Addons tab window?

If it is, may I suggest to get rid of this limitation by mimicking what other addons do: placing a button on this Menu > Interface > Addons tab window to load the GSE Options the same way the player would do if he/she clicks on the Minimap icon.

Details:

Hekili:

This would help get rid of the problem of "checkboxes texts" being truncated in all very verbose languages and would get rid of this 500x500 pixels Options window limitation.

commented

ive gone back to this - the layout for this is controlled by Ace3. I don't lay out the options window at all. The options are truncated in English when i change the size of the interface on the outside.

In options:
image

external:
image

Putting in that option won't solve the issue. The tooltip however is not truncated. This is one of those that I am unable to at this stage fix.

commented

The min 500x500 is to be able to show the interface with a computer running WoW’s minimum resolution - 800x600 GSE has to be able to run both at that small as well as on your 4K machine The options are irrelevant to this decision - they auto resize depending on the size of that interface.

I didn't know that. I have always thought WoW's minimum screen resolution was 1024 x 768.
https://us.battle.net/support/en/article/76459
I guess it changed over time.


Back to the topic.

Currently, the Menu > Interface > Addons > GSE options look like the following screenshot:
An area 650 pixels wide for checkboxes texts.

650_pixels_for_options

What if the GSE Options UI looked like the following mock-up (with tabs at the top)?
It would give more space for the checkboxes texts (930 pixels wide).

more_space_for_checkboxes_texts

Edit: self answer:
It probably would not be compatible with a 500x500 resolution. 😕

Does GSE really have to support these very low screen resolutions (that only a very few players still use)?

Shouldn't GSE only be compatible with WOW's minimum requirements (1024x768)?

Somehow, there must be a way to display checkboxes texts without truncation (even in English). 🤔

btw, there are more important GitHub Issues than this one, but this truncation is quite visually annoying. 😬☺️

commented
commented