GSE: Sequences, Variables, Macros

GSE: Sequences, Variables, Macros

8M Downloads

[BUG] Repeat block skips last insert

Opened this issue Β· 2 comments

commented

πŸ”΅ Describe the bug:
Repeat block skips last insert.

πŸ”΅ To reproduce: (Steps to reproduce the behavior)

  1. Type '/gse' in Chat Frame
  2. Click on 'New'
  3. Add Repeat block with Interval 3 as first block
  4. Add 7 Action blocks after
  5. Check Compiled Template

πŸ”΅ The error:
Repeat block is only repeated two times. After Action 2 and Action 4.

For shorter intervals the number of skipped inserts increases, e.g. Interval 2 and 7 Action blocks, skips 2 inserts.

πŸ”΅ Expected behavior:
Repeat block should be repeated three times. After Action 2, Action 4 and Action 6.

πŸ”΅ Raw Edit:

{
    ["Variables"] = {
        
    },
    ["Actions"] = {
        [1] = {
            [1] = "/say Repeat 1",
            ["Interval"] = 3,
            ["Type"] = "Repeat"
        },
        [2] = {
            [1] = "/say Action 1",
            ["Type"] = "Action"
        },
        [3] = {
            [1] = "/say Action 2",
            ["Type"] = "Action"
        },
        [4] = {
            [1] = "/say Action 3",
            ["Type"] = "Action"
        },
        [5] = {
            [1] = "/say Action 4",
            ["Type"] = "Action"
        },
        [6] = {
            [1] = "/say Action 5",
            ["Type"] = "Action"
        },
        [7] = {
            [1] = "/say Action 6",
            ["Type"] = "Action"
        },
        [8] = {
            [1] = "/say Action 7",
            ["Type"] = "Action"
        }
    },
    ["InbuiltVariables"] = {
        
    }
}

πŸ”΅ Desktop (please complete the following information):

  • OS: Microsoft Windows 10 Pro (19043)
  • Game Version: 9.1.0 (39427)

πŸ”΅ GSE Version:

  • Version: 3.0.36
  • Downloaded From: Ajour (Curse)

πŸ”΅ Compiled Template:

Step 1
/say Repeat 1

Step 2
/say Action 1

Step 3
/say Action 2

Step 4
/say Repeat 1

Step 5
/say Action 3

Step 6
/say Action 4

Step 7
/say Repeat 1

Step 8
/say Action 5

Step 9
/say Action 6

Step 10
/say Action 7

commented

Wouldn’t you want an interval of 2 for that instead of 3? The interval is the gap between so it should be 1,4,7 with an interval of 3. As you only have 8 steps initially it doesn’t calculate the length with the insertions so stops at 7. It prob should calculate through though and insert again at 10.

commented

Made a change to also calculate the inserted rows in the maths. Using your macro i now get.

Step 1
/say Repeat 1
/use [combat,nochanneling] 13
--------------------------------------
Step 2
/say Action 1
/use [combat,nochanneling] 13
--------------------------------------
Step 3
/say Action 2
/use [combat,nochanneling] 13
--------------------------------------
Step 4
/say Repeat 1
/use [combat,nochanneling] 13
--------------------------------------
Step 5
/say Action 3
/use [combat,nochanneling] 13
--------------------------------------
Step 6
/say Action 4
/use [combat,nochanneling] 13
--------------------------------------
Step 7
/say Repeat 1
/use [combat,nochanneling] 13
--------------------------------------
Step 8
/say Action 5
/use [combat,nochanneling] 13
--------------------------------------
Step 9
/say Action 6
/use [combat,nochanneling] 13
--------------------------------------
Step 10
/say Repeat 1
/use [combat,nochanneling] 13
--------------------------------------
Step 11
/say Action 7
/use [combat,nochanneling] 13
--------------------------------------