HandyNotes: Battle for Azeroth

HandyNotes: Battle for Azeroth

3M Downloads

Feature Request: Checkmark next to completed achievement submenus?

Protuhj opened this issue ยท 5 comments

commented

In the dropdown for Achievements, there's no distinction for completed achievements.

It would be nice if there was a quick way to determine if the achievement is completed, either by mousing over the achievement, or just on the menu item for the achievement itself.

Extra points for distinguishing between account-completed and completed on the current character, since some achievement criteria come with reputation rewards.

commented

i implemented checkmarks to the Achievement submenu.
it should work like this:
Gray = Incomplete
Yellow = Completed on other character
Green = Completed by current character
image

we still need to test it, i dont have an alt right now to test it myself.
if everything works it will get added to the next release.

commented

What's the process to test a branch?

Oh, you committed to master. I'll clone the repo and test it out.

commented

Seems to work great and is exactly what I was looking for.

Though, if an achievement isn't complete at all, I think it would be better with no check at all.

image

The gray icon doesn't add information, and looks too close to the yellow ones IMO.

commented

I wonder if it would be beneficial (or is even possible) to change from yellow checkmarks to blue checkmarks for tracking account-wide achievements completed. I imagine using the same blue as the blue used for account-wide achievements.

I do agree that removing the gray checkmark makes sense and simplifies for the viewer, regardless of changing to blue.

commented

this is now implemented in the latest v30 release