HandyNotes: Battle for Azeroth

HandyNotes: Battle for Azeroth

3M Downloads

"siege on dragonbane keep" appears to do nothing in Waking Shores

Rezy942 opened this issue ยท 3 comments

commented

Hello,

I keep toggling this on and off and dont see anything pop up on the map.
Checking "show completed" also has no effect.
Am I missing something or is this a bug?
Thanks :)

image

commented

Update: I found what it does! It adds tooltip function over the siege blizz icon when it appears.
Problem is it only appears when a siege is active!
Is it possible to perhaps add a dedicated siege icon that will display this info all the time?
Similar to storm icons :)
Thanks

commented

Looks like the icon will only be rendered on the map if the siege is not active

-------------------------------------------------------------------------------
-------------------------- SIEGE ON DRAGONBANE KEEP ---------------------------
-------------------------------------------------------------------------------
local SIEGE_ON_DRAGONBANE_KEEP_AREA_POIS = {
[7267] = 'Before Siege',
[7104] = 'During Siege',
[7413] = 'After Siege'
}
local SIEGE_ON_DRAGONBANE_KEEP_REWARDS = {
Achievement({id = 16411}), -- Siege on Dragonbane Keep: Home Sweet Home
Toy({item = 200116}), -- Everlasting Horn of Lavaswimming
ns.reward.Spacer(), Item({item = 192055}) -- Dragon Isles Artifact
}
map.nodes[30287005] = Collectible({
label = L['dragonbane_siege_label'],
icon = 3753264,
areaPOIs = {7104, 7394, 7413},
mapID = map.id,
group = ns.groups.DRAGONBANE_SIEGE,
requires = ns.requirement.Reputation(2510, 5, true), -- Valdrakken Accord
rewards = SIEGE_ON_DRAGONBANE_KEEP_REWARDS,
IsEnabled = function(self)
local activePOIs = C_AreaPoiInfo.GetAreaPOIForMap(self.mapID)
local possiblePOIs = self.areaPOIs
for a = 1, #activePOIs do
for p = 1, #possiblePOIs do
if activePOIs[a] == possiblePOIs[p] then
return false
end
end
end
return true
end
}) -- Siege on Dragonbane Keep

commented

Looks like the icon will only be rendered on the map if the siege is not active

-------------------------------------------------------------------------------
-------------------------- SIEGE ON DRAGONBANE KEEP ---------------------------
-------------------------------------------------------------------------------
local SIEGE_ON_DRAGONBANE_KEEP_AREA_POIS = {
[7267] = 'Before Siege',
[7104] = 'During Siege',
[7413] = 'After Siege'
}
local SIEGE_ON_DRAGONBANE_KEEP_REWARDS = {
Achievement({id = 16411}), -- Siege on Dragonbane Keep: Home Sweet Home
Toy({item = 200116}), -- Everlasting Horn of Lavaswimming
ns.reward.Spacer(), Item({item = 192055}) -- Dragon Isles Artifact
}
map.nodes[30287005] = Collectible({
label = L['dragonbane_siege_label'],
icon = 3753264,
areaPOIs = {7104, 7394, 7413},
mapID = map.id,
group = ns.groups.DRAGONBANE_SIEGE,
requires = ns.requirement.Reputation(2510, 5, true), -- Valdrakken Accord
rewards = SIEGE_ON_DRAGONBANE_KEEP_REWARDS,
IsEnabled = function(self)
local activePOIs = C_AreaPoiInfo.GetAreaPOIForMap(self.mapID)
local possiblePOIs = self.areaPOIs
for a = 1, #activePOIs do
for p = 1, #possiblePOIs do
if activePOIs[a] == possiblePOIs[p] then
return false
end
end
end
return true
end
}) -- Siege on Dragonbane Keep

Hi, not sure what you mean to be honest!
Here is a screenshot for context in case it helps someone - as you can see siege is checked, siege is NOT active, and I dont see any icon the map :)
This screenshot was taken when siege timer is 30m left until it starts.

image