HandyNotes: Battle for Azeroth

HandyNotes: Battle for Azeroth

3M Downloads

Dragonflight: Elianna and Talisa Whisperbloom (in ED) nodes overlap Central Encampment icon

Protuhj opened this issue ยท 6 comments

commented

ADDON VERSION: v43

Describe the bug
When trying to mouseover the Elianna or Talisa Whisperbloom icons, you have to be real precise to not mouse over the Cental Encampment icon instead.

commented

i'm not sure, but i don't think we can force the frame strata of the node icons. it's probably set by HandyNotes.

commented

It is possible, but not directly through the interface HandyNotes provides. You have to re-assign the strata manually for those specific nodes using hooks. There was an example in the prepatch for Dragonflight:

-- This is a hack to raise the frame level of these vendor pins. Otherwise they
-- have trouble rendering their tooltips on hover when competing against the
-- nearby city and zeppelin icons.
hooksecurefunc(HandyNotesWorldMapPinMixin, 'OnAcquired', function(self, ...)
if self.texture:GetTexture() == 237016 then
self:UseFrameLevelType('PIN_FRAME_LEVEL_WAYPOINT_LOCATION')
else
self:UseFrameLevelType('PIN_FRAME_LEVEL_AREA_POI')
end
end)

Basically you add a custom hook for all HandyNotes pins, find a way to filter down to the pins you want (in this case, we used the texture) and then modify those pins.

commented

If the nodes were offset, or displayed otherwise, that would be sufficient.

If the strata can solve the problem too, that would be ideal of course.

commented

I came here to suggest moving Elianna's icon a bit further away from the center, that way it would also be more easily identifiable and more visible that there actually is an icon for the NPC.

commented

This seems to be fixed in 44 -- @Ioney or @zarillion if you can confirm this was fixed, then the issue can be closed.

Edit: on second look, it seems like it just depends if I scale the icons up then it "appears" to be fixed, but then the icons overlap. Sorry for the ping.

commented

I'm going to close this in favor of a different issue, because these nodes should probably be moved.