HandyNotes Hallow's End

HandyNotes Hallow's End

1M Downloads

GetQuestsCompleted error

dartraiden opened this issue ยท 4 comments

commented

[9.0.1] GetQuestsCompleted was moved to C_QuestLog.GetAllCompletedQuestIDs() and returns quest IDs an a sorted array

{
	[1] = 56775,
	[2] = 58208,
	[3] = 58209,
}
commented

Crap I forgot about this. >.<

I've amended the code and a new alpha package will be on CurseForge soon. Let me know how it goes. ๐Ÿ™‚

commented

It show all buckets if "Show completed" is disabled - OK
But it miss some buckets (Westfall, Stormwind, Goldshire, Northrend at all) if "Show completed" is enabled

Wow_F8sD7BVmaW

Wow_nG3eXwyfZr

commented

Fix because the author's upload takes a while:

at 228 of Core.lua:

		--completedQuests = GetQuestsCompleted(completedQuests)
		local tmpPairs = C_QuestLog.GetAllCompletedQuestIDs()
		for _, id in ipairs(tmpPairs) do 
			completedQuests[id] = "true";
		end
commented

Yes, it works after this fix.

		local tmpPairs = C_QuestLog.GetAllCompletedQuestIDs()
		for _, id in ipairs(tmpPairs) do 
			completedQuests[id] = "true";
		end