HandyNotes: The War Within

HandyNotes: The War Within

592k Downloads

Inconsistency with "appearance learned from other items" and "Show unobtainable transmog"

Le-Lucien opened this issue ยท 2 comments

commented

Hello,

Sorry if it feels similar to #143 but there's some inconsistency with the appearance learned from other items when the option Show unobtainable transmog is turned on. There's no distinction between "unlearnable (known)" and "unlearnable (missing)". Resulting in a different display when playing different classes :
HN

commented

I'm using this function to determine if the character knows the appearance. If they do, it will display "Known" before deciding to display "Unlearnable" or "Unobtainable".

function Transmog:IsKnown()
    if CTC.PlayerHasTransmog(self.item) then return true end
    local appearanceID, sourceID = CTC.GetItemInfo(self.item)
    if sourceID and CTC.PlayerHasTransmogItemModifiedAppearance(sourceID) then
        return true
    end
    if appearanceID then
        local sources = CTC.GetAppearanceSources(appearanceID)
        if sources then
            for i, source in pairs(sources) do
                if source.isCollected then return true end
            end
        end
    end
    return false
end

On my paladin, all of those functions return false for the Fang of Phestis, so even though I technically know the appearance, all of Blizzard's APIs say that I do not when on my paladin. I'm going to close this issue as "working as intended" since I have no control over what the Blizzard APIs return. I'm sorry I could not address it easily.

commented

No worries. Thanks for your time !