HandyNotes: Visions of N'Zoth

HandyNotes: Visions of N'Zoth

4M Downloads

Chest map tooltips missing info.

dle0105 opened this issue ยท 7 comments

commented

Not sure when this started, but when you open your map and hover over one of the chest icons that the game provides, there is no longer any info on possible drops from them.

commented

Started with 9.0.5. Sorry for no other answer.

commented

Fast check shows that SetTextis not any more called, which was the current hook. It calls now AddLine ...

commented

Yes, I read in other side that the API have changes.

ASAP, @zarillion will make the proper changes.

commented

The tooltip rewards should show up most of the time now. It still doesn't seem to work sometimes and when it does it renders the rewards outside the tooltip box. If a better solution doesn't arise I'll probably just rip the entire feature out until Blizzard adds a better method to hook into for Vignette tooltips (which is probably never).

Pull requests welcome ๐Ÿ˜ƒ

commented

Wouldn't calling Show with a sentinel help with that e.g:

local ownCall = false
function(self)
    if ownCall then return end

    if addThings then
        -- add new content

        ownCall = true
        self:Show()
        ownCall = false
    end
end
commented

Wouldn't calling Show with a sentinel help with that e.g:

local ownCall = false
function(self)
    if ownCall then return end

    if addThings then
        -- add new content

        ownCall = true
        self:Show()
        ownCall = false
    end
end

I can confirm that this works.

@Dairyman, if you don't feel like whipping up a PR then I will.

commented

@Wevah sure go ahead