HandyNotes: WorldMapButton

HandyNotes: WorldMapButton

1M Downloads

Lua Error on BCC when opening map.

b-morgan opened this issue ยท 2 comments

commented

This error occurs both with and without the addon Mapster.

2x ...dyNotes_WorldMapButton\HandyNotes_WorldMapButton-20501.01-BBC.lua:95: attempt to index local 'alignmentFrame' (a nil value)
[string "@HandyNotes_WorldMapButton\HandyNotes_WorldMapButton-20501.01-BBC.lua"]:95: in function <...dyNotes_WorldMapButton\HandyNotes_WorldMapButton.lua:86>
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "@Accountant_Classic\Libs\AceHook-3.0\AceHook-3.0-9.lua"]:95: in function <...\Accountant_Classic\Libs\AceHook-3.0\AceHook-3.0.lua:87>
[string "=[C]"]: in function Show' [string "@Mapster\Mapster-1.9.3.lua"]:110: in function <Mapster\Mapster.lua:110> [string "=(tail call)"]: ? [string "@Blizzard_WorldMap\Blizzard_WorldMap.lua"]:182: in function ToggleWorldMap'
[string "TOGGLEWORLDMAP"]:1: in function <[string "TOGGLEWORLDMAP"]:1>

Locals:
self = WorldMapFrame {
isUndefinedEventAllowed = true
ShouldPanOnClick = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:624
GetGlobalPosition = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:491
PanTo = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:591
AreDetailLayersLoaded = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:405
RemovePin = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:184
OnCanvasScaleChanged = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:535
CalculatePinNudging = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:303
OnCanvasSizeChanged = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:551
HandleUserActionToggleSelf = defined @Accountant_Classic\Libs\AceHook-3.0\AceHook-3.0.lua:100
SetAreaTriggerIntersectsCallback = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:249
ShouldZoomInstantly = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:632
expandedMapInsetsByMapID =

{
}
pinNudgingDirty = true
SetGlobalPinScale = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:773
RefreshDebugAreaTriggers = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:358
SetShouldNavigateOnClick = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:612
NavigateToParentMap = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:722
SetDebugAreaTriggersEnabled = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:382
UnregisterEvents = defined @SharedXML\CallbackRegistry.lua:142
EvaluateLockReasons = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:694
GetGlobalPinScale = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:769
OnLoad = defined @Blizzard_WorldMap\Blizzard_WorldMap.lua:13
RemoveDataProviderEvent = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:97
GetNumActivePinsByTemplate = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:200
SetPinTemplateType = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:173
SetAreaTriggerEnclosedCallback = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:244
IsCanvasMouseFocus = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:680
GetCanvasScale = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:555
SetGlobalAlpha = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:786
RemoveDataProvider = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:86
lockReasons =
{
}
GetScaleForMinZoom = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:652
NavigateToCursor = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:729
AdjustDetailLayerAlpha = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:414
callbackTables =
{
}
SetShouldZoomInstantly = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:628
IsAtMinZoom = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:587
UpdatePinNudging = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:331
ProcessCanvasClickHandlers = defined @Blizzard_MapCanvas\Blizzard_MapCanvas.lua:759
pinPools =
{
}
dataProviderEventsCount =
{
}
HasRegistrantsForEvent = defined @SharedXML\CallbackRegistry.lua:63
mouseClickHandlers =
{
}
SetShouldZoomInOnClick = <fun

commented

should be fixed in new versions, but i have no active subscription and i can not test it right now.
maybe you can test it and report?
thanks :)

commented

I believe the issue is on line 5 of HandyNotes_WorldMapButton.lua:

local isClassicWow = select(4,GetBuildInfo()) < 20000

The following change will allow it to work on both Classic and Burning Crusade Classic:

local isClassicWow = WOW_PROJECT_ID == WOW_PROJECT_CLASSIC or WOW_PROJECT_ID == WOW_PROJECT_BURNING_CRUSADE_CLASSIC