Add community info
JanGalek opened this issue · 6 comments
based on https://github.com/idiomatic/HandyNotes_Achievements/community
- - README
- - Contributing
- - License
- - Code of conduct
Hi i had a issue with HandyNotes_Achievements.lua and was able to fix it.
It was to do with
for nodeIndex = 1, #nodes, 2 do on line 129
however the problem was giving out a nill vale because there are 15 fields now instead of 14
so to fix this i added a extra ",_" to this line
local _, name, points, completed, _, _, _, description, _, _, _, _, _, _, _ = GetAchievementInfo(achievementID)
so there now 15 fields, so fare now more problems.
reference https://wowpedia.fandom.com/wiki/API_GetAchievementInfo
@sidrat, code is fixed-in-the-blind and submitted to Curseforge as 0.6.2. As I do not have a WoW client installed, do let us know if this new version makes things worse.
@sidrat, in future, new issues deserve the honor of a new separate issue.
hi sorry this was my first summited bug fix and wasn't sure if it need a new issue, i have fixed other issues to do with HandyNotes in the past for my own client but have not been able to post until now. would you like me to submit them when i do make a fix?
Strong 👍 on a README.md. However, the others are counter to my laconism, but I won't resist.
I also offer my assistance with copyediting the English versions (as it is my first language).