HandyNotes: Achievements

HandyNotes: Achievements

606k Downloads

add version number to release archives

idiomatic opened this issue ยท 4 comments

commented
commented

Done.

image

commented
  • add TOC-derived version numbers for "release" build zip archives
  • (optionally) add github commit hash or timestamp for all other build types
commented

considering adding to the Publish workflow:

- name: version
  run: echo "::set-output name=VERSION::$(make version)"
  id: version

and

ARCHIVE: HandyNotes-Achievements-${{ steps.version.outputs.VERSION }}.zip

But there's a chicken-and-the-egg problem where the actions runner provides the ARCHIVE environment variable to the step subprocesses. The work-around would be to inline the ARCHIVE value interpolation into the dependent steps run scripts (i.e., archive and upload_curseforge, which currently get it implicitly from env).

This solution is relatively verbose at multiple stack levels, and has a steep learning curve.

commented

alternatively, considering removing ARCHIVE assignment from the Publish workflow and burying it into the Makefile level. this is simpler to implement, but goes in the wrong direction vis a vis transparency and high-level configurability (something that gets more critical if there are additional publish destinations).