Problem calling GetFactionInfoByID

Question

Problem calling GetFactionInfoByID

sauljaffe opened this issue 5 months ago · 11 comments

sauljaffe commented 5 months ago

The following has been appearing a lot in my chat log in Pandaria Remix:

HandyNotes _Achieverents Error: ...
HandyNotes Achievements/
HandyNotes Achievements.lua:378: attempt to call global
"'GetFactionInfoByID' (a nil value)

I don't know what is causing it... and I don't know why BugSack/BugGrabber doesn't catch it. But it has been appearing for the last several days.

22raider · Answer 1 · 2024-08-22T13:56:04.000Z

The same issue with the last updates of the game.

Addonman · Answer 2 · 2024-10-24T12:14:46.000Z

Dont know much about coding but seems that GetFactionInfoByID was changed to C_Reputation.GetFactionDataByID. https://warcraft.wiki.gg/wiki/API_C_Reputation.GetFactionDataByID

22raider · Answer 3 · 2024-11-08T00:33:32.000Z

I have replaced GetFactionInfoByID with C_Reputation.GetFactionDataByID in two lines and for now it is working.

idiomatic · Answer 4 · 2024-11-08T00:43:55.000Z

@22raider can you make a pull request?

sauljaffe · Answer 5 · 2024-11-08T00:58:08.000Z

So have I. I still get errors.

…

On Nov 7, 2024, at 7:33 PM, 22raider ***@***.***> wrote: I have replaced GetFactionInfoByID with C_Reputation.GetFactionDataByID in two lines and for now it is working. — Reply to this email directly, view it on GitHub <#47 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGIRZ3LX6ZUW6N7OYNSF7BTZ7QBHFAVCNFSM6AAAAABL257AMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRTGQ4DSNZTGI>. You are receiving this because you authored the thread.

-- Saul Jaffe ***@***.*** “Together, we must remove the physical barriers we have created and the social barriers that we have accepted. For ours will never be a truly prosperous nation until all within it prosper.” President George Bush upon signing the Americans with Disabilities Act July 26, 1990

Addonman · Answer 6 · 2024-11-05T20:21:59.000Z

if you replace GetFactionInfoByID with C_Reputation.GetFactionDataByID it wil be fixed.

sauljaffe · Answer 7 · 2024-11-05T20:29:05.000Z

I’ve done that. It doesn’t fix it.

…

On Nov 5, 2024, at 3:22 PM, Addonman ***@***.***> wrote: if you replace GetFactionInfoByID with C_Reputation.GetFactionDataByID it wil be fixed. — Reply to this email directly, view it on GitHub <#47 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGIRZ3P6XALMYZ2AXM2UFV3Z7ESH5AVCNFSM6AAAAABL257AMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJYGA4DGNZSGQ>. You are receiving this because you authored the thread.

-- Saul Jaffe ***@***.*** “Together, we must remove the physical barriers we have created and the social barriers that we have accepted. For ours will never be a truly prosperous nation until all within it prosper.” President George Bush upon signing the Americans with Disabilities Act July 26, 1990

sauljaffe · Answer 8 · 2024-11-05T18:16:22.000Z

It doesn't look like anyone is maintaining this any more. It's been 3 months...

Addonman · Answer 9 · 2024-11-05T20:49:31.000Z

My line 378 looks like this

local _, _, standing = C_Reputation.GetFactionDataByID(row.faction)

And this line isnt producing error for me. Not sure what to tell you.

sauljaffe · Answer 10 · 2024-11-05T21:41:50.000Z

That’s exactly what the line says in my file. I wonder if the problem is in a library that the Add-On is using.

…

On Nov 5, 2024, at 3:49 PM, Addonman ***@***.***> wrote: My line 378 looks like this local _, _, standing = C_Reputation.GetFactionDataByID(row.faction) And this line isnt producing error for me. Not sure what to tell you. — Reply to this email directly, view it on GitHub <#47 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGIRZ3NXDPM2JUXG26JZP3DZ7EVPDAVCNFSM6AAAAABL257AMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJYGEZDKNRUHE>. You are receiving this because you authored the thread.

-- Saul Jaffe ***@***.*** “Together, we must remove the physical barriers we have created and the social barriers that we have accepted. For ours will never be a truly prosperous nation until all within it prosper.” President George Bush upon signing the Americans with Disabilities Act July 26, 1990

mfnunicorn · Answer 11 · 2024-11-14T14:40:42.000Z

Same issues. Everytime I load into a new zone (especially main cont like kalimdor, etc) the errors flood my screen.

I went and replaced the old line with C_Reputation.GetFactionDataByID and it fixed it, for me at least.

Share to