Pre-patch update issues
Closed this issue · 6 comments
With the new pre-patch, the addon is now affecting the making of macros. In the macro window, when you make a change to the macro text, on the update tick for the addon, it clears out what you did and reverts it back to what it was. Update for the Roulette macro shouldn't occur while the macro window is open.
Actually, I may be misunderstanding you here. Are you edit the text of the "HearthRoulette" macro, or some other macro?
There's no reason to try to edit the "HearthRoulette" macro. The addon will overwrite your changes after you close the macro window. The macro isn't meant to be edited by the user.
No, not editing the HR macro. Editing any macro or creating a new one. The rotation function of HR is active while the Macro window is opening so while working on macros, it resets the macro frame and wipes out changes before save can be done.
…Sent from my iPhone
On Jul 27, 2024, at 17:58, hascat ***@***.***> wrote:
Actually, I may be misunderstanding you here. Are you edit the text of the "HearthRoulette" macro, or some other macro?
There's no reason to try to edit the "HearthRoulette" macro. The addon will overwrite your changes after you close the macro window. The macro isn't meant to be edited by the user.
—
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_hascat_HearthRoulette_issues_28-23issuecomment-2D2254299131&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=XodWtLBkFpvdbc-aEppP_ibPteZq0Cpnye3A6MMh-wk&m=5Cv7Ph4Sof_M941zs6IddrEBRQyrVGf1lDISvMJ5VRCQ4zciJNzzjMZawBV75L5F&s=qvwor4CPTSzGCx8qorTXoEHtwp6K7BZ-WhGV3akEYH0&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AVZVK5DBXM6Q3YOLHFH6PETZOQ62XAVCNFSM6AAAAABLPPTDUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGI4TSMJTGE&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=XodWtLBkFpvdbc-aEppP_ibPteZq0Cpnye3A6MMh-wk&m=5Cv7Ph4Sof_M941zs6IddrEBRQyrVGf1lDISvMJ5VRCQ4zciJNzzjMZawBV75L5F&s=upGYh0gSUDpZmURrvjEzSuDwLS0-FAQE64cN6iJC0fw&e=>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
All I can think of is that Blizz made a change to the events and when they update, so it is triggering the ChooseHearth function too frequently. What I noticed is that it seems to reset at a constant rate like there was a timer added to one of the Blizz events.
My thought for an easy? workaround would be to check if the Macro frame is open and do a return like you do for combat lockdown. Since the only time it is affecting anything is when that window is open.
…________________________________
From: hascat ***@***.***>
Sent: Friday, August 16, 2024 3:10 AM
To: hascat/HearthRoulette ***@***.***>
Cc: Chad Rice ***@***.***>; Author ***@***.***>
Subject: Re: [hascat/HearthRoulette] Pre-patch update issues (Issue #28)
OK, I'm able to reproduce this. I'll see what I can figure out.
—
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_hascat_HearthRoulette_issues_28-23issuecomment-2D2293229998&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=XodWtLBkFpvdbc-aEppP_ibPteZq0Cpnye3A6MMh-wk&m=NEYxkGh0zPpqJScAd6LcVFunwMqoWz647c3tiI1hZJ3THOpM3OiUN8lFb_FJgani&s=8JhjUBBQmTT8HVJH3kyIRuD8JKUpz4uPSEJcrN53cso&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AVZVK5CGXIZ5PDSRONRF7WLZRXFZZAVCNFSM6AAAAABLPPTDUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJTGIZDSOJZHA&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=XodWtLBkFpvdbc-aEppP_ibPteZq0Cpnye3A6MMh-wk&m=NEYxkGh0zPpqJScAd6LcVFunwMqoWz647c3tiI1hZJ3THOpM3OiUN8lFb_FJgani&s=TPJ6smJSXjmrTuO4iB9jZ1IXhLo-15j6sYGaN1Q30VE&e=>.
You are receiving this because you authored the thread.Message ID: ***@***.***>