FPS in combat drops after update

Question

FPS in combat drops after update

Matrichniy opened this issue 3 years ago · 52 comments

Matrichniy commented 3 years ago

Hello. I really like your addon, but after the last update, fps in combat began to fall by 20-30.
I tried to reduce the display of icons from 3 to 1, it helped a little. But before this was not, I would like to understand the problem, here is all the necessary data for this:

Issue Report:
https://pastebin.com/V9ZVuxU3

Snapshot:
https://pastebin.com/6jvd1K9a

CPU: AMD Ryzen 2700x
GPU: GTX 1080 Ti
RAM: 32Gb

After conducting my investigation to find the source of fps drops, I left only the standard interface and Hekili and the problem was found. Apparently this is the problem of rogue, because in the warrior there are no such fps drops.
I hope we find and fix the problem.

Hekili · Answer 1 · 2021-04-05T12:10:38.000Z

What was the last version that didn't have issues for you? What was the version that this started to happen? I need actual version numbers and snapshots from both, taken when you would have the reported issue.

Hekili · Answer 2 · 2021-04-05T12:23:04.000Z

Also, was that snapshot taken when you were actually experiencing a slowdown? Nothing looks particularly bad about it. Snapshots need to be taken when the problem is occurring, if they are to be useful.

Matrichniy · Answer 3 · 2021-04-05T12:25:10.000Z

What was the last version that didn't have issues for you? What was the version that this started to happen? I need actual version numbers and snapshots from both, taken when you would have the reported issue.

I put it a little wrong. Until the last update, I played on the warrior and on rogue - there were no problems in the warrior (there are no problems now), but there are fps drops when switching to rogue.
I initially thought that the problem was in the update, but as it turned out, after reading a few topics here - the problem is not the update, but in the class.

Matrichniy · Answer 4 · 2021-04-05T12:34:26.000Z

Also, was that snapshot taken when you were actually experiencing a slowdown? Nothing looks particularly bad about it. Snapshots need to be taken when the problem is occurring, if they are to be useful.

Oops. Sorry.
Here is a snapshot of fps drops:
https://pastebin.com/iDaey74p

and screenshots of fps drops:
combat

no combat

Squeeeps · Answer 5 · 2021-04-06T23:31:45.000Z

I've actually been experiencing this same problem on multiple characters, it started about 2 updates ago (that includes the one from 2 days ago). As soon as combat is entered FPS drops to between 25-30 (lowest it has dipped was 15 FPS while in Raid Finder). I've had to disable it across my account as it's simply unusable. So far this has affected my Druid, Mage, Shaman, Paladin, Rogue and Hunter.

Hekili · Answer 6 · 2021-04-07T00:00:08.000Z

You'd still need to supply the same information required for any ticket, @Squeeeps.

Hekili · Answer 7 · 2021-04-07T00:26:21.000Z

If you are having this issue, please provide the following information, together, after a fight that is at least 60 seconds long.

/dump HekiliDisplayPrimary.combatTime
/dump HekiliDisplayPrimary.combatUpdates

Matrichniy · Answer 8 · 2021-04-07T08:34:12.000Z

If you are having this issue, please provide the following information, together, after a fight that is at least 60 seconds long.

/dump HekiliDisplayPrimary.combatTime
/dump HekiliDisplayPrimary.combatUpdates

Matrichniy · Answer 9 · 2021-04-07T08:43:58.000Z

here's a bigger fight

toddctc76 · Answer 10 · 2021-04-07T17:01:05.000Z

I'm just leaving a comment as I've put in a bug report before on the FPS drops when in combat as subtlety rogue. I am still seeing this in sub and assassination rogue (outlaw okay for now) and am now seeing in unholy DK and balance druid. For the rogue, been ongoing for several versions. Not sure when it started for unholy DK. For balance druid, I have not played in a while, but noticed today when going against a dummy. FPS drops anywhere from 20 to 40 when in combat.

Hekili · Answer 11 · 2021-04-07T17:29:22.000Z

@toddctc76 I will still need snapshots and the other information requested above for each spec you're experiencing this on. Thanks!

toddctc76 · Answer 12 · 2021-04-07T18:58:14.000Z

Hi, okay I think I got it. Here is the sub rogue one https://pastebin.com/rHEEywuC
and the destruction lock one https://pastebin.com/Zr5PcfBf

Thanks for your patience!

Hekili · Answer 13 · 2021-04-07T19:05:31.000Z

Just to confirm, those two snapshots were taken at the time you felt performance was degraded, using the addon? The sub rogue one has full energy and no combo points, which makes me think it's out of combat. Weren't you reporting that FPS goes down in combat?

toddctc76 · Answer 14 · 2021-04-07T19:37:08.000Z

Here is another one. I did the previous one thinking the snapshot would collect data as I was in combat; therefore I started it before entering combat. Now I know that is not the case. This one was taken while in combat. https://pastebin.com/4cWhFRqU

toddctc76 · Answer 15 · 2021-04-07T18:36:03.000Z

Hi. Here are the screen shots and dumps. I did them for assassination and subtlety rogue as well as destruction warlock. I know I mentioned balance and unholy before, but am less concerned about those. I know proximity to target can also have an affect on frames.

Hekili · Answer 16 · 2021-04-07T18:36:41.000Z

@toddctc76 Snapshots, not screenshots. But thanks for the other details.

Hekili · Answer 17 · 2021-04-07T18:39:29.000Z

If reporting a disagreement with the addon's recommendations, please take a snapshot when you observe the issue and provide the snapshot. This is not a screenshot. A snapshot can be generated by binding the Pause feature on the Toggles tab. When you press Pause, a snapshot of how the addon decided on its CURRENT recommendations is generated and saved to the Snapshots tab. Copy and paste this to pastebin.com and provide the link here.

PUT SNAPSHOT LINK HERE:

ijoihlhnn · Answer 18 · 2021-04-07T20:15:18.000Z

Here is the Snapshot and combatTime//combatUpdates dump.

/dump HekiliDisplayPrimary.combatTime ->> https://i.imgur.com/jx1fHee.png
/dump HekiliDisplayPrimary.combatUpdates ->> https://i.imgur.com/aBOPaRM.png

AOE Window Snapshot: https://pastebin.com/QfMb2JB8
Primary Window Snapshot: https://pastebin.com/uuR0VrJn

Hekili · Answer 19 · 2021-04-07T23:50:08.000Z

The other information that would help for troubleshooting purposes is if folks could help pin down exactly which version of the addon represents when the performance decrease started. I'd do it myself except...I don't get any performance decrease. :|

toddctc76 · Answer 20 · 2021-04-08T00:27:07.000Z

Tomorrow I will go back through old versions and see if I can find the last one that didn’t cause it. Seems like it started happening a few months ago. I will start further back, however. I also have a Ryzen 5 1600x CPU.

Karalum · Answer 21 · 2021-04-07T23:34:15.000Z

i can confirm, just come here to tell you this problem but i saw someone open this thread. game is stuttering in combat. im dk. also using ryzen cpu 3600X. if i disable addon, everything goes perfect.

Matrichniy · Answer 22 · 2021-04-08T07:57:13.000Z

The other information that would help for troubleshooting purposes is if folks could help pin down exactly which version of the addon represents when the performance decrease started. I'd do it myself except...I don't get any performance decrease. :|

I can assume that the point is to optimize the addon for Ryzen CPU's

Lipstopica · Answer 23 · 2021-04-08T08:15:55.000Z

The other information that would help for troubleshooting purposes is if folks could help pin down exactly which version of the addon represents when the performance decrease started. I'd do it myself except...I don't get any performance decrease. :|

I can assume that the point is to optimize the addon for Ryzen CPU's

I honestly don't think it works like that, doesn't matter what brand of CPU that you use. I mean, it wouldn't make sense.

Matrichniy · Answer 24 · 2021-04-08T11:22:33.000Z

The other information that would help for troubleshooting purposes is if folks could help pin down exactly which version of the addon represents when the performance decrease started. I'd do it myself except...I don't get any performance decrease. :|

I can assume that the point is to optimize the addon for Ryzen CPU's

I honestly don't think it works like that, doesn't matter what brand of CPU that you use. I mean, it wouldn't make sense.

But the performance problems are mostly with the owners of Ryzen, if you look at the reviews and open topics.

Hekili · Answer 25 · 2021-04-08T12:51:37.000Z

There's literally nothing I can do within WoW itself to deal with CPU architecture at all. But it's definitely interesting that Ryzen seems to be a common factor here. I think I have a Ryzen box somewhere I can do some testing with. Are folks experiencing issues using DX11 or DX12?

I still need to pin down if there's really one version that works fine and then the next version that slows down. Can someone backtrack through recent releases?

toddctc76 · Answer 26 · 2021-04-08T15:03:51.000Z

I tested a handful as far back as I could go and still had FPS issues. Here are the versions I tried.
feb 13 v9.0.2-1.0.40
feb 14 v9.0.2-1.0.40a
mar 10 v9.0.5-1.0

I've been using DX12. I just tried DX11 and noticed my overall FPS was up. Using my sub rogue in combat against a training dummy with DX11 and the issues still were there and using the latest version of Hekili.

I understand that Ryzen might be a common denominator, but the issues are not occurring on every spec and class, just some.

toddctc76 · Answer 27 · 2021-04-08T15:04:48.000Z

If you have some older ones that are not available on the site, I am willing to try. I would like to try back at the beginning of Shadowlands. I don't remember having issues then or during BFA.

Hekili · Answer 28 · 2021-04-08T15:10:26.000Z

Every version ever released is right here on GitHub.

Matrichniy · Answer 29 · 2021-04-08T18:49:04.000Z

DX12 > DX11 drops equally for me and my Ryzen 2700x

Hekili · Answer 30 · 2021-04-08T19:28:11.000Z

@toddctc76 Thanks for the research and the support. I'm going to have to try some gimmicky stuff to work around, I think it's just the WoW doesn't multithread well on Ryzen. I may be able to split the work of generating recommendations across multiple frames. Maybe.

toddctc76 · Answer 31 · 2021-04-08T17:42:00.000Z

I don't know if anyone else has tried any of the older versions yet, but I tried the following with DX12:
Oct 31, v9.0.1-1.0.18 - FPS drops by 20 to 30, game stuttering.
Nov 6, v9.0.1-1.0.24 - same as above
Nov 17, v9.0.2-1.0.0 - same as above. Tried with DX11 on this one and slightly better.
Nov 23, v9.0.2-1.0.4 - same as above.
Dec 6, v9.0.2-1.0.16 - same as above.
Tried the latest version (just to re-verify) and noticed the same. However, I'm seeing less dips into the 50s during combat vs some version prior to latest, so that is great.

Appreciate all the hard work you're doing with this amazing addon! Not sure what a good donation is, but I made one. Thanks again for the great addon.

pirotess66 · Answer 32 · 2021-04-11T18:59:34.000Z

what version number do you want from me? i posted to you that with version v9.0.5-1.0.5 EVERYTHING was fine.

AFTER v9.0.5-1.0.6 i have harder framedrops then usual

isnt this enough info for you? i mean several people are reporting issues here for the last 5-6 days. and the addon was updated 7 days ago. idk what u want me to provide you

Hekili · Answer 33 · 2021-04-11T19:26:31.000Z

Hey, I don't want anything from you that you're going to get upset about. Thanks. I'll continue to research on my own. Take care.

pirotess66 · Answer 34 · 2021-04-11T19:49:19.000Z

no i want to help you fix the problems. i mean ive used ur addon for quite a time and i want to provide any informations u need to make it better in any case

SlipsknuteN97 · Answer 35 · 2021-04-11T21:06:45.000Z

Hey I have huge FPS and lag issues with this addon. I have the latest updates aswell.
AMD Ryzen 7 1700
Corsair Vengence 16GB RAM
GTX 1070

EDIT: I bought a new GPU (RTX 3060) becouse I thought it was my GPU giving up on me but I had same issues on the 3060. I had this problem for around 4 weeks.

Hekili · Answer 36 · 2021-04-11T21:27:34.000Z

@SlipsknuteN97 If you look back in the thread, I'd ask you to try different versions of the addon and let me know if/when there's a previous version that works better. Ideally with FPS numbers and the other regular ticket information (i.e., a snapshot taken in combat, read the instructions re: snapshots).

toddctc76 · Answer 37 · 2021-04-11T13:17:00.000Z

I ran wow with Hekili on an intel core i5 laptop and had no issues with FPS drops or stuttering. Not sure this will make a difference, but this week I will try disabling cores on my ryzen pc and see what happens. Probably nothing, but worth a shot.

pirotess66 · Answer 38 · 2021-04-11T14:33:22.000Z

i created an account to report the same issues:

On FireMage, i have HEAVY drops on HEKILI but this is due to the fire mage spec.
On MM hunter, i have none to very low drops - like 20 from 120 to 100ish
On Boomie my fps drops to like 70 at all - probably like fire mage

since about one week its dropping way harder on every char. im using an 9700k at 5ghz

Hekili · Answer 39 · 2021-04-11T14:38:07.000Z

@pirotess66 Boomkin is fairly complex as well, so having more usage isn't surprising. If it's worsened on every character, what I'd need to hear from you is:

What is the last version of the addon that doesn't have this issue for you? What is the first version that starts to have this performance impact for you?

pirotess66 · Answer 40 · 2021-04-11T14:55:08.000Z

@Hekili
yea i thought boomie rotation will use much more then MM for example,im fine with that at all.

i think it happened since the last update. on v9.0.5-1.0.5 i hadnt that performance issues.

im rolling back on the previous version.

Do you have any solutions for boomie ? On Balance -> performance there are some options like throttle updates or something but i dont have any clue what to do there

Hekili · Answer 41 · 2021-04-11T15:23:19.000Z

No, no real recommendations regarding different settings.

If you provide more information, it really has to be specific and confirmed. That is, not that you think it happened with a particular version, rather that you are using version A and seeing X FPS, but when you switch to version B you see Y FPS.

pirotess66 · Answer 42 · 2021-04-11T16:08:41.000Z

ive changed nothing at all, just can tell that the fps drops on all chars that are using hekili were harder since about 5-7 days.

Hekili · Answer 43 · 2021-04-11T16:10:11.000Z

Okay, someone else will have to help provide version numbers then.

Matrichniy · Answer 44 · 2021-04-12T07:51:15.000Z

after practicing on the mannequin, I can say that there are no special fps drops on warrior, but as soon as I switch to rogue, the fps drops to 30-40

Hekili · Answer 45 · 2021-04-12T12:12:40.000Z

@pirotess66 I absolutely didn't say it's a personal problem. Please don't make things up. I said I can't replicate it, myself, which is why I ask for data to help sort it out. If you aren't contributing specific measurable data that can help diagnose or solve the issue, please don't post again. Thanks.

Hekili · Answer 46 · 2021-04-12T12:15:04.000Z

@Matrichniy Which rogue spec(s)? They're all different. If you go back to an older version, at what point does the issue go away?

SlipsknuteN97 · Answer 47 · 2021-04-12T16:04:01.000Z

@Hekili Hey thanks for the response. Not really sure how I can do that but I will try to research that. I love this addon, totally amazing so I hope I will be able to fix it. Amazing work.

Hekili · Answer 48 · 2021-04-13T20:45:07.000Z

@Dajova Fire Mage doesn't count, because the Fire APL is ridiculous. For the record, and to avoid any confusion, I'm not debating that the addon uses CPU (and more than most). Folks are reporting that CPU usage has increased recently, but I'm struggling to get responses that indicate when an increase has occurred vs. a previous version.

Dajova · Answer 49 · 2021-04-13T20:34:03.000Z

I can chip in here and can confirm that Hekili is indeed making a huge fps spike on certain class/specs. Here's the actual CPU usage after 1 fight with 2 mobs on my Fire Mage (literally just 10 sec, does not happen in Arcane Spec):

GIF

Hekili · Answer 50 · 2021-04-14T02:37:38.000Z

1.0.7-beta1 will be available in a little bit. I've found that, while Fire Mage's computation time was high, it was also refreshing more often than is necessary for accuracy. I'll be interested to hear if any difference is noted in performance.

SlipsknuteN97 · Answer 51 · 2021-04-14T14:35:30.000Z

@Hekili Thanks mate, might be the problem for me aswell since I main Fire Mage too

Hekili · Answer 52 · 2021-04-15T14:04:00.000Z

The latest release has all the performance enhancements that were underway. I'm going to close this ticket and create a new kind of ticket for performance related concerns.

Share to