Hunter remains_guess bug

Question

Hunter remains_guess bug

bje259 opened this issue 5 years ago · 1 comments

bje259 commented 5 years ago

Describe the Bug/Issue
Action List entries leveraging the cooldown remains_guess functionality were throwing an error related to query_time being null.
Error text: 2320: attempt to perform arithmetic on global 'query_time' (a nil value)

Potential Fix:
Update lines in the mt_default_cooldown table to include state prefix for query_time

File:State.lua
Line:2320
Current: local reduction = ( query_time - lastCast ) / ( t.duration - t.remains )
Updated: local reduction = ( state.query_time - lastCast ) / ( t.duration - t.remains )
Line:2330
Current: local reduction = ( query_time - lastCast ) / ( t.duration - t.remains )
Updated: local reduction = ( state.query_time - lastCast ) / ( t.duration - t.remains )

To Reproduce
Update the Action list using the latest BM APL (this introduces the remains_guess function into the cleave action list for Bestial Wrath)
Steps to reproduce the behavior:

On a BM hunter start combat with multiple targets (to trigger the cleave action list) and use Aspect of the Wild so there is a value for lastCast
Bestial Wrath will no longer show as a recommended action
View the Bestial Wrath action list item in the cleave action list
See error for cooldown.aspect_of_the_wild.remains_guess

Expected behavior
Action list items leveraging the remains_guess function should continue being recommended after the first use.

Issue Report Link: https://pastebin.com/6KZu6Dxu

Hekili · Answer 1 · 2019-04-19T04:59:54.000Z

Thanks, this will get taken care of in the morning.

…

On Fri, Apr 19, 2019, 12:24 AM bje259 ***@***.***> wrote: *Describe the Bug/Issue* Action List entries leveraging the cooldown remains_guess functionality were throwing an error related to query_time being null. Error text: 2320: attempt to perform arithmetic on global 'query_time' (a nil value) Potential Fix: Update lines in the mt_default_cooldown table to include state prefix for query_time File:State.lua Line:2320 Current: local reduction = ( query_time - lastCast ) / ( t.duration - t.remains ) Updated: local reduction = ( state.query_time - lastCast ) / ( t.duration - t.remains ) Line:2330 Current: local reduction = ( query_time - lastCast ) / ( t.duration - t.remains ) Updated: local reduction = ( state.query_time - lastCast ) / ( t.duration - t.remains ) *To Reproduce* Steps to reproduce the behavior: - On a BM hunter start combat with multiple targets (to trigger the cleave action list) and use Aspect of the Wild so there is a value for lastCast - Bestial Wrath will no longer show as a recommended action - View the Bestial Wrath action list item in the cleave action list - See error for cooldown.aspect_of_the_wild.remains_guess *Expected behavior* Action list items leveraging the remains_guess function should continue being recommended after the first use. Issue Report Link: https://pastebin.com/6KZu6Dxu — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#107>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACIAHNUL2G7NKKSHZGBDD3DPRFCPTANCNFSM4HHB32IA> .

Share to