Hekili Priority Helper

Hekili Priority Helper

44M Downloads

[REC] Elemental Shaman - Frost Shock during movement

larskeizer opened this issue · 4 comments

commented

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I edited the title of this bug report (above) so that it describes the issue I am reporting.
  • I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).

Describe the Issue

For elemental shamans, the addon correctly advises Spiritwalker's Grace during movement. There are however times that there is movement and no spells able to be cast (too low maelstrom, nothing to renew.) - At these moments it would be grant if the addon recommends Frost Shock to be used as a filler. It doesn't do much damage, but on heavy movement fights it definitely adds up.

How to Reproduce

  1. Make sure Spiritwalker's Grace is ON cooldown
  2. Run around and do some casts, when there is nothing to cast, there is quite a lot of downtime and instead frost shock could and should be used as a filler

Snapshot (Link)

https://pastebin.com/NuMGS6y3

Additional Information

No response

Contact Information

Lars#8888

commented
commented

This is not an uncommon request. The problem is, do you want the addon to tell you the best thing to do or just what you can do while you're moving? The addon has no way of knowing if you can/will stop moving imminently or not, and you already know that you can always hit Frost Shock, so do you need the addon to call that out?

Generally speaking, your optimal DPS decision is to stop moving and get your hardcasts in.

commented

It's possible, but possibly not incredibly valuable. In this case, it would simply be telling you to Frost Shock as you move (if SWG is not up and on CD).

You can already accomplish most of this with your own custom priority, but that has its own caveat that you'll have to manually make updates if/when I update the defaults. See https://github.com/Hekili/hekili/wiki/Frequently-Asked-Questions.

Here's a quick look at the Elemental priority with the default action list Entry dropdown expanded.

image

If you look at the entry for Spiritwalker's Grace and then check Show Modifiers you can see that it's set up to check for movement.

image

We can set up a Frost Shock entry basically the same way.

Click the green plus, check Enabled, select Frost Shock, and we'll use the condition buff.spiritwalkers_grace.down which means we do not have SWG active. I'll set up the same movement check as SWG, too.

image

The last piece is knowing where this belongs in the priority. I'm genuinely not doing sim testing to prove anything, we're just going to do it since we know this is what you want. If we look at the first screenshot, we can assume that any of these high-priority instants that we'd be able to cast while moving, should still be cast at a higher priority than this Frost Shock. Fae Transfusion is the first in the list with a cast time (and you may not even have that, if you're not a Night Fae) so we'll position it above Fae Transfusion. That leaves us with no hardcasts higher in priority than our Frost Shock. Use the Up triangle to move this entry to position 16.

image

Stationary:
image

Moving:
image

Read that Wiki entry so you catch the part about making a copy of the default priority so your changes aren't obliterated when I update the default, and then keep an eye out for default updates so you can manually reimplement your changes if/when needed.

commented