[REC] Balance opener changes from Wrath, Wrath, Starfire
noiseuu opened this issue · 23 comments
Before You Begin
- I confirm that I have downloaded the latest version of the addon.
- I checked for an existing, open ticket for this issue and was not able to find one.
- I edited the title of this bug report (above) so that it describes the issue I am reporting.
- I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).
Describe the Issue
Hello
I just tried addon, and i saw one thing
In Dreamgrove it suggest opener: Night Fae - no BoAT (with NB):
Wrath, Wrath, Starfire, dots, CA, Starsurge 2x, Convoke, Starsurge until you have no more AsP, New Moon, Half Moon, Starsurge, Full Moon
But hekili wants use Wrath, Dots, CA, Starsurge 2x, Convoke
And im atm talking about missing that starfire
How to Reproduce
- Target dummy
- Talents for single target
- Followed my full opener
Snapshot (Link)
Raidbots Sim Report (Link)
https://gyazo.com/5414ba51f0f755af8cf0bfda34867a27
Additional Information
No response
Contact Information
No response
https://pastebin.com/k592Kb6U
This pastebin is atm max range from target
The sim opener is contingent on you standing far enough to start your second Wrath before your first hits the target.
But why it doesnt suggest after 2x Wrath 1x Starfire? Is because its precombat thing?
Sorry, my bad
https://pastebin.com/3cHzC15n
This is max range, i hope this gives more information. I sometimes doesnt know make snapshot :D
And this pastebin i was having 50 astral power
I can confirm the issue regarding hekili not recommending CA/INC/Ravenous Frenzy.
Can u check, pelase?
Don't know if I did the snapshot right but here it goes.
In extension to this Venthyr balance is not recommending covenant and/or Celestial Alignment (also Incarnation, talent) on opener.On Sun, Jul 25, 2021 at 6:43am, noiseuu @.> wrote: Sorry, my bad https://pastebin.com/3cHzC15n This is max range, i hope this gives more information. I sometimes doesnt know make snapshot :D —You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or unsubscribe. [ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "#1178 (comment)", "url": "#1178 (comment)", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]
Open a separate ticket for the cooldowns issue.
For the opener, supply a snapshot of the opener. The snapshots I've looked at here are not taken at the opener. For example, you've already used CA/Inc. if you're reporting that the addon doesn't recommend Wrath, Wrath, Starfire to open, supply a snapshot of what it does recommend when you're opening from max range.
https://gyazo.com/2aaed5fdd5b55699a810e54766194380
i took this gif, i can still give u pastebin, but i feel u dont understand when i post it. Every pastebin is with cooldowns and max range so.
- pastebin.com/k592Kb6U
- This snapshot has Incarnation up, IQD's buff up, and the target already has Moonfire, Sunfire, and Stellar Flare applied. This is not a snapshot from the circumstances you were reporting.
- pastebin.com/3cHzC15n
- Same as above (but earlier in Incarnation).
- pastebin.com/NkxQyZkX
- This is at the tail end of a Lunar Eclipse.
A snapshot captures a point in time. You snapshot when it is recommending what you're concerned about, not after.
- gyazo.com/2aaed5fdd5b55699a810e54766194380
The GIF is of the correct timeframe, but doesn't offer any useful debugging information, because it's not a snapshot. Snapshot the opener recommendations (Wrath, Wrath, Starfire). Snapshot when the recommendations change from Wrath, Wrath, Starfire.
The result is mainly going to be that combat started, but I'll answer when there's data I can analyze.
https://pastebin.com/5vuYe1jD
Okay lets try that, if i fucked up then i cant use this your snapshot.
And i just realise i dont have correct talents, but i feel same opener with those talents is correct
Well, I did ask for two snapshots, and that is one single snapshot, so we're not off to a great start.
From the look of it, I'm assuming that this is after you've cast Wrath once, since you have 56 AP (generated 6 from your Wrath cast) and Wrath will hit in 0.68 seconds.
At the point you took the snapshot, you're in-combat, so the remainder of the precombat priority is no longer applicable. Any thoughts on why you're in combat before your Wrath has impacted?
@mickeygeecom @AleSSouza Reminder to open a ticket for the cooldowns issue.
I'm also confused why your GIF shows 3 icons but your snapshot shows only 1.
I enjoy more have 1 icon, than 3 and i just showed how icons was.
Well, I did ask for two snapshots, and that is one single snapshot, so we're not off to a great start.
From the look of it, I'm assuming that this is after you've cast Wrath once, since you have 56 AP (generated 6 from your Wrath cast) and Wrath will hit in 0.68 seconds.
At the point you took the snapshot, you're in-combat, so the remainder of the
precombatpriority is no longer applicable. Any thoughts on why you're in combat before your Wrath has impacted?
So, u want precombat snapshot not like in combat?
Snapshot the opener recommendations (Wrath, Wrath, Starfire).
Snapshot when the recommendations change from Wrath, Wrath, Starfire.
https://pastebin.com/SUtAXqFb ( snapshot the opener recommendations )
https://pastebin.com/HUdPgHn8 ( snapshot when recommendations change )
So the issue centers on the simulation not treating you as though you're in-combat until your first damaging spell impacts. However, in-game, you are in combat as soon as Wrath finishes casting. I can modify the way the opener is implemented and probably take care of this, but I'll also need to wait on the other issue report about Venthyr and CDs.
In the meantime, use your good judgment and open with Wrath, Wrath, Starfire and pick up from there, if you're starting from a "fresh" pull.
No worries, it was a good call-out. I'm not sure why the player goes in-combat before the target's actually been hit. May just be something with dummies. Not sure.