Hekili Priority Helper

Hekili Priority Helper

44M Downloads

Addon seems to stall with using Relic of the Frozen Wastes.

lkj61 opened this issue · 57 comments

commented

Before You Begin

  • I confirm that I have downloaded the latest version of the addon.
  • I am not playing on a private server.
  • I checked for an existing, open ticket for this issue and was not able to find one.
  • I edited the title of this bug report (above) so that it describes the issue I am reporting.

Describe the Issue

I am using this trinket on my beastmaster hunter, and the addon seems to stall there. I swapped it out with a different trinket, and it seems to work fine now.

How to Reproduce

I swapped the trinket back in, and it seems to stall again.

Player Information (Link)

https://pastebin.com/QYijVJwi

Error Messages (Link)

https://pastebin.com/QYijVJwi

Additional Information

No response

Contact Information

lkj61

commented
commented

This is a defect in SpellFlash (it doesn't load spells/items using modern API). I'm sending a fix over to them.

commented
commented
commented
commented

Show your "Player Information" from /hekili.

commented

Do you have in-game error messages?

Can you show where your trinket is bound? (i.e., a clipped screenshot)

commented
commented

Also, did you cut the Player Information part short? You should have more abilities listed in keybindings.

commented

One more question -- do you have SpellFlashCore installed separately? I.e., an AddOns/SpellFlashCore folder? If so, delete it.

commented
commented
commented

Do you have BugSack/BugGrabber installed? Error messages?

When you updated, what did you use to update? I'm not sure you actually got the SpellFlash changes.

commented
commented

I'm not able to see that image.

Can you confirm this file is installed: https://github.com/Hekili/hekili/releases/download/v9.2.0-1.0.4a/Hekili-v9.2.0-1.0.4a.zip

You can go into Hekili/Lib/SpellFlashCore and attach SpellFlashCore.lua here so I can verify.

commented
commented
commented

That doesn't work; you'll need to add through the site.

#1370

This would be the latest one to test with: https://github.com/Hekili/hekili/releases/download/v9.2.0-1.0.5-beta1/Hekili-v9.2.0-1.0.5-beta1.zip

commented

No, you're still sending emails. Go to the website.

commented
commented

I installed the version you just linked. I will give that one a try as soon as the servers come back up.

commented
commented

I don't know, I never saw your picture nor whether you had the right file installed.

commented
commented
commented

I'm not able to duplicate this issue after these fixes. The last test I can recommend is using that latest version of the addon with only Hekili loaded (no other addons). If flashes still break down, let me know about it. You may check whether some other addon is supplying an older version of SpellFlashCore that doesn't work. Otherwise, if there are no error messages and no other information you can supply, I'd refer you to SpellFlashCore's project to report an issue.

commented
commented
commented
commented

Are there error messages?

What do you mean by "stall" precisely?

commented
commented

Here's a link to the video of what I was referring to.

https://drive.google.com/file/d/10NvxhaUPDK8U4vpNaVt7CXoU-HXAglxN/view?usp=sharing

commented

Okay, I found where I can disable it. I will give it a try.

commented

That is a very, very large (half gigabyte) video. You should probably clip it to the relevant part. I also never saw your screenshot.

I'm honestly not sure the whole scope of your issue at this point. If you can put your explanation, picture, and snapshot altogether in one cohesive summary, I can do a better job of investigating.

Relic sits at the front of the queue? Even if used?
Relic is at front of queue but doesn't flash?
Both of the above?
Something else?

You can disable any item via /hekili > Gear and Trinkets > [item name] > Disable [item name]. The setting is per-spec.

commented
commented

Everything flashes when the rotation first starts, but when the trinket timer resets, then it stops until I manually click it. Then it starts back up. When I end the fight and start another, it won't start flashing again until I manually use the trinket.

commented
World.Of.Warcraft.2022.03.03.-.11.19.52.02_Trim.2._Trim.mp4
commented

I hope that shows what I am talking about.

commented

Are you saying that it will flash the trinket in your character panel initially, and then not afterward? I'd be surprised to see anything flash in the character panel to begin with.

If the addon's recommendation doesn't exist on action bars, SpellFlash will just quietly fail. If you put your trinket onto your action bars, does it flash as expected?

commented

No, it doesn't flash in my character pane. I left that open so that you could see the timer reset on it and then the bars stop flashing until I click the trinket. I disabled the trinket in the addon and everything flashes as it should now.

commented

Ok, yeah -- the issue there is that a trinket won't flash if it's not on an action bar, the addon has no mechanism to let you know that recommendations are blocked that way when you have the addon display disabled.

I may add some kind of warning message in such cases, in case this comes up again. Thanks for following up with that info.

commented

It's the first time I've ever had to disable a trinket. All the others work just fine in the rotation. If I swap that one out with another trinket, the flashing never stops like it does with that one trinket.

commented

I'm not sure how that would work, unless you've lucked into having passive trinkets that aren't recommended by the addon (because you don't use them directly). Or if you had them macro'd so they were getting put on CD when you used your cooldowns anyway.

commented

For example, I replace that trinket with Titanic Ocular Gland, and it doesn't affect my rotation flashing. As soon as I put the other in, it does what it shows in the video, that when the trinket resets, it stops flashing until I click on it again.

commented

I hope that makes sense?

commented

Yeah, that makes sense -- Titanic Ocular Gland doesn't have a "Use:" effect, so it's never recommended, so it would never block. Any other trinket with a "Use:" would block in the same way. It can be useful to have a /use 13 and /use 14 macro on your bars, so that if you equip a usable trinket, you have a consistent keybind for it.

commented

I will give that a try. Thank you. ;)

commented

Okay, I tried out your "Use:" theory. I swapped in Brimming Ember Shard, it triggered, everything was flashing, and it continued to flash, even when the timer on the trinket reset. It all worked as it should with that trinket equipped.

commented

So what was flashing when it was time to use Brimming Ember Shard?

commented

Meh, I can't get it to do it again. :/ I'll send a video if/when it happens again.

commented

Okay, you saw what it did in the video. Trinket was triggered, everything flashed as it should in the rotation until the timer on the trinket reset. I put in the Brimming Ember Shard, and it didn't trigger on it's own and when I did trigger it, everything flashed as it should throughout the rest of the rotation. When the Relic of Frozen Waste is equipped, it is triggered in the rotation, not by me, and that's when the situation occurs.
The Brimming Ember Shard IS NOT triggered by the rotation, but manually. Does that make sense?

commented

If the priority would never recommend Brimming Ember Shard, then Brimming Ember Shard would never block.

commented

Meaning, I never trigger the Relic trinket, it does it on it's own.
The Brimming Ember Shard I have to trigger.

commented

Ah. Gotchcha. Thanks for explaining. Sorry to be such a bother. And I do thank you for your time.

commented

Not a problem. Sorry that I wasn't grasping what you were saying at first. Thanks for providing more info.

commented

I was away from WoW for several years. I had previously used Spellflash and it's addons for classes. I was a bit distraught when I discovered that it was no longer updated. Then I tried a variety of other rotation helpers until I came across yours and I was instantly smiitten. :)