[REC] Outlaw w/ Concealed Blunderbuss recommends pistol shot at max CP with Blunderbuss proc active
fzarr opened this issue · 7 comments
Before You Begin
- I confirm that I have downloaded the latest version of the addon.
- I am not playing on a private server.
- I checked for an existing, open ticket for this issue and was not able to find one.
- I edited the title of this issue (above) so that it describes the issue I am reporting.
- I am reporting an issue with the default priority included with the specialization (imported or edited priorities are not supported).
Describe the Issue
Expected to use a finisher at max cp (or even max cp -1) first, otherwise over-capping a lot of CP from using the blunderbuss proc.
How to Reproduce
Difficult to reproduce this one as it doesn't always happen. I followed the rotation on a target dummy until I was able to produce a snapshot of the issue.
Snapshot (Link)
Raidbots Sim Report (Link)
No response
Additional Information
No response
Contact Information
No response
I think this might be caused by the finish_condition variable not getting set correctly:
From the snapshot:
combo_points.current[5.00] >= cp_max_spend[6.00] - buff.broadside.up[false] - ( buff.opportunity.up[true] * talent.quick_draw.enabled[false] | buff.concealed_blunderbuss.up[true] ) | effective_combo_points[5.00] >= cp_max_spend[6.00]
The expression cp_max_spend[6.00] - buff.broadside.up[false] - ( buff.opportunity.up[true] * talent.quick_draw.enabled[false] | buff.concealed_blunderbuss.up[true] ) should be calculated as 5 due to buff.concealed_blunderbuss.up being true and subtracting 1, but not sure if that is happening here?
FWIW: quickly checked this out on latest alpha.
https://pastebin.com/8RvxvUEg
Try editing Outlaw - default - 5 from:
combo_points >= cp_max_spend - buff.broadside.up - ( buff.opportunity.up * talent.quick_draw.enabled | buff.concealed_blunderbuss.up ) | effective_combo_points >= cp_max_spend
To:
combo_points >= cp_max_spend - buff.broadside.up - ( buff.opportunity.up & talent.quick_draw.enabled | buff.concealed_blunderbuss.up ) | effective_combo_points >= cp_max_spend
(The change is * to &.)
https://pastebin.com/mcDPktd0 to confirm this fix.